Rails core - Jul 2006 - [PATCH] low complexity -- Integration test''s version of XHR does not properly emulate XHR

The trac was down, so I''ve attached a patch here instead.

There''s a somewhat serious bug in the implementation of faux XHR for
integration tests. Although the proper X-Requested-With is set, the
proper HTTP_ACCEPT isn''t.

What this means is that request.xhr? will return true, but respond_to
js won''t catch--pretty lethal if you use respond_to a lot.

The test process implementation of xhr does not suffer from this shortfall.

I''d like to respectfully request a patch, provided someone has the
time to take a look.

Cheers,

Eddie Frederick
Revolution Health Group
edward.frederick@revolution.com


_______________________________________________
Rails-core mailing list
Rails-core@lists.rubyonrails.org
http://lists.rubyonrails.org/mailman/listinfo/rails-core

> There''s a somewhat serious bug in the implementation of faux XHR
for
> integration tests. Although the proper X-Requested-With is set, the
> proper HTTP_ACCEPT isn''t.
Applied.
-- 
David Heinemeier Hansson
http://www.loudthinking.com -- Broadcasting Brain
http://www.basecamphq.com   -- Online project management
http://www.backpackit.com   -- Personal information manager
http://www.rubyonrails.com  -- Web-application framework