I''ve just noticed that my apps running on trunk don''t handle RoutingErrors properly any more. Visiting a junk URL (http://myhost/fsdfsf) displays a kind-of-broken 500 message instead of a 404. As far as I can tell, this is due to the patch applied in [4589]: http://dev.rubyonrails.org/changeset/4589 Reverting this change fixes the problem for me. I''ve tried investigating why the patch causes this behaviour, but I can''t work it out. Anyone else got any ideas? Can someone revert the patch for now? Alisdair
On 7/28/06, Alisdair McDiarmid <alisdair@randomoracle.org> wrote:> I''ve just noticed that my apps running on trunk don''t handle > RoutingErrors properly any more. Visiting a junk URL > (http://myhost/fsdfsf) displays a kind-of-broken 500 message instead > of a 404. > > As far as I can tell, this is due to the patch applied in [4589]: > > http://dev.rubyonrails.org/changeset/4589 > > Reverting this change fixes the problem for me. I''ve tried > investigating why the patch causes this behaviour, but I can''t work it > out. Anyone else got any ideas? Can someone revert the patch for now? > > AlisdairI think you''re correct since ActionController is a module. It should be calling the process_with_exception method on the current controller instance. -- Rick Olson http://techno-weenie.net
On 7/28/06, Rick Olson <technoweenie@gmail.com> wrote:> On 7/28/06, Alisdair McDiarmid <alisdair@randomoracle.org> wrote: > > I''ve just noticed that my apps running on trunk don''t handle > > RoutingErrors properly any more. Visiting a junk URL > > (http://myhost/fsdfsf) displays a kind-of-broken 500 message instead > > of a 404.Booya -- http://dev.rubyonrails.org/changeset/4629 -- Rick Olson http://techno-weenie.net
Alisdair McDiarmid
2006-Jul-28 23:16 UTC
Re: Re: Trunk since [4589] breaks RoutingError handling
On 7/29/06, Rick Olson <technoweenie@gmail.com> wrote:> On 7/28/06, Rick Olson <technoweenie@gmail.com> wrote: > > On 7/28/06, Alisdair McDiarmid <alisdair@randomoracle.org> wrote: > > > I''ve just noticed that my apps running on trunk don''t handle > > > RoutingErrors properly any more. Visiting a junk URL > > > (http://myhost/fsdfsf) displays a kind-of-broken 500 message instead > > > of a 404. > > Booya -- http://dev.rubyonrails.org/changeset/4629Great, thanks for the rapid fix! Alisdair