Rails core - Jul 2006 - trac: verified patches report matches unverified patches too

The verified patches report (http://dev.rubyonrails.org/report/12)  
matches unverified patches.

Probably, it''s due to a query like this:

   keywords LIKE ''%verified%''

the query should be changed to exclude unverifieds:

   keywords LIKE ''%verified%'' AND keywords NOT LIKE
''%unverified%''

I''m in the process of fixing this,  however trac and I have a
disagreement on whether or not it should work.

Any attempt to update the report appears to just delete the sql query.
  I''ll have someone else have a look at it, but in the meantime the
situation is now ... significantly worse ;)



On 7/23/06, Caio Chassot <lists@v2studio.com>
wrote:
> The verified patches report (http://dev.rubyonrails.org/report/12)
> matches unverified patches.
>
> Probably, it''s due to a query like this:
>
>    keywords LIKE ''%verified%''
>
> the query should be changed to exclude unverifieds:
>
>    keywords LIKE ''%verified%'' AND keywords NOT LIKE
''%unverified%''
> _______________________________________________
> Rails-core mailing list
> Rails-core@lists.rubyonrails.org
> http://lists.rubyonrails.org/mailman/listinfo/rails-core
>

-- 
Cheers

Koz

On 2006-07-22, at 22:27 , Michael Koziarski wrote:
>
> Any attempt to update the report appears to just delete the sql query.
>  I''ll have someone else have a look at it, but in the meantime the
> situation is now ... significantly worse ;)
I see trac''s been showing much hate for us in the last week or so.

The innability to create new tickets is especially nice.

Any words on how things initially broke? Just curious.

If you could post the trac instance and db somewhere, I''d love to  
take a peek at whatever has gone wrong.

Hi there,

    I submitted patch #4353 quite a while ago to allow the use of bigint 
integer types in MySQL. I got some feedback David and generalized it so 
that :limit in MySQL acts like it does for other databases. Just 
recently, I refactored it again so that it was transparent to all of the 
other database adapters.

    Let me know if it needs more love, I''m willing to give it.

Thanks,
Steve

Hi there,

    MySQL doesn''t use the :limit option like most other databases do.
In
MySQL :limit sets the number of characters displayed, not the number of 
bytes in a column. MySQL uses different integer types for this purpose.
See http://dev.mysql.com/doc/refman/5.0/en/numeric-types.html for 
additional information on this.

    I submitted patch #4353 quite a while ago to allow the use of bigint
integer types in MySQL. I got some feedback David and generalized it so
that :limit determines the MySQL integer type to be used. And, just
recently, I refactored it again so that it would work without changing 
any of the other database adapters.

    Can somebody take a look at this? I''m willing to make additional 
changes if necessary.

Thanks,
Steve

On 2006-08-01, at 08:36 , Steven Hammond wrote:
>    I submitted patch #4353 quite a while ago to allow the use of  
> bigint
> integer types in MySQL.
Also see:

http://dev.rubyonrails.org/ticket/5483
http://dev.rubyonrails.org/ticket/5484

It looks like #5489 is also related. Is there value in trying to pull 
all of this together into a single patch and a single ticket?

Thanks,
Steve

Caio Chassot wrote:
>
> On 2006-08-01, at 08:36 , Steven Hammond wrote:
>
>>    I submitted patch #4353 quite a while ago to allow the use of 
bigint
>> integer types in MySQL.
>
>
> Also see:
>
> http://dev.rubyonrails.org/ticket/5483
> http://dev.rubyonrails.org/ticket/5484
> _______________________________________________
> Rails-core mailing list
> Rails-core@lists.rubyonrails.org
> http://lists.rubyonrails.org/mailman/listinfo/rails-core
>

0
On 2006-08-01, at 17:06 , Steven Hammond wrote:
>
> It looks like #5489 is also related. Is there value in trying to  
> pull all of this together into a single patch and a single ticket?
I think it''s a good idea. If only to to pick the best patch, or best  
part of each.

I did such a ticket consolidation for http://dev.rubyonrails.org/ 
ticket/3904. I also went over all patches, and concluded mine was  
better ;)