Michael Schoen
2006-Jul-07 17:41 UTC
Rails AR/Oracle Unit Test: [4578] failed (but getting better)
"bitsweat" has given AR/Oracle some love, but it''s still unhappy... http://dev.rubyonrails.org/changeset/4578 ------------------------------------------------------------------------ r4578 | bitsweat | 2006-07-07 10:34:45 -0700 (Fri, 07 Jul 2006) | 1 line find_one uses find_every.first instead of find_initial since its primary key constraint obviates find_initial''s :limit => 1. References #5635. ------------------------------------------------------------------------ U activerecord/lib/active_record/base.rb Updated to revision 4578. 1) Failure: test_no_locks_no_wait(PessimisticLockingTest) [./test/locking_test.rb:114]: <false> is not true. 907 tests, 3187 assertions, 1 failures, 0 errors rake aborted! Command failed with status (1): [/usr/pkg/ruby184/bin/ruby -Ilib:test:test/...] (See full trace by running task with --trace)
Michael A. Schoen
2006-Jul-07 18:21 UTC
Re: Rails AR/Oracle Unit Test: [4578] failed (but getting better)
Michael Schoen wrote:> "bitsweat" has given AR/Oracle some love, but it''s still unhappy... > > http://dev.rubyonrails.org/changeset/4578Ugh. So the actual problem is fixed now (thanks), the test is failing because my db server is running a bit slow, and the 1s sleep in the locking tests wasn''t sufficient to get the right result. So, how do you want to handle? An increase to 5s should be plenty, and the extra wait won''t bother me. If the extra wait''s gonna drive you nuts, could make it wait longer just for the OracleAdapter, or allow an environment variable to be set to override the 1s wait.