The revised patch submitted on #4748 broke the build, I''m looking to sort out why. Also note that this auto-test email didn''t make it to rails-core because it was too big (every test failed, so the resulting email was huge). I''ll patch my auto-testing script to truncate the email to no larger than a few kb. Michael Schoen wrote:> "marcel" made AR/Oracle cry... > > http://dev.rubyonrails.org/changeset/4280 > ------------------------------------------------------------------------ > r4280 | marcel | 2006-04-26 13:43:29 -0700 (Wed, 26 Apr 2006) | 1 line > > Add Oracle support for CLOB inserts. Closes #4748. [schoenm@earthlink.net sandra.metz@duke.edu] > ------------------------------------------------------------------------ > > U activerecord/lib/active_record/connection_adapters/oracle_adapter.rb > U activerecord/CHANGELOG > Updated to revision 4280. >
On Wed, Apr 26, 2006 at 02:28:50PM -0700, Michael A. Schoen wrote:> The revised patch submitted on #4748 broke the build, I''m looking to > sort out why. > > Also note that this auto-test email didn''t make it to rails-core because > it was too big (every test failed, so the resulting email was huge). > I''ll patch my auto-testing script to truncate the email to no larger > than a few kb. > > Michael Schoen wrote: > >"marcel" made AR/Oracle cry... > > > >http://dev.rubyonrails.org/changeset/4280 > >------------------------------------------------------------------------ > >r4280 | marcel | 2006-04-26 13:43:29 -0700 (Wed, 26 Apr 2006) | 1 line > > > >Add Oracle support for CLOB inserts. Closes #4748. [schoenm@earthlink.net > >sandra.metz@duke.edu] > >------------------------------------------------------------------------ > > > >U activerecord/lib/active_record/connection_adapters/oracle_adapter.rb > >U activerecord/CHANGELOG > >Updated to revision 4280.Great. Thanks Michael. marcel -- Marcel Molina Jr. <marcel@vernix.org>
Fixed by applying this 1-line patch. I''ve also updated ticket #4748.
Index: lib/active_record/connection_adapters/oracle_adapter.rb
==================================================================---
lib/active_record/connection_adapters/oracle_adapter.rb
(revision 4281)
+++ lib/active_record/connection_adapters/oracle_adapter.rb (working
copy)
@@ -210,7 +210,7 @@
end
def quote(value, column = nil) #:nodoc:
- if column && column.sql_type =~ /LOB$/i
+ if column && [:text, :binary].include?(column.type)
%Q{empty_#{ column.sql_type rescue ''blob'' }()}
else
case value
Marcel Molina Jr. wrote:> On Wed, Apr 26, 2006 at 02:28:50PM -0700, Michael A. Schoen wrote:
>> The revised patch submitted on #4748 broke the build, I''m
looking to
>> sort out why.
>>
>> Also note that this auto-test email didn''t make it to
rails-core because
>> it was too big (every test failed, so the resulting email was huge).
>> I''ll patch my auto-testing script to truncate the email to no
larger
>> than a few kb.
>>
>> Michael Schoen wrote:
>>> "marcel" made AR/Oracle cry...
>>>
>>> http://dev.rubyonrails.org/changeset/4280
>>>
------------------------------------------------------------------------
>>> r4280 | marcel | 2006-04-26 13:43:29 -0700 (Wed, 26 Apr 2006) | 1
line
>>>
>>> Add Oracle support for CLOB inserts. Closes #4748.
[schoenm@earthlink.net
>>> sandra.metz@duke.edu]
>>>
------------------------------------------------------------------------
>>>
>>> U
activerecord/lib/active_record/connection_adapters/oracle_adapter.rb
>>> U activerecord/CHANGELOG
>>> Updated to revision 4280.
>
> Great. Thanks Michael.
>
> marcel
Marcel Molina Jr. wrote:> On Wed, Apr 26, 2006 at 02:51:17PM -0700, Michael A. Schoen wrote: >> Fixed by applying this 1-line patch. I''ve also updated ticket #4748. > > Applied. Thanks. > > marcelThanks! The auto-test should sent out it''s all-clear in another minute.
On Wed, Apr 26, 2006 at 02:51:17PM -0700, Michael A. Schoen wrote:> Fixed by applying this 1-line patch. I''ve also updated ticket #4748.Applied. Thanks. marcel -- Marcel Molina Jr. <marcel@vernix.org>