Francois Beausoleil
2006-Apr-14 05:32 UTC
Ticket #4732 - Prevent ActiveRecord from requiring Transaction::Simple if already loaded
http://dev.rubyonrails.org/ticket/4732 I'd like to push to get this included in core. I have often complained that Rails should not bundle Transaction::Simple: http://thread.gmane.org/gmane.comp.lang.ruby.rails/32629 http://thread.gmane.org/gmane.comp.lang.ruby.rails.core/916 This patch at least prevents warnings when Transaction::Simple is loaded a second time. Thanks ! -- François Beausoleil http://blog.teksol.info/ _______________________________________________ Rails-core mailing list Rails-core@lists.rubyonrails.org http://lists.rubyonrails.org/mailman/listinfo/rails-core
David Heinemeier Hansson
2006-Apr-17 15:53 UTC
Re: Ticket #4732 - Prevent ActiveRecord from requiring Transaction::Simple if already loaded
> This patch at least prevents warnings when Transaction::Simple is > loaded a second time.I wonder what breakage would ensue if the API of TS changes? In any case, this is probably fine as a lesser evil. Until 2.0 where TS is yanked out from core. -- David Heinemeier Hansson http://www.loudthinking.com -- Broadcasting Brain http://www.basecamphq.com -- Online project management http://www.backpackit.com -- Personal information manager http://www.rubyonrails.com -- Web-application framework