A docs cleanup right before the 1.1 release broke ActiveRecord for anyone that has Ruby-OCI8 installed, even if they''re not actually using it. There have been at least a dozen or so messages on the general rails list in the past few days about this problem, as it just completely breaks Rails. Can we get this patch applied, perhaps even an updated gem posted? http://dev.rubyonrails.org/ticket/4457
> A docs cleanup right before the 1.1 release broke ActiveRecord for > anyone that has Ruby-OCI8 installed, even if they''re not actually using it.I broke it. Applied the patch. We''ll probably do a 1.1.1 in a little week''s time. When we''ve had a chance to see what else shakes out of this upgrade. There''s a Prototype issue that definitely also presses to warrant a release. This is a good reason why it would be awesome to setup automated testing for all the db adapters. -- David Heinemeier Hansson http://www.loudthinking.com -- Broadcasting Brain http://www.basecamphq.com -- Online project management http://www.backpackit.com -- Personal information manager http://www.rubyonrails.com -- Web-application framework
David Heinemeier Hansson wrote:> This is a good reason why it would be awesome to setup automated > testing for all the db adapters.What do you have in mind? I could put something together to pull down edge rails every few hours, run `rake test_oracle` and email on failures. Though that wouldn''t have helped in this case, since the doc cleanup that broke it was done just before the 1.1 release.
> What do you have in mind? > > I could put something together to pull down edge rails every few hours, > run `rake test_oracle` and email on failures.I think that would be great. If we could make it low-noise enough, we could even just have it email this list. Or we could setup a rails-test list explicitly for the purpose of having reporters ping that.> Though that wouldn''t have helped in this case, since the doc cleanup > that broke it was done just before the 1.1 release.If I had known that an automated system existed, I would have waited for that. -- David Heinemeier Hansson http://www.loudthinking.com -- Broadcasting Brain http://www.basecamphq.com -- Online project management http://www.backpackit.com -- Personal information manager http://www.rubyonrails.com -- Web-application framework
David Heinemeier Hansson wrote:>>What do you have in mind? >> >>I could put something together to pull down edge rails every few hours, >>run `rake test_oracle` and email on failures. > > > I think that would be great. If we could make it low-noise enough, we > could even just have it email this list. Or we could setup a > rails-test list explicitly for the purpose of having reporters ping > that.You could have another list with a Reply-To this list and when the build breaks, additionally cc the committer that broke the build. Regards, Blair -- Blair Zajac, Ph.D. <blair@orcaware.com> Subversion training, consulting and support http://www.orcaware.com/svn/
> You could have another list with a Reply-To this list and when the build breaks, > additionally cc the committer that broke the build.I''d love to see that happen. Please Do Investigate. -- David Heinemeier Hansson http://www.loudthinking.com -- Broadcasting Brain http://www.basecamphq.com -- Online project management http://www.backpackit.com -- Personal information manager http://www.rubyonrails.com -- Web-application framework
Blair Zajac wrote:> You could have another list with a Reply-To this list and when the build > breaks, additionally cc the committer that broke the build.Seems like that might require running the test after each individual commit, in order to be certain which commit break the build.
mmmm....good stuff! http://en.wikipedia.org/wiki/Continuous_integration http://docs.codehaus.org/display/DAMAGECONTROL/Continuous+Integration+Server+Feature+Matrix -Steve On 3/31/06, Michael Schoen <schoenm@earthlink.net> wrote:> > Blair Zajac wrote: > > You could have another list with a Reply-To this list and when the build > > breaks, additionally cc the committer that broke the build. > > Seems like that might require running the test after each individual > commit, in order to be certain which commit break the build. > _______________________________________________ > Rails-core mailing list > Rails-core@lists.rubyonrails.org > http://lists.rubyonrails.org/mailman/listinfo/rails-core >_______________________________________________ Rails-core mailing list Rails-core@lists.rubyonrails.org http://lists.rubyonrails.org/mailman/listinfo/rails-core
Smells a bit like something that''s been cooking in the Rails Recipes kitchen. -Derrick Spell On Mar 31, 2006, at 3:10 PM, Steve Longdo wrote:> mmmm....good stuff! > > http://en.wikipedia.org/wiki/Continuous_integration > > http://docs.codehaus.org/display/DAMAGECONTROL/Continuous > +Integration+Server+Feature+Matrix > > -Steve > > On 3/31/06, Michael Schoen < schoenm@earthlink.net> wrote: > Blair Zajac wrote: > > You could have another list with a Reply-To this list and when > the build > > breaks, additionally cc the committer that broke the build. > > Seems like that might require running the test after each individual > commit, in order to be certain which commit break the build. > _______________________________________________ > Rails-core mailing list > Rails-core@lists.rubyonrails.org > http://lists.rubyonrails.org/mailman/listinfo/rails-core > > _______________________________________________ > Rails-core mailing list > Rails-core@lists.rubyonrails.org > http://lists.rubyonrails.org/mailman/listinfo/rails-core_______________________________________________ Rails-core mailing list Rails-core@lists.rubyonrails.org http://lists.rubyonrails.org/mailman/listinfo/rails-core
* Steve Longdo (steve.longdo@gmail.com) [060331 15:21]:> mmmm....good stuff! > > http://en.wikipedia.org/wiki/Continuous_integration > > http://docs.codehaus.org/display/DAMAGECONTROL/ > Continuous+Integration+Server+Feature+MatrixWe''ve found the simple continuous_builder plugin for rails to be quite sufficient for doing continuous integration with Rails. Rick -- http://www.rickbradley.com MUPRN: 177 | such a person. random email haiku | I''ll see you from the other | side of the courtroom.
David Heinemeier Hansson wrote:>> You could have another list with a Reply-To this list and when the build breaks, >> additionally cc the committer that broke the build. > > I''d love to see that happen. Please Do Investigate.I''m about set to automate the Oracle unit tests, but need to get the green light lit first. Just submitted a patch to clean up the few remaining issues... http://dev.rubyonrails.org/ticket/4573
> I''m about set to automate the Oracle unit tests, but need to get the > green light lit first. Just submitted a patch to clean up the few > remaining issues... > > http://dev.rubyonrails.org/ticket/4573Applied. -- David Heinemeier Hansson http://www.loudthinking.com -- Broadcasting Brain http://www.basecamphq.com -- Online project management http://www.backpackit.com -- Personal information manager http://www.rubyonrails.com -- Web-application framework
David Heinemeier Hansson wrote:>> I''m about set to automate the Oracle unit tests, but need to get the >> green light lit first. Just submitted a patch to clean up the few >> remaining issues... >> >> http://dev.rubyonrails.org/ticket/4573 > > Applied.Thanks. I expect to get some form of the automated testing done today, with alerts just going to me for right now until I confirm it''s working properly. My goal is to get it to test each specific revision, so it''ll know which checkin broke, and email the details to both me, and with permission, the person who checked in the change. For which I''d need a list of folks from core that are ok to receive such email. Make sense?
> Thanks. I expect to get some form of the automated testing done today, > with alerts just going to me for right now until I confirm it''s working > properly. My goal is to get it to test each specific revision, so it''ll > know which checkin broke, and email the details to both me, and with > permission, the person who checked in the change. For which I''d need a > list of folks from core that are ok to receive such email. > > Make sense?I think just emailing this list on breakage is good. Then anyone has a chance to help fix the bug. If it becomes too spammy, we''ll make a separate list for it. Thanks for doing this! Now someone working with MS SQL, DB2, and all the other non-oss adapters please follow suit ;) -- David Heinemeier Hansson http://www.loudthinking.com -- Broadcasting Brain http://www.basecamphq.com -- Online project management http://www.backpackit.com -- Personal information manager http://www.rubyonrails.com -- Web-application framework
David Heinemeier Hansson wrote:> I think just emailing this list on breakage is good. Then anyone has a > chance to help fix the bug. If it becomes too spammy, we''ll make a > separate list for it. > > Thanks for doing this! Now someone working with MS SQL, DB2, and all > the other non-oss adapters please follow suit ;)Ok, my automated process will go live shortly, just waiting for 1 more svn checkin to test the last boundary case. My process.. 1. Runs every 5 minutes, looks for more recent revisions, and tests them one at a time (to more easily identify the breaking revision). 2. Emails me and rails-core on breaks, along with the info on the changeset and the specific unit test failures. 3. On subsequent tests, if the failure is the same, it remains silent; if the failure gets worse (eg, more output from `rake test_oracle`) or better, it sends out another email. 4. When it''s green again, another note goes out. It''s not a real pretty script, but I''m happy to share it without any volunteers looking to do something similar for MS SQL, DB2, etc.