Changset 3772 http://dev.rubyonrails.org/changeset/3772 breaks the support for RJS Helper methods which were added in 3470 http://dev.rubyonrails.org/changeset/3470. Offending code from the JavaScriptGenerator in prototype_helper.rb: def initialize(context, &block) #:nodoc: @context, @lines = context, [] # removed because those methods were overriding valid generator methods # include_helpers_from_context @context.instance_exec(self, &block) end Does this mean that the support for RJS Helper methods is being dropped, or is this breakage just temporary? The actual method include_helpers_from_context was left in the code, so it is hard to tell what is going on. Thanks -- Cody Fauser http://www.codyfauser.com
On 3/7/06, Cody Fauser <codyfauser@gmail.com> wrote:> Changset 3772 http://dev.rubyonrails.org/changeset/3772 breaks the > support for RJS Helper methods which were added in 3470 > http://dev.rubyonrails.org/changeset/3470. > > Offending code from the JavaScriptGenerator in prototype_helper.rb: > > def initialize(context, &block) #:nodoc: > @context, @lines = context, [] > # removed because those methods were overriding valid generator methods > # include_helpers_from_context > @context.instance_exec(self, &block) > end > > Does this mean that the support for RJS Helper methods is being > dropped, or is this breakage just temporary? The actual method > include_helpers_from_context was left in the code, so it is hard to > tell what is going on. > > ThanksThe problem was the generator needed special versions of some of the methods that the helpers were overriding. I was getting some very strange results withe enum proxy code. All the tests pass :) Let me know what methods are missing and I''ll put them back in somehow. If I have to, I''ll remove the special helper methods to a mixin that''s included after the helpers are loaded. -- Rick Olson http://techno-weenie.net
On 3/7/06, Cody Fauser <codyfauser@gmail.com> wrote:> Changset 3772 http://dev.rubyonrails.org/changeset/3772 breaks the > support for RJS Helper methods which were added in 3470 > http://dev.rubyonrails.org/changeset/3470.Doh, the changeset has a use case. I''ll take care of it. -- Rick Olson http://techno-weenie.net
Thanks Rick. On 3/7/06, Rick Olson <technoweenie@gmail.com> wrote:> On 3/7/06, Cody Fauser <codyfauser@gmail.com> wrote: > > Changset 3772 http://dev.rubyonrails.org/changeset/3772 breaks the > > support for RJS Helper methods which were added in 3470 > > http://dev.rubyonrails.org/changeset/3470. > > Doh, the changeset has a use case. I''ll take care of it. > > -- > Rick Olson > http://techno-weenie.net > _______________________________________________ > Rails-core mailing list > Rails-core@lists.rubyonrails.org > http://lists.rubyonrails.org/mailman/listinfo/rails-core >-- Cody Fauser http://www.codyfauser.com