Rails core - Feb 2006 - Quoting table and column names inside AR

There are quite a few tickets asking for quoted table names and field names
to enable reserved words as table or column names.

What is the general consensus regarding this issue? 

 

 

Bob Silva

http://www.railtie.net/

 



_______________________________________________
Rails-core mailing list
Rails-core@lists.rubyonrails.org
http://lists.rubyonrails.org/mailman/listinfo/rails-core

On 2/10/06, Bob Silva <me@bobsilva.com> wrote:
>
> There are quite a few tickets asking for quoted table names and field names
> to enable reserved words as table or column names.
>
> What is the general consensus regarding this issue?
>
Is there a downside, other than the effort of making the changes?
I''ve had the lack of quoting cause me to change column names in the
past, so I wouldn''t mind assisting.

I''ve learned to just not use reserved names in my models, but since the
databases allow quoting of names to get around this limitation, I don''t
see
why Rails shouldn''t allow for it as well. The question is in
implementation.
I would think an AR configuration variable would be best since there is a
small performance penalty involved with it. Those that need to support
legacy databases or choose to use reserved names can take the hit and leave
the others unaffected. Before I invest any time into it, I would like to
know what the core members thoughts on it are.

While you''re giving thought to that, what are your thoughts on renaming
the
quote method inside of AR:B? Quite a few tickets come through for that as
well.


Bob Silva
http://www.railtie.net/
> -----Original Message-----
> From: rails-core-bounces@lists.rubyonrails.org [mailto:rails-core-
> bounces@lists.rubyonrails.org] On Behalf Of Wilson Bilkovich
> Sent: Friday, February 10, 2006 2:11 PM
> To: rails-core@lists.rubyonrails.org
> Subject: Re: [Rails-core] Quoting table and column names inside AR
> 
> On 2/10/06, Bob Silva <me@bobsilva.com> wrote:
> >
> > There are quite a few tickets asking for quoted table names and field
> names
> > to enable reserved words as table or column names.
> >
> > What is the general consensus regarding this issue?
> >
> 
> Is there a downside, other than the effort of making the changes?
> I''ve had the lack of quoting cause me to change column names in
the
> past, so I wouldn''t mind assisting.
> _______________________________________________
> Rails-core mailing list
> Rails-core@lists.rubyonrails.org
> http://lists.rubyonrails.org/mailman/listinfo/rails-core

> While you''re giving thought to that, what are your thoughts on
renaming the
> quote method inside of AR:B? Quite a few tickets come through for that as
> well.
Unfortunately we have a lot of people calling the quote method from
plugins, custom code etc.  We can''t rename it without breaking
backwards compatibility, which means we can''t do it until 2.0.

One option would be to mark it as deprecated in the docs and create a
method with the new name.


--
Cheers

Koz