I wanted to introduce a small team of SQLServer adapter tweeners to
the list. Tom Ward, Todd Hickerson, and myself have been discussing
different ways we can improve the adapter. I''d like to move that
discussion to the rails-core mailing list as 1.) I don''t like doing
things in private unless there''s some privacy concern, 2.) so we have
the discussion archived and 3.) so that others can participate.
Most of our discussion has been related to organizing a system of
testing that would allow us to:
1. test the various configurations (unixODBC / ADO) on a regular
schedule. (formal releases at minimum; weekly, nightly, continuously
if we''re lucky)
2. provide test results somewhere for the core team. (e.g. via RSS, mail, etc)
Much of this discussion is not limited to the SQL Server adapter and
could be useful to all non-F/OSS adapter maintainers.
For now, I''m content to do manual testing and report results to the
mailing list after formal releases.
With RC4, the SQLServer adapter running on Fedora Core 4 using
FreeTDS/ODBC is erroring on 1 test:
1) Error:
test_extension_on_has_many(AssociationsExtensionsTest):
ActiveRecord::StatementInvalid: (420) [unixODBC][FreeTDS][SQL
Server]The text, ntext, and image data types cannot be used in an
ORDER BY clause.: SELECT TOP 1 * FROM comments WHERE (comments.post_id
= 1) ORDER BY id DESC, body
./../lib/active_record/connection_adapters/abstract_adapter.rb:67:in
`log''
./../lib/active_record/connection_adapters/sqlserver_adapter.rb:430:in
`select''
./../lib/active_record/connection_adapters/sqlserver_adapter.rb:198:in
`select_all''
./../lib/active_record/base.rb:447:in `find_by_sql''
./../lib/active_record/base.rb:411:in `find''
./../lib/active_record/base.rb:409:in `find''
./../lib/active_record/associations/has_many_association.rb:83:in
`find''
./fixtures/post.rb:12:in `find_most_recent''
./associations_extensions_test.rb:11:in
`test_extension_on_has_many''
639 tests, 2093 assertions, 0 failures, 1 errors
This is better than I expected - 5 tests were failing two days ago.
Additionally, ticket #2770 (http://dev.rubyonrails.com/ticket/2770)
seems to be related to this failure and proposes a fix.
Tom, Todd: can you guys run the tests on your configurations and
report back on this thread?
Thanks,
Ryan Tomayko
rtomayko@gmail.com
http://naeblis.cx/rtomayko/
http://lesscode.org/
On 11/8/05, Ryan Tomayko <rtomayko@gmail.com> wrote:> With RC4, the SQLServer adapter running on Fedora Core 4 using > FreeTDS/ODBC is erroring on 1 test: > > 1) Error: > test_extension_on_has_many(AssociationsExtensionsTest): > ActiveRecord::StatementInvalid: (420) [unixODBC][FreeTDS][SQL > Server]The text, ntext, and image data types cannot be used in an > ORDER BY clause.: SELECT TOP 1 * FROM comments WHERE (comments.post_id > = 1) ORDER BY id DESC, bodyThe test fails on my machine, but then I think it would on any (as it''s a SQL issue, rather than a connection one). The body column in the comments table is type text, but SQL Server doesn''t allow text columns in order by clauses. The quick solution would be to change the column type to something else. Any thoughts? Will this cause problems in other tests?> Additionally, ticket #2770 (http://dev.rubyonrails.com/ticket/2770) > seems to be related to this failure and proposes a fix.I think #2770 is unrelated, but certainly a problem. I can create a patch with a test and the supplied fix, but probably not until tomorrow. Tom
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Nov 8, 2005, at 6:29 AM, Ryan Tomayko wrote:> I wanted to introduce a small team of SQLServer adapter tweeners to > the list. Tom Ward, Todd Hickerson, and myself have been discussing > different ways we can improve the adapter. I''d like to move that > discussion to the rails-core mailing list as 1.) I don''t like doing > things in private unless there''s some privacy concern, 2.) so we have > the discussion archived and 3.) so that others can participate.Welcome to the list, all.> Most of our discussion has been related to organizing a system of > testing that would allow us to: > > 1. test the various configurations (unixODBC / ADO) on a regular > schedule. (formal releases at minimum; weekly, nightly, continuously > if we''re lucky) > > 2. provide test results somewhere for the core team. (e.g. via RSS, > mail, etc) > > Much of this discussion is not limited to the SQL Server adapter and > could be useful to all non-F/OSS adapter maintainers.Definitely. I test SQLite, MySQL, and PostgreSQL frequently, but don''t have SQLServer, DB2, OCI, Firebird, etc. set up. Continuous smoke tests against any of these databases would be helpful and very welcome. I think your stewardship is far more valuable, however. Thanks for taking the reins! jeremy -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (Darwin) iD8DBQFDcQS+AQHALep9HFYRApQvAJ9LcdiM07XOSHzD5KOpGbFO84gwxgCeKOg4 Fl+wU16RfGZfyAlj/rbMQqs=qxfR -----END PGP SIGNATURE-----