I note that you have "Year-month" (capital 'Y') and "year-month" in your code; case matters in R. Otherwise, Rolf's advice applies. Cheers, Bert Bert Gunter "The trouble with having an open mind is that people keep coming along and sticking things into it." -- Opus (aka Berkeley Breathed in his "Bloom County" comic strip ) On Mon, Feb 27, 2017 at 6:16 PM, Rolf Turner <r.turner at auckland.ac.nz> wrote:> On 28/02/17 14:47, Val wrote: >> >> Currently I have about six or more scripts that do the same job. I >> thought it might be possible and more efficient to use one script by using >> IF ELSE statements. Here is an example but this will be expandable for >> several countries ans year-months >> >> >> Year-month = FEB2015, FEB2012, Feb2010 >> country = USA, CAN.MEX >> First I want to do if country = USA and year-month = FEB2015, FEB2012 do >> the statements >> second if country = CAN and year-month =Feb2010 do the statements >> >> >> if(country="USA" & year-month = "FEB2015" | "FEB2012" ){ >> statemnt1 >> . >> statemnt10 >> >> } else if (country="USA" & year-month ="FEB2015") { >> statemnt1 >> . >> statemnt10 >> } >> >> else >> { >> statemnt1 >> . >> statemnt10 >> } >> >> The above script did not work. is there a different ways of doing it? > > > Uh, yes. Get the syntax right. Use R, when you are using R. > > Looking at ?Syntax and ?Logic might help you a bit. > > Other than that, there's not much that one can say without seeing a > reproducible example. And if you sat down and wrote out a *reproducible > example*, using correct R syntax, you probably wouldn't need any assistance > from R-help. > > Have you read any of the readily available R tutorials? If not do so. If > so, read them again and actually take note of what they say! > > cheers, > > Rolf Turner > > -- > Technical Editor ANZJS > Department of Statistics > University of Auckland > Phone: +64-9-373-7599 ext. 88276 > > > ______________________________________________ > R-help at r-project.org mailing list -- To UNSUBSCRIBE and more, see > https://stat.ethz.ch/mailman/listinfo/r-help > PLEASE do read the posting guide http://www.R-project.org/posting-guide.html > and provide commented, minimal, self-contained, reproducible code.
Thank you Rolf and Bert! I found the problem and this if(country="USA" & year-month = "FEB2015" | "FEB2012" ){ has be changed to this if(country="USA" & year-month == "FEB2015" | year-month == "FEB2012" ){ On Mon, Feb 27, 2017 at 8:45 PM, Bert Gunter <bgunter.4567 at gmail.com> wrote:> I note that you have "Year-month" (capital 'Y') and "year-month" in > your code; case matters in R. > > Otherwise, Rolf's advice applies. > > Cheers, > Bert > > Bert Gunter > > "The trouble with having an open mind is that people keep coming along > and sticking things into it." > -- Opus (aka Berkeley Breathed in his "Bloom County" comic strip ) > > > On Mon, Feb 27, 2017 at 6:16 PM, Rolf Turner <r.turner at auckland.ac.nz> > wrote: > > On 28/02/17 14:47, Val wrote: > >> > >> Currently I have about six or more scripts that do the same job. I > >> thought it might be possible and more efficient to use one script by > using > >> IF ELSE statements. Here is an example but this will be expandable for > >> several countries ans year-months > >> > >> > >> Year-month = FEB2015, FEB2012, Feb2010 > >> country = USA, CAN.MEX > >> First I want to do if country = USA and year-month = FEB2015, FEB2012 do > >> the statements > >> second if country = CAN and year-month =Feb2010 do the statements > >> > >> > >> if(country="USA" & year-month = "FEB2015" | "FEB2012" ){ > >> statemnt1 > >> . > >> statemnt10 > >> > >> } else if (country="USA" & year-month ="FEB2015") { > >> statemnt1 > >> . > >> statemnt10 > >> } > >> > >> else > >> { > >> statemnt1 > >> . > >> statemnt10 > >> } > >> > >> The above script did not work. is there a different ways of doing it? > > > > > > Uh, yes. Get the syntax right. Use R, when you are using R. > > > > Looking at ?Syntax and ?Logic might help you a bit. > > > > Other than that, there's not much that one can say without seeing a > > reproducible example. And if you sat down and wrote out a *reproducible > > example*, using correct R syntax, you probably wouldn't need any > assistance > > from R-help. > > > > Have you read any of the readily available R tutorials? If not do so. If > > so, read them again and actually take note of what they say! > > > > cheers, > > > > Rolf Turner > > > > -- > > Technical Editor ANZJS > > Department of Statistics > > University of Auckland > > Phone: +64-9-373-7599 ext. 88276 > > > > > > ______________________________________________ > > R-help at r-project.org mailing list -- To UNSUBSCRIBE and more, see > > https://stat.ethz.ch/mailman/listinfo/r-help > > PLEASE do read the posting guide http://www.R-project.org/ > posting-guide.html > > and provide commented, minimal, self-contained, reproducible code. >[[alternative HTML version deleted]]
Really? That seems unlikely, given that * = is used for moving values, not comparing them, * - is not a legal symbol for a variable name, it is subtraction, and year-month can hardly end up as a character string like "FEB2015" * (possible problem) & and | compare vectors one at a time, so are not generally recommended for use in "if", but are more commonly used in the "ifelse" function. These points are all discussed in the Introduction to R document that comes with R. -- Sent from my phone. Please excuse my brevity. On February 27, 2017 7:02:29 PM PST, Val <valkremk at gmail.com> wrote:>Thank you Rolf and Bert! > >I found the problem and this > >if(country="USA" & year-month = "FEB2015" | "FEB2012" ){ > has be changed to this >if(country="USA" & year-month == "FEB2015" | year-month == "FEB2012" ){ > >On Mon, Feb 27, 2017 at 8:45 PM, Bert Gunter <bgunter.4567 at gmail.com> >wrote: > >> I note that you have "Year-month" (capital 'Y') and "year-month" in >> your code; case matters in R. >> >> Otherwise, Rolf's advice applies. >> >> Cheers, >> Bert >> >> Bert Gunter >> >> "The trouble with having an open mind is that people keep coming >along >> and sticking things into it." >> -- Opus (aka Berkeley Breathed in his "Bloom County" comic strip ) >> >> >> On Mon, Feb 27, 2017 at 6:16 PM, Rolf Turner ><r.turner at auckland.ac.nz> >> wrote: >> > On 28/02/17 14:47, Val wrote: >> >> >> >> Currently I have about six or more scripts that do the same >job. I >> >> thought it might be possible and more efficient to use one script >by >> using >> >> IF ELSE statements. Here is an example but this will be expandable >for >> >> several countries ans year-months >> >> >> >> >> >> Year-month = FEB2015, FEB2012, Feb2010 >> >> country = USA, CAN.MEX >> >> First I want to do if country = USA and year-month = FEB2015, >FEB2012 do >> >> the statements >> >> second if country = CAN and year-month =Feb2010 do the statements >> >> >> >> >> >> if(country="USA" & year-month = "FEB2015" | "FEB2012" ){ >> >> statemnt1 >> >> . >> >> statemnt10 >> >> >> >> } else if (country="USA" & year-month ="FEB2015") { >> >> statemnt1 >> >> . >> >> statemnt10 >> >> } >> >> >> >> else >> >> { >> >> statemnt1 >> >> . >> >> statemnt10 >> >> } >> >> >> >> The above script did not work. is there a different ways of doing >it? >> > >> > >> > Uh, yes. Get the syntax right. Use R, when you are using R. >> > >> > Looking at ?Syntax and ?Logic might help you a bit. >> > >> > Other than that, there's not much that one can say without seeing a >> > reproducible example. And if you sat down and wrote out a >*reproducible >> > example*, using correct R syntax, you probably wouldn't need any >> assistance >> > from R-help. >> > >> > Have you read any of the readily available R tutorials? If not do >so. If >> > so, read them again and actually take note of what they say! >> > >> > cheers, >> > >> > Rolf Turner >> > >> > -- >> > Technical Editor ANZJS >> > Department of Statistics >> > University of Auckland >> > Phone: +64-9-373-7599 ext. 88276 >> > >> > >> > ______________________________________________ >> > R-help at r-project.org mailing list -- To UNSUBSCRIBE and more, see >> > https://stat.ethz.ch/mailman/listinfo/r-help >> > PLEASE do read the posting guide http://www.R-project.org/ >> posting-guide.html >> > and provide commented, minimal, self-contained, reproducible code. >> > > [[alternative HTML version deleted]] > >______________________________________________ >R-help at r-project.org mailing list -- To UNSUBSCRIBE and more, see >https://stat.ethz.ch/mailman/listinfo/r-help >PLEASE do read the posting guide >http://www.R-project.org/posting-guide.html >and provide commented, minimal, self-contained, reproducible code.