On 27 Mar 2015, at 09:58 , St?phane Adamowicz <stephane.adamowicz at avignon.inra.fr> wrote:> data_no_NA <- data[, complete.cases(t(data))==T]Ouch! logical == TRUE is bad, logical == T is worse: data[, complete.cases(t(data))] -- Peter Dalgaard, Professor, Center for Statistics, Copenhagen Business School Solbjerg Plads 3, 2000 Frederiksberg, Denmark Phone: (+45)38153501 Office: A 4.23 Email: pd.mes at cbs.dk Priv: PDalgd at gmail.com
Well, it seems to work with me. Y <- as.matrix(airquality) head(Y, n=8) Ozone Solar.R Wind Temp Month Day [1,] 41 190 7.4 67 5 1 [2,] 36 118 8.0 72 5 2 [3,] 12 149 12.6 74 5 3 [4,] 18 313 11.5 62 5 4 [5,] NA NA 14.3 56 5 5 [6,] 28 NA 14.9 66 5 6 [7,] 23 299 8.6 65 5 7 [8,] 19 99 13.8 59 5 8 Z <- Y[,complete.cases(t(Y))==T] head(Z, n=8) Wind Temp Month Day [1,] 7.4 67 5 1 [2,] 8.0 72 5 2 [3,] 12.6 74 5 3 [4,] 11.5 62 5 4 [5,] 14.3 56 5 5 [6,] 14.9 66 5 6 [7,] 8.6 65 5 7 [8,] 13.8 59 5 8 The columns that contained NA were deleted. Le 27 mars 2015 ? 10:38, peter dalgaard <pdalgd at gmail.com> a ?crit :> > On 27 Mar 2015, at 09:58 , St?phane Adamowicz <stephane.adamowicz at avignon.inra.fr> wrote: > >> data_no_NA <- data[, complete.cases(t(data))==T] > > Ouch! logical == TRUE is bad, logical == T is worse: > > data[, complete.cases(t(data))] > > > -- > Peter Dalgaard, Professor, > Center for Statistics, Copenhagen Business School > Solbjerg Plads 3, 2000 Frederiksberg, Denmark > Phone: (+45)38153501 > Office: A 4.23 > Email: pd.mes at cbs.dk Priv: PDalgd at gmail.com > > > > > > > > >_________________________________ St?phane Adamowicz Inra, centre de recherche Paca, unit? PSH 228, route de l'a?rodrome CS 40509 domaine St Paul, site Agroparc 84914 Avignon, cedex 9 France stephane.adamowicz at avignon.inra.fr tel. +33 (0)4 32 72 24 35 fax. +33 (0)4 32 72 24 32 do not dial 0 when out of France web PSH : https://www6.paca.inra.fr/psh web Inra : http://www.inra.fr/ _________________________________ [[alternative HTML version deleted]]
Very, very, very bad solution. as.matrix can change silently your data to unwanted format, complete.cases()==T is silly as Peter already pointed out. I use head(airquality[ ,colSums(is.na(airquality))==0]) Wind Temp Month Day 1 7.4 67 5 1 2 8.0 72 5 2 3 12.6 74 5 3 4 11.5 62 5 4 5 14.3 56 5 5 6 14.9 66 5 6 if I want to get rid of columns with NA. Cheers Petr From: R-help [mailto:r-help-bounces at r-project.org] On Behalf Of St?phane Adamowicz Sent: Friday, March 27, 2015 11:42 AM To: peter dalgaard Cc: r-help at r-project.org Subject: Re: [R] matrix manipulation question Well, it seems to work with me. Y <- as.matrix(airquality) head(Y, n=8) Ozone Solar.R Wind Temp Month Day [1,] 41 190 7.4 67 5 1 [2,] 36 118 8.0 72 5 2 [3,] 12 149 12.6 74 5 3 [4,] 18 313 11.5 62 5 4 [5,] NA NA 14.3 56 5 5 [6,] 28 NA 14.9 66 5 6 [7,] 23 299 8.6 65 5 7 [8,] 19 99 13.8 59 5 8 Z <- Y[,complete.cases(t(Y))==T] head(Z, n=8) Wind Temp Month Day [1,] 7.4 67 5 1 [2,] 8.0 72 5 2 [3,] 12.6 74 5 3 [4,] 11.5 62 5 4 [5,] 14.3 56 5 5 [6,] 14.9 66 5 6 [7,] 8.6 65 5 7 [8,] 13.8 59 5 8 The columns that contained NA were deleted. Le 27 mars 2015 ? 10:38, peter dalgaard <pdalgd at gmail.com<mailto:pdalgd at gmail.com>> a ?crit :> > On 27 Mar 2015, at 09:58 , St?phane Adamowicz <stephane.adamowicz at avignon.inra.fr<mailto:stephane.adamowicz at avignon.inra.fr>> wrote: > >> data_no_NA <- data[, complete.cases(t(data))==T] > > Ouch! logical == TRUE is bad, logical == T is worse: > > data[, complete.cases(t(data))] > > > -- > Peter Dalgaard, Professor, > Center for Statistics, Copenhagen Business School > Solbjerg Plads 3, 2000 Frederiksberg, Denmark > Phone: (+45)38153501 > Office: A 4.23 > Email: pd.mes at cbs.dk<mailto:pd.mes at cbs.dk> Priv: PDalgd at gmail.com<mailto:PDalgd at gmail.com> > > > > > > > > >_________________________________ St?phane Adamowicz Inra, centre de recherche Paca, unit? PSH 228, route de l'a?rodrome CS 40509 domaine St Paul, site Agroparc 84914 Avignon, cedex 9 France stephane.adamowicz at avignon.inra.fr<mailto:stephane.adamowicz at avignon.inra.fr> tel. +33 (0)4 32 72 24 35 fax. +33 (0)4 32 72 24 32 do not dial 0 when out of France web PSH : https://www6.paca.inra.fr/psh web Inra : http://www.inra.fr/ _________________________________ [[alternative HTML version deleted]] ______________________________________________ R-help at r-project.org<mailto:R-help at r-project.org> mailing list -- To UNSUBSCRIBE and more, see https://stat.ethz.ch/mailman/listinfo/r-help PLEASE do read the posting guide http://www.R-project.org/posting-guide.html and provide commented, minimal, self-contained, reproducible code. ________________________________ Tento e-mail a jak?koliv k n?mu p?ipojen? dokumenty jsou d?v?rn? a jsou ur?eny pouze jeho adres?t?m. Jestli?e jste obdr?el(a) tento e-mail omylem, informujte laskav? neprodlen? jeho odes?latele. Obsah tohoto emailu i s p??lohami a jeho kopie vyma?te ze sv?ho syst?mu. Nejste-li zam??len?m adres?tem tohoto emailu, nejste opr?vn?ni tento email jakkoliv u??vat, roz?i?ovat, kop?rovat ?i zve?ej?ovat. Odes?latel e-mailu neodpov?d? za eventu?ln? ?kodu zp?sobenou modifikacemi ?i zpo?d?n?m p?enosu e-mailu. V p??pad?, ?e je tento e-mail sou??st? obchodn?ho jedn?n?: - vyhrazuje si odes?latel pr?vo ukon?it kdykoliv jedn?n? o uzav?en? smlouvy, a to z jak?hokoliv d?vodu i bez uveden? d?vodu. - a obsahuje-li nab?dku, je adres?t opr?vn?n nab?dku bezodkladn? p?ijmout; Odes?latel tohoto e-mailu (nab?dky) vylu?uje p?ijet? nab?dky ze strany p??jemce s dodatkem ?i odchylkou. - trv? odes?latel na tom, ?e p??slu?n? smlouva je uzav?ena teprve v?slovn?m dosa?en?m shody na v?ech jej?ch n?le?itostech. - odes?latel tohoto emailu informuje, ?e nen? opr?vn?n uzav?rat za spole?nost ??dn? smlouvy s v?jimkou p??pad?, kdy k tomu byl p?semn? zmocn?n nebo p?semn? pov??en a takov? pov??en? nebo pln? moc byly adres?tovi tohoto emailu p??padn? osob?, kterou adres?t zastupuje, p?edlo?eny nebo jejich existence je adres?tovi ?i osob? j?m zastoupen? zn?m?. This e-mail and any documents attached to it may be confidential and are intended only for its intended recipients. If you received this e-mail by mistake, please immediately inform its sender. Delete the contents of this e-mail with all attachments and its copies from your system. If you are not the intended recipient of this e-mail, you are not authorized to use, disseminate, copy or disclose this e-mail in any manner. The sender of this e-mail shall not be liable for any possible damage caused by modifications of the e-mail or by delay with transfer of the email. In case that this e-mail forms part of business dealings: - the sender reserves the right to end negotiations about entering into a contract in any time, for any reason, and without stating any reasoning. - if the e-mail contains an offer, the recipient is entitled to immediately accept such offer; The sender of this e-mail (offer) excludes any acceptance of the offer on the part of the recipient containing any amendment or variation. - the sender insists on that the respective contract is concluded only upon an express mutual agreement on all its aspects. - the sender of this e-mail informs that he/she is not authorized to enter into any contracts on behalf of the company except for cases in which he/she is expressly authorized to do so in writing, and such authorization or power of attorney is submitted to the recipient or the person represented by the recipient, or the existence of such authorization is known to the recipient of the person represented by the recipient. [[alternative HTML version deleted]]
On 2015-03-27 11:41, St?phane Adamowicz wrote:> Well, it seems to work with me. > > Y <- as.matrix(airquality) > head(Y, n=8) > Ozone Solar.R Wind Temp Month Day > [1,] 41 190 7.4 67 5 1 > [2,] 36 118 8.0 72 5 2 > [3,] 12 149 12.6 74 5 3 > [4,] 18 313 11.5 62 5 4 > [5,] NA NA 14.3 56 5 5 > [6,] 28 NA 14.9 66 5 6 > [7,] 23 299 8.6 65 5 7 > [8,] 19 99 13.8 59 5 8 > > Z <- Y[,complete.cases(t(Y))==T]Peter's point, I guess, is that 1. complete.cases(t(Y)) is already a vector of logicals 2. T (and F) can be redefined, so what if T <- FALSE? Henric Winell> > head(Z, n=8) > Wind Temp Month Day > [1,] 7.4 67 5 1 > [2,] 8.0 72 5 2 > [3,] 12.6 74 5 3 > [4,] 11.5 62 5 4 > [5,] 14.3 56 5 5 > [6,] 14.9 66 5 6 > [7,] 8.6 65 5 7 > [8,] 13.8 59 5 8 > > The columns that contained NA were deleted. > > > Le 27 mars 2015 ? 10:38, peter dalgaard <pdalgd at gmail.com> a ?crit : > >> >> On 27 Mar 2015, at 09:58 , St?phane Adamowicz <stephane.adamowicz at avignon.inra.fr> wrote: >> >>> data_no_NA <- data[, complete.cases(t(data))==T] >> >> Ouch! logical == TRUE is bad, logical == T is worse: >> >> data[, complete.cases(t(data))] >> >> >> -- >> Peter Dalgaard, Professor, >> Center for Statistics, Copenhagen Business School >> Solbjerg Plads 3, 2000 Frederiksberg, Denmark >> Phone: (+45)38153501 >> Office: A 4.23 >> Email: pd.mes at cbs.dk Priv: PDalgd at gmail.com >> >> >> >> >> >> >> >> >> > > > > _________________________________ > St?phane Adamowicz > Inra, centre de recherche Paca, unit? PSH > 228, route de l'a?rodrome > CS 40509 > domaine St Paul, site Agroparc > 84914 Avignon, cedex 9 > France > > stephane.adamowicz at avignon.inra.fr > tel. +33 (0)4 32 72 24 35 > fax. +33 (0)4 32 72 24 32 > do not dial 0 when out of France > web PSH : https://www6.paca.inra.fr/psh > web Inra : http://www.inra.fr/ > _________________________________ > > > [[alternative HTML version deleted]] > > > > ______________________________________________ > R-help at r-project.org mailing list -- To UNSUBSCRIBE and more, see > https://stat.ethz.ch/mailman/listinfo/r-help > PLEASE do read the posting guide http://www.R-project.org/posting-guide.html > and provide commented, minimal, self-contained, reproducible code. >
On Mar 27, 2015, at 3:41 AM, St?phane Adamowicz wrote:> Well, it seems to work with me. >No one is doubting that it worked for you in this instance. What Peter D. was criticizing was the construction : complete.cases(t(Y))==T ... and it was on two bases that it is "wrong". The first is that `T` is not guaranteed to be TRUE. The second is that the test ==T (or similarly ==TRUE) is completely unnecessary because `complete.cases` returns a logical vector and so that expression is a waste of time. (The issue of matrix versus dataframe was raised by someone else.) -- David.> Y <- as.matrix(airquality) > head(Y, n=8) > Ozone Solar.R Wind Temp Month Day > [1,] 41 190 7.4 67 5 1 > [2,] 36 118 8.0 72 5 2 > [3,] 12 149 12.6 74 5 3 > [4,] 18 313 11.5 62 5 4 > [5,] NA NA 14.3 56 5 5 > [6,] 28 NA 14.9 66 5 6 > [7,] 23 299 8.6 65 5 7 > [8,] 19 99 13.8 59 5 8 > > Z <- Y[,complete.cases(t(Y))==T] > > head(Z, n=8) > Wind Temp Month Day > [1,] 7.4 67 5 1 > [2,] 8.0 72 5 2 > [3,] 12.6 74 5 3 > [4,] 11.5 62 5 4 > [5,] 14.3 56 5 5 > [6,] 14.9 66 5 6 > [7,] 8.6 65 5 7 > [8,] 13.8 59 5 8 > > The columns that contained NA were deleted. > > > Le 27 mars 2015 ? 10:38, peter dalgaard <pdalgd at gmail.com> a ?crit : > >> >> On 27 Mar 2015, at 09:58 , St?phane Adamowicz <stephane.adamowicz at avignon.inra.fr> wrote: >> >>> data_no_NA <- data[, complete.cases(t(data))==T] >> >> Ouch! logical == TRUE is bad, logical == T is worse: >> >> data[, complete.cases(t(data))] >> >> >> -- >> Peter Dalgaard, Professor, >> Center for Statistics, Copenhagen Business School >> Solbjerg Plads 3, 2000 Frederiksberg, Denmark >> Phone: (+45)38153501 >> Office: A 4.23 >> Email: pd.mes at cbs.dk Priv: PDalgd at gmail.com >> >> >> >> >> >> >> >> >> > > > > _________________________________ > St?phane Adamowicz > Inra, centre de recherche Paca, unit? PSH > 228, route de l'a?rodrome > CS 40509 > domaine St Paul, site Agroparc > 84914 Avignon, cedex 9 > France > > stephane.adamowicz at avignon.inra.fr > tel. +33 (0)4 32 72 24 35 > fax. +33 (0)4 32 72 24 32 > do not dial 0 when out of France > web PSH : https://www6.paca.inra.fr/psh > web Inra : http://www.inra.fr/ > _________________________________ > > > [[alternative HTML version deleted]] > > ______________________________________________ > R-help at r-project.org mailing list -- To UNSUBSCRIBE and more, see > https://stat.ethz.ch/mailman/listinfo/r-help > PLEASE do read the posting guide http://www.R-project.org/posting-guide.html > and provide commented, minimal, self-contained, reproducible code.David Winsemius Alameda, CA, USA