Suharto Anggono Suharto Anggono
2025-Apr-16 08:00 UTC
[Rd] Inappropriate modifications to R C source related to bool
src/main/attrib.c
r87863
'TRUE'?is?not?replaced?with?'true'?in?functions?'row_names_gets',?'isOneDimensionalArray',?'getAttrib0',?'copyMostAttribNoTs',?'classgets',?'R_data_class2'.
But?it?works?fine.
src/main/main.c
r87863
'FALSE'?is?not?replaced?with?'false'?in
????bool?wasDisplayed?=?FALSE;
in?functions?'Rf_ReplIteration',?'R_ReplDLLdo1'.
'TRUE'?is?not?replaced?with?'true'?and?'FALSE'?is?not?replaced?with?'false'?in?function?'check_session_exit'.
But?it?works?fine.
src/library/grid/src/grid.c
r87924
The?comment?before?function?'findInChildren'?and?before?function?'findViewport'?are?R?code.?There,?'FALSE'?should?not?be?replaced?with?'false'?and?'TRUE'?should?not?be?replaced?with?'true'.
But?it?has?no?effect.
src/library/grDevices/src/devPicTeX.c
r87953
'FALSE'?is?not?replaced?with?'false'?in
????if?(!(ptd?=?(picTeXDesc?*)?malloc(sizeof(picTeXDesc))))
return?FALSE;
and 'TRUE' is not replaced with 'true' in
return TRUE;
in?function?'PicTeXDeviceDriver'.
But it works fine.
src/library/methods/src/methods_list_dispatch.c
r87862
'FALSE' is not replaced with 'false' in calls to
'check_single_string' in functions 'get_generic',
'R_get_generic'.
'TRUE' is not replaced with 'true' in a call to
'check_single_string' in function 'R_methodsPackageMetaName'.
But it works fine.
In function 'R_set_method_dispatch',
value = asBool(onOff)
removes the possibility of
value == NA_LOGICAL
A possible call to 'R_set_method_dispatch' with NA argument is in R
function 'useMTable' in src/library/methods/R/methodsTable.R . But
'useMTable' is not called anywhere and is not exported.