Simon Urbanek
2023-Jan-06 22:36 UTC
[Rd] patch about timezone name of China Standard Time on windows
Just a quick comment here - this is not as easy as it sounds, because the code is in the "extra" directory which means it is based on upstream sources, so those sources are typically not patched manually as it would be hard to apply upstream updates. In this case the standards have changed since the last update, so the way to go about this would be to upgrade according to latest sources and standards as it's quite possible that the issue has been addressed there. However, such update is quite time-consuming process as we have to make sure that the standards are matched and changes have not broken something in R. So you can file an issue so this is on record, but I wouldn't include patches since they cannot be applied directly for reasons explained as it has to be done as a part of the full update, not just a single entry. Cheers, Simon> On Jan 6, 2023, at 10:17 PM, gong yu <yugong at outlook.com> wrote: > > Thanks Ivan! > I really missed the information on https://www.r-project.org/bugs.html . Instead , browse https://bugs.r-project.org<https://bugs.r-project.org/> and didn't found where to registration and login, then send email to this list. > will send a email to bug-report-request at r-project.org. > for two entries in registryTZ.c<https://github.com/r-devel/r-svn/blame/22bf3a2cb1dd6844e69c9214d990bf438a485db7/src/extra/tzone/registryTZ.c> , the China Standard Time is incorrect ,but Taipei Standard Tim is ok > > Best regards, > Yu Gong > > > > ________________________________ > ???: Ivan Krylov <krylov.r00t at gmail.com> > ????: 2023?1?6? 15:26 > ???: gong yu <yugong at outlook.com> > ??: r-devel at r-project.org <r-devel at r-project.org> > ??: Re: [Rd] patch about timezone name of China Standard Time on windows > > Hello Yu Gong! > > I'm not an R developer, but I hope I'll be able to help you with my > advice. > > On Fri, 6 Jan 2023 04:24:43 +0000 > gong yu <yugong at outlook.com> wrote: > >> Last week ,I report a issuse about timezone name about" China >> Standard Time", R on windows will report to Asia/Taipei , but it >> should be Asia/Shanghai, Since still now no feedback (maybe because >> for my poor english). So resubmit a patch about this . > > Sometimes, everyone is too busy to discuss a patch right now, but a > patch just left on R-devel may be eventually forgotten before there's > time for discussion. Try asking for a Bugzilla account (by following > the guide at <https://www.r-project.org/bugs.html>) and submitting the > patch there. > >> and in current R implemention , it report " China Standard Time" is >> incorrect ,but "Taipei Standard Time" is correct, so this patch only >> need modify " China Standard Time" and will not affect other timezone. > > Thank you for verifying this. As far as I can tell, the file has always > contained both entries referring to "Asia/Taipei": > https://github.com/r-devel/r-svn/blame/22bf3a2cb1dd6844e69c9214d990bf438a485db7/src/extra/tzone/registryTZ.c > > -- > Best regards, > Ivan > > [[alternative HTML version deleted]] > > ______________________________________________ > R-devel at r-project.org mailing list > https://stat.ethz.ch/mailman/listinfo/r-devel
gong yu
2023-Jan-07 00:17 UTC
[Rd] 答复: patch about timezone name of China Standard Time on windows
understand your concerns. for registerTZ.c itself , IMHO , the most important part is the definition of tztable[] . which come form http://unicode.org/cldr/data/diff/supplemental/windows_tzid.html ,but it can??t access now, the lasted version is https://unicode-org.github.io/cldr-staging/charts/42/supplemental/zone_tzid.html. maybe we need write a script or small tools , use it sync with unicode standard and microsoft registery or tzutil , to generate tztable definition? will this better than current way? if it is i will try it in next 1-2 weeks. best regards Yu Gong ________________________________ ??????: Simon Urbanek <simon.urbanek at R-project.org> ???????: 2023??1??7?? 6:36 ?????: gong yu <yugong at outlook.com> ????: Ivan Krylov <krylov.r00t at gmail.com>; r-devel at r-project.org <r-devel at r-project.org> ????: Re: [Rd] patch about timezone name of China Standard Time on windows Just a quick comment here - this is not as easy as it sounds, because the code is in the "extra" directory which means it is based on upstream sources, so those sources are typically not patched manually as it would be hard to apply upstream updates. In this case the standards have changed since the last update, so the way to go about this would be to upgrade according to latest sources and standards as it's quite possible that the issue has been addressed there. However, such update is quite time-consuming process as we have to make sure that the standards are matched and changes have not broken something in R. So you can file an issue so this is on record, but I wouldn't include patches since they cannot be applied directly for reasons explained as it has to be done as a part of the full update, not just a single entry. Cheers, Simon> On Jan 6, 2023, at 10:17 PM, gong yu <yugong at outlook.com> wrote: > > Thanks Ivan! > I really missed the information on https://www.r-project.org/bugs.html . Instead , browse [https://bugs.r-project.org<https://bugs.r-project.org/>]https://bugs.r-project.org<https://bugs.r-project.org/> and didn't found where to registration and login, then send email to this list. > will send a email to bug-report-request at r-project.org. > for two entries in registryTZ.c<https://github.com/r-devel/r-svn/blame/22bf3a2cb1dd6844e69c9214d990bf438a485db7/src/extra/tzone/registryTZ.c> , the China Standard Time is incorrect ,but Taipei Standard Tim is ok > > Best regards, > Yu Gong > > > > ________________________________ > ??????: Ivan Krylov <krylov.r00t at gmail.com> > ???????: 2023??1??6?? 15:26 > ?????: gong yu <yugong at outlook.com> > ????: r-devel at r-project.org <r-devel at r-project.org> > ????: Re: [Rd] patch about timezone name of China Standard Time on windows > > Hello Yu Gong! > > I'm not an R developer, but I hope I'll be able to help you with my > advice. > > On Fri, 6 Jan 2023 04:24:43 +0000 > gong yu <yugong at outlook.com> wrote: > >> Last week ,I report a issuse about timezone name about" China >> Standard Time", R on windows will report to Asia/Taipei , but it >> should be Asia/Shanghai, Since still now no feedback (maybe because >> for my poor english). So resubmit a patch about this . > > Sometimes, everyone is too busy to discuss a patch right now, but a > patch just left on R-devel may be eventually forgotten before there's > time for discussion. Try asking for a Bugzilla account (by following > the guide at <https://www.r-project.org/bugs.html>) and submitting the > patch there. > >> and in current R implemention , it report " China Standard Time" is >> incorrect ,but "Taipei Standard Time" is correct, so this patch only >> need modify " China Standard Time" and will not affect other timezone. > > Thank you for verifying this. As far as I can tell, the file has always > contained both entries referring to "Asia/Taipei": > https://github.com/r-devel/r-svn/blame/22bf3a2cb1dd6844e69c9214d990bf438a485db7/src/extra/tzone/registryTZ.c > > -- > Best regards, > Ivan > > [[alternative HTML version deleted]] > > ______________________________________________ > R-devel at r-project.org mailing list > https://stat.ethz.ch/mailman/listinfo/r-devel[[alternative HTML version deleted]]