R devel - Mar 2021 - [Solved] Possible x11 window manager window aggregation under one icon?

On 23/03/2021 11:54 a.m., Ivan Krylov wrote:
> On Tue, 23 Mar 2021 11:41:39 -0400
> Duncan Murdoch <murdoch.duncan at gmail.com> wrote:
> 
>> It would probably be nice  to have rgl windows and other R graphics
>> windows in the same group, but I don't see a way for rgl to know
the
>> group_leader that R is using (and it's probably not worth adding
this
>> to the API to be able to request it).
>>
>> Am I missing an easier solution?
> 
> Do you envision any problems stemming from setting the same WM_CLASS
> ("r_x11", "R_x11") for rgl windows as used by x11()
windows?
Since early 2013, rgl has set the WM_CLASS to ("rgl",
"R_x11").  So I
think with your suggested change to R.desktop the problem is solved, 
assuming the first component (res_name) doesn't matter as long as the 
second one (res_class) matches.

Duncan Murdoch

It all works now, thanks mostly to some very detailed reading of the specs by
Ivan.  In short, I made the following changes:

  - add the missing WM hint to the .desktop file we install
  - add the svg logo as 'scalable'
  - create a new (square) 48x48 default png logo from the new one
  - deactivate yesterday's patch

and it is all good now.  Duncan's rgl windows aggregate under the item, as
do
the standard R x11 devices.  I will try to attach a small screenshot, we'll
see how mailman likes it.  Martin should still be able to get the old (and to
me, buggy) behaviour back by removing the one key line from the .desktop
file, if his Fedora environment ever updates as I plan.

For anyone on Ubuntu 20.10, updated binaries are in my PPA, see
https://launchpad.net/~edd/+archive/ubuntu/misc/+packages?field.name_filter=r-base&field.status_filter=published&field.series_filter=groovy

Changelog entries below, these have not been committed to Debian's git yet
but I think I will activate this for R 4.0.5 next week (and test it til
then). Screenshot attached below too.

------ changelog for these three test builds follows  -----------------------

r-base (4.0.4-1.2010.3) groovy; urgency=medium

  * debian/r-base-core.dirs: Also create the directory
    usr/share/icons/hicolor/scalable/apps for the svg logo

 -- Dirk Eddelbuettel <edd at debian.org>  Tue, 23 Mar 2021 11:05:17 -0500

r-base (4.0.4-1.2010.2) groovy; urgency=medium

  * icon-class-patch/R.desktop: Add 'StartupWMClass=R_x11'
  * icon-class-patch/rlogo_icon.OLD.png.mpack: Renamed old icon
  * icon-class-patch/rlogo_icon.png.mpack: New 48x48 png from svg
  * icon-class-patch/Rlogo.svg: Copy of official logo
  * debian/rules: Also install Rlogo.svg in 'scalable' icons dir

  * debian/patches/series: Deactivate unneeded grouping patch 

 -- Dirk Eddelbuettel <edd at debian.org>  Tue, 23 Mar 2021 10:27:43 -0500

r-base (4.0.4-1.2010.1) groovy; urgency=medium

  * PPA build on Ubuntu 20.10 "groovy"
  * src/modules/X11/devX11.c: Apply patch by Ivan Krylov (posted to r-devel
    on 2021-03-22) enabling grouping of x11 plot device windows

 -- Dirk Eddelbuettel <edd at debian.org>  Mon, 22 Mar 2021 21:33:09 -0500

-----------------------------------------------------------------------------


Dirk


-------------- next part --------------
A non-text attachment was scrubbed...
Name: Screenshot from 2021-03-23 12-30-06.png
Type: image/png
Size: 10924 bytes
Desc: not available
URL:
<https://stat.ethz.ch/pipermail/r-devel/attachments/20210323/24c0e633/attachment.png>

-------------- next part --------------


-- 
https://dirk.eddelbuettel.com | @eddelbuettel | edd at debian.org