R devel - Sep 2019 - [EXTERNAL] RE: install_github and survival

I cloned therneau/survival and the installation failed since there is no
definition for exported function survfit().
A file seems to be missing - there is survfit0() and survfit0.R but, compared to
CRAN, no survfit.R.

Georgi Boshnakov


----------------------------------------------------------------------

Message: 1
Date: Thu, 05 Sep 2019 12:53:11 -0500
From: "Therneau, Terry M., Ph.D." <therneau at mayo.edu>
To: "r-devel at r-project.org" <r-devel at r-project.org>
Subject: [Rd] install_github and survival
Message-ID: <771925$cbifqp at ironport10.mayo.edu>
Content-Type: text/plain; charset="utf-8"

I treat CRAN as the main repository for survival, but I have also had a github 
(therneau/survival) version for a couple of years.? It has a vignette2
directory, for
instance, that contains extra vignettes that either take too long to run or
depend on
other packages.? It also gets updated more often than CRAN (though those updates
mght not
be as well tested yet).

In any case, since it is there, people will of course run install_github against
it.??
I've added a config script to do the one extra step necessary, but when I
try
install_github it fails.?? I'm clearly doing something wrong.? If someone
were willing to
contribute a fix I would be most grateful.

survival3.1-0 is almost ready for CRAN, by the way.?? Reverse dependency checks
of hdnom
turned up one last thing to repair...


Terry Therneau


	[[alternative HTML version deleted]]




------------------------------

Subject: Digest Footer

_______________________________________________
R-devel at r-project.org mailing list  DIGESTED
https://stat.ethz.ch/mailman/listinfo/r-devel


------------------------------

End of R-devel Digest, Vol 199, Issue 6
***************************************

Yes, that is exactly the problem.? The code found in the "config"
script is never run.?
But why doesn't it get run?

On 9/6/19 5:44 AM, Georgi Boshnakov wrote:
> I cloned therneau/survival and the installation failed since there is no
definition for exported function survfit().
> A file seems to be missing - there is survfit0() and survfit0.R but,
compared to CRAN, no survfit.R.
>
> Georgi Boshnakov
>
>
> ----------------------------------------------------------------------
>
> Message: 1
> Date: Thu, 05 Sep 2019 12:53:11 -0500
> From: "Therneau, Terry M., Ph.D." <therneau at mayo.edu>
> To: "r-devel at r-project.org" <r-devel at r-project.org>
> Subject: [Rd] install_github and survival
> Message-ID: <771925$cbifqp at ironport10.mayo.edu>
> Content-Type: text/plain; charset="utf-8"
>
> I treat CRAN as the main repository for survival, but I have also had a
github
> (therneau/survival) version for a couple of years.? It has a vignette2
directory, for
> instance, that contains extra vignettes that either take too long to run or
depend on
> other packages.? It also gets updated more often than CRAN (though those
updates mght not
> be as well tested yet).
>
> In any case, since it is there, people will of course run install_github
against it.
> I've added a config script to do the one extra step necessary, but when
I try
> install_github it fails.?? I'm clearly doing something wrong.? If
someone were willing to
> contribute a fix I would be most grateful.
>
> survival3.1-0 is almost ready for CRAN, by the way.?? Reverse dependency
checks of hdnom
> turned up one last thing to repair...
>
>
> Terry Therneau
>
>
> 	[[alternative HTML version deleted]]
>
>
>
>
> ------------------------------
>
> Subject: Digest Footer
>
> _______________________________________________
> R-devel at r-project.org mailing list  DIGESTED
> https://stat.ethz.ch/mailman/listinfo/r-devel
>
>
> ------------------------------
>
> End of R-devel Digest, Vol 199, Issue 6
> ***************************************

	[[alternative HTML version deleted]]

On Fri, 6 Sep 2019 at 14:08, Therneau, Terry M., Ph.D. via R-devel
<r-devel at r-project.org> wrote:
>
> Yes, that is exactly the problem.  The code found in the "config"
script is never run.
> But why doesn't it get run?
It should be called "configure", not "config".

I?aki