R devel - Feb 2017 - Bug with zlib version checking for zlib >= 1.2.10, R version 3.3.2

Hi,

Posting here as bugzilla is closed to registration.
The zlib version checking code does not handle double digits for the
patch version in the semantic versioning scheme. Consequently, a
./configure fails when using a zlib version ? 1.5.10. I suggest
something like the following patch:

--- a/m4/R.m4
+++ b/m4/R.m4
@@ -3116,7 +3116,7 @@ int main() {
 #ifdef ZLIB_VERSION
 /* Work around Debian bug: it uses 1.2.3.4 even though there was no such
    version on the master site zlib.net */
-  exit(strncmp(ZLIB_VERSION, "1.2.5", 5) < 0);
+  exit(strncmp(ZLIB_VERSION, "1.2.5", 5) < 0 &&
(strlen(ZLIB_VERSION) < 6 || strncmp(ZLIB_VERSION, "1.2.10", 6)
< 0));
 #else
   exit(1);
 #endif

This could of course be improved to properly parse the string.

Cheers,

Justin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 487 bytes
Desc: not available
URL:
<https://stat.ethz.ch/pipermail/r-devel/attachments/20170213/12ffdf5a/attachment.bin>

This has been fixed (https://cran.r-project.org/doc/manuals/r-devel/NEWS.html):

CHANGES IN R 3.3.2 patched:

INSTALLATION on a UNIX-ALIKE

* The configure check for the zlib version is now robust to versions
longer than 5 characters, including 1.2.10.

in SVN r71889 (2017-01-03):

https://github.com/wch/r-source/commit/a0fe05ce9d0937ad2334bb370785cb22c71e592b

/Henrik


On Sun, Feb 12, 2017 at 3:51 PM, Justin Bed? <cu at cua0.org>
wrote:
>
> Hi,
>
> Posting here as bugzilla is closed to registration.
> The zlib version checking code does not handle double digits for the
> patch version in the semantic versioning scheme. Consequently, a
> ./configure fails when using a zlib version ? 1.5.10. I suggest
> something like the following patch:
>
> --- a/m4/R.m4
> +++ b/m4/R.m4
> @@ -3116,7 +3116,7 @@ int main() {
>  #ifdef ZLIB_VERSION
>  /* Work around Debian bug: it uses 1.2.3.4 even though there was no such
>     version on the master site zlib.net */
> -  exit(strncmp(ZLIB_VERSION, "1.2.5", 5) < 0);
> +  exit(strncmp(ZLIB_VERSION, "1.2.5", 5) < 0 &&
(strlen(ZLIB_VERSION) < 6 || strncmp(ZLIB_VERSION, "1.2.10", 6)
< 0));
>  #else
>    exit(1);
>  #endif
>
> This could of course be improved to properly parse the string.
>
> Cheers,
>
> Justin
>
> ______________________________________________
> R-devel at r-project.org mailing list
> https://stat.ethz.ch/mailman/listinfo/r-devel

Henrik Bengtsson <henrik.bengtsson at gmail.com> writes:
> This has been fixed
(https://cran.r-project.org/doc/manuals/r-devel/NEWS.html):
>
> CHANGES IN R 3.3.2 patched:
>
> INSTALLATION on a UNIX-ALIKE
>
> * The configure check for the zlib version is now robust to versions
> longer than 5 characters, including 1.2.10.
>
> in SVN r71889 (2017-01-03):
>
>
https://github.com/wch/r-source/commit/a0fe05ce9d0937ad2334bb370785cb22c71e592b
>
> /Henrik

Thanks, sorry I missed that.

Justin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 487 bytes
Desc: not available
URL:
<https://stat.ethz.ch/pipermail/r-devel/attachments/20170213/d0e3ba2f/attachment.bin>