R devel - Jan 2017 - .Internal for functions in distn.R

Hi,

the functions in distn.R were converted from .Internal to .External ([1], in
2012), and to .Call ([2], in 2014).
They are still listed as .Internal in names.c, although they are not used in
that way.

Shouldn?t they be removed?
There?s quite some simplification to be had, e.g., do_math3 could go away and
do_math2 would be simpler.

If that makes sense (I may be missing something?), I?d be happy to create a
patch that does this.

Best,
 Lukas

[1]
https://github.com/wch/r-source/commit/e430853d37cda69505e7452ddceb06a2008821d2
<https://github.com/wch/r-source/commit/e430853d37cda69505e7452ddceb06a2008821d2>
[2]
https://github.com/wch/r-source/commit/34fa67ca4c1dae13ed6a2ad74af7dbb27c8f3cb2
<https://github.com/wch/r-source/commit/34fa67ca4c1dae13ed6a2ad74af7dbb27c8f3cb2>
	[[alternative HTML version deleted]]

The .Internal support in the C code is still i use for experimental
purposes.

Best,

luke

On Tue, 3 Jan 2017, Lukas Stadler wrote:
> Hi,
>
> the functions in distn.R were converted from .Internal to .External ([1],
in 2012), and to .Call ([2], in 2014).
> They are still listed as .Internal in names.c, although they are not used
in that way.
>
> Shouldn?t they be removed?
> There?s quite some simplification to be had, e.g., do_math3 could go away
and do_math2 would be simpler.
>
> If that makes sense (I may be missing something?), I?d be happy to create a
patch that does this.
>
> Best,
> Lukas
>
> [1]
https://github.com/wch/r-source/commit/e430853d37cda69505e7452ddceb06a2008821d2
<https://github.com/wch/r-source/commit/e430853d37cda69505e7452ddceb06a2008821d2>
> [2]
https://github.com/wch/r-source/commit/34fa67ca4c1dae13ed6a2ad74af7dbb27c8f3cb2
<https://github.com/wch/r-source/commit/34fa67ca4c1dae13ed6a2ad74af7dbb27c8f3cb2>
> 	[[alternative HTML version deleted]]
>
> ______________________________________________
> R-devel at r-project.org mailing list
> https://stat.ethz.ch/mailman/listinfo/r-devel
-- 
Luke Tierney
Ralph E. Wareham Professor of Mathematical Sciences
University of Iowa                  Phone:             319-335-3386
Department of Statistics and        Fax:               319-335-3017
    Actuarial Science
241 Schaeffer Hall                  email:   luke-tierney at uiowa.edu
Iowa City, IA 52242                 WWW:  http://www.stat.uiowa.edu