R devel - Oct 2012 - Addition of plot=F argument to termplot

I have a suggested addition to termplot.
We have a local mod that is used whenever none of the termplot options is quite
right.  It
is used here almost daily for Cox models in order to put the y axis on a risk
scale:

----
fit <- coxph(Surv(time, status) ~ ph.ecog + pspline(age), data=lung)
zz <- termplot(fit, se=TRUE, plot=FALSE)

yy <- zz$age$y + outer(zz$age$se, c(0, -2, 2), '*')
matplot(zz$age$x, exp(yy), log='y', type='l', lty=c(1,2,2),
     xlab="Age", ylab="Relative risk")

----
The return value is a list, each element of which is a dataframe.  Another use
is to
overlay the fits from two different models.
The changes to termplot.R and .Rd are small.  Since we're not supposed to
add attachments
to these emails, where to I send the updated files?

Terry T

On 19/10/2012 18:15, Terry Therneau wrote:
> I have a suggested addition to termplot.
> We have a local mod that is used whenever none of the termplot options
> is quite right.  It is used here almost daily for Cox models in order to
> put the y axis on a risk scale:
>
> ----
> fit <- coxph(Surv(time, status) ~ ph.ecog + pspline(age), data=lung)
> zz <- termplot(fit, se=TRUE, plot=FALSE)
>
> yy <- zz$age$y + outer(zz$age$se, c(0, -2, 2), '*')
> matplot(zz$age$x, exp(yy), log='y', type='l', lty=c(1,2,2),
>      xlab="Age", ylab="Relative risk")
>
> ----
> The return value is a list, each element of which is a dataframe.
> Another use is to overlay the fits from two different models.
> The changes to termplot.R and .Rd are small.  Since we're not supposed
> to add attachments to these emails, where to I send the updated files?
bugs.r-project.org is the best place to lodge enhancement suggestions: 
it accepts attachments.

-- 
Brian D. Ripley,                  ripley at stats.ox.ac.uk
Professor of Applied Statistics,  http://www.stats.ox.ac.uk/~ripley/
University of Oxford,             Tel:  +44 1865 272861 (self)
1 South Parks Road,                     +44 1865 272866 (PA)
Oxford OX1 3TG, UK                Fax:  +44 1865 272595