R devel - Oct 2010 - cleanup_pkg() in tools:::.build_packages() is broken

Hi,

The cleanup_pkg() function defined the big tools:::.build_packages() 
function in tools/R/build.R is currently broken. When Makefiles are
used cleanup_pkg() doesn't clean anything because of the way system2()
is called.

For example, the call to Ssystem() on line 304 (Ssystem is a silent
version of system2) is basically trying to do this:

   > system2(paste(Sys.getenv("MAKE", "make"), makefiles,
"clean"))
   sh: make -f '/home/hpages/R-2.12/etc//Makeconf' -f Makefile clean: 
not found

But it seems that with this new system2(), the arguments to the system
command need to be passed separately thru the 'args' argument.

Cheers,
H.

-- 
Herv? Pag?s

Program in Computational Biology
Division of Public Health Sciences
Fred Hutchinson Cancer Research Center
1100 Fairview Ave. N, M2-B876
P.O. Box 19024
Seattle, WA 98109-1024

E-mail: hpages at fhcrc.org
Phone:  (206) 667-5791
Fax:    (206) 667-1319

This has been fixed in R-beta. Thanks!  H.

On 10/01/2010 06:31 PM, Herv? Pag?s wrote:
> Hi,
>
> The cleanup_pkg() function defined the big tools:::.build_packages()
> function in tools/R/build.R is currently broken. When Makefiles are
> used cleanup_pkg() doesn't clean anything because of the way system2()
> is called.
>
> For example, the call to Ssystem() on line 304 (Ssystem is a silent
> version of system2) is basically trying to do this:
>
>  > system2(paste(Sys.getenv("MAKE", "make"),
makefiles, "clean"))
> sh: make -f '/home/hpages/R-2.12/etc//Makeconf' -f Makefile clean:
not
> found
>
> But it seems that with this new system2(), the arguments to the system
> command need to be passed separately thru the 'args' argument.
>
> Cheers,
> H.
>

-- 
Herv? Pag?s

Program in Computational Biology
Division of Public Health Sciences
Fred Hutchinson Cancer Research Center
1100 Fairview Ave. N, M2-B876
P.O. Box 19024
Seattle, WA 98109-1024

E-mail: hpages at fhcrc.org
Phone:  (206) 667-5791
Fax:    (206) 667-1319