A.R.Runnalls at kent.ac.uk
2010-Jan-28 11:55 UTC
[Rd] src/library/grid/src/grid.c (PR#14199)
At around line 2590, in function gridRect() in src/library/grid/src/grid.c (at the latest svn revision, 50745), ought not temp, www and hhh to be PROTECTed within this block? Andrew
A.R.Runnalls at kent.ac.uk wrote:> At around line 2590, in function gridRect() in > src/library/grid/src/grid.c (at the latest svn revision, 50745), ought > not temp, www and hhh to be PROTECTed within this block?Plausible, provided that anything can allocate while those are being used. Could you perhaps investigate that a little further? (Bug reports should really contains exclamation points and not question marks...) If unit() can allocate, then all constructs like 2565 www = unit(xadj, L_INCHES); 2566 hhh = unit(yadj, L_INCHES); are equally dubious. Oh, never mind, unit() definitely allocates, so of course you are right! -- O__ ---- Peter Dalgaard ?ster Farimagsgade 5, Entr.B c/ /'_ --- Dept. of Biostatistics PO Box 2099, 1014 Cph. K (*) \(*) -- University of Copenhagen Denmark Ph: (+45) 35327918 ~~~~~~~~~~ - (p.dalgaard at biostat.ku.dk) FAX: (+45) 35327907
Hi This is fixed in r-devel (revision 51061). Thanks for the report! Paul Peter Dalgaard wrote:> A.R.Runnalls at kent.ac.uk wrote: >> At around line 2590, in function gridRect() in >> src/library/grid/src/grid.c (at the latest svn revision, 50745), ought >> not temp, www and hhh to be PROTECTed within this block? > > Plausible, provided that anything can allocate while those are being > used. Could you perhaps investigate that a little further? (Bug reports > should really contains exclamation points and not question marks...) > > > If unit() can allocate, then all constructs like > > 2565 www = unit(xadj, L_INCHES); > 2566 hhh = unit(yadj, L_INCHES); > > are equally dubious. > > > Oh, never mind, unit() definitely allocates, so of course you are right! >-- Dr Paul Murrell Department of Statistics The University of Auckland Private Bag 92019 Auckland New Zealand 64 9 3737599 x85392 paul at stat.auckland.ac.nz http://www.stat.auckland.ac.nz/~paul/