R devel - Jan 2005 - as.data.frame.table and the name "Freq"

May I suggest that the method as.data.frame.table not have the name
"Freq" hardwired as the response name?  This is a problem if
"Freq" is
already the name of a stimulus factor.

Here is the existing function:

as.data.frame.table <- function (x, row.names = NULL, optional = FALSE,
...) {
    x <- as.table(x)
    data.frame(do.call("expand.grid", dimnames(x)), Freq = c(x), 
        row.names = row.names)
}

My suggested fix is

as.data.frame.table <- 
function (x, row.names = NULL, optional = FALSE, responseName =
"Freq",
...) {
    x <- as.table(x)
    ex <- Quote(data.frame(do.call("expand.grid", dimnames(x)),
Freq c(x),
        row.names = row.names))
    names(ex)[3] <- responseName
    eval(ex)
}

This should be no slower and should break no existing code.
 
Bill Venables,

No sooner said that done.
It _is_ nice to see code with a suggested enhancement.

On Sat, 8 Jan 2005 Bill.Venables@csiro.au wrote:
> May I suggest that the method as.data.frame.table not have the name
> "Freq" hardwired as the response name?  This is a problem if
"Freq" is
> already the name of a stimulus factor.
>
> Here is the existing function:
>
> as.data.frame.table <- function (x, row.names = NULL, optional = FALSE,
> ...) {
>    x <- as.table(x)
>    data.frame(do.call("expand.grid", dimnames(x)), Freq = c(x),
>        row.names = row.names)
> }
>
> My suggested fix is
>
> as.data.frame.table <-
> function (x, row.names = NULL, optional = FALSE, responseName =
"Freq",
> ...) {
>    x <- as.table(x)
>    ex <- Quote(data.frame(do.call("expand.grid", dimnames(x)),
Freq > c(x),
>        row.names = row.names))
>    names(ex)[3] <- responseName
>    eval(ex)
> }
>
> This should be no slower and should break no existing code.
>
> Bill Venables,
>
> ______________________________________________
> R-devel@stat.math.ethz.ch mailing list
> https://stat.ethz.ch/mailman/listinfo/r-devel
>
>
-- 
Brian D. Ripley,                  ripley@stats.ox.ac.uk
Professor of Applied Statistics,  http://www.stats.ox.ac.uk/~ripley/
University of Oxford,             Tel:  +44 1865 272861 (self)
1 South Parks Road,                     +44 1865 272866 (PA)
Oxford OX1 3TG, UK                Fax:  +44 1865 272595