Gavin Williams
2014-May-06 16:40 UTC
[Puppet Users] Ignore resource in provider if not defined?
Afternoon all, I'm trying to update my Glassfish module [1] to support some additional functionality, such as clustering. I've done most of the code changes, and they all seem to work fine from a usage POV. However several of my tests [2] are failing with the following error: 1) Puppet::Type::Application::ProviderAsadmin when asking exists? should return true if resource is present Failure/Error: application.provider.should be_exists Puppet::Error: Invalid parameter dashost(:dashost) # ./lib/puppet/provider/asadmin.rb:6:in `asadmin_exec' # ./lib/puppet/provider/application/asadmin.rb:22:in `exists?' # ./spec/unit/puppet/provider/application/asadmin_spec.rb:34:in `block (3 levels) in <top (required)>' I suspect this is related to some changes I made to Puppet::Provider::Asadmin [3] in order to support running asadmin commands against a host other than localhost. Effectively, I'm just trying to only use the 'dashost' resource value if it's defined and not null. This works fine for actual usage, but seems to fail horribly for RSpec testing :( Cheers in advance for any replies. Regards Gavin [1] https://github.com/fatmcgav/puppet-glassfish/tree/develop [2] https://travis-ci.org/fatmcgav/puppet-glassfish/jobs/24549377#L505-L511 [3] https://github.com/fatmcgav/puppet-glassfish/blob/develop/lib/puppet/provider/asadmin.rb#L6-L8 -- You received this message because you are subscribed to the Google Groups "Puppet Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-users+unsubscribe@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-users/c111d1e0-a988-49ec-aa6e-9d67680602af%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.