Hi, Over the last few days I''ve spent some time refactoring the puppetlabs-ntp module to be a little bit more modern in style and not to be one giant class. As a result I''ve released a release candidate and I wanted to give users of the module a headsup to take a look at the differences and possibly go as far as testing out the new version. For the most significant change we''re deprecating autoupdate in favor of just setting package_ensure to whatever you''d like it to be. Some other parameters have been reorganized and tweaked to align better with resource_ensure style naming. http://forge.puppetlabs.com/puppetlabs/ntp/1.0.0-rc1 or github is where you can grab the latest if you''re willing to test it. If you have any feedback regarding the general design of the module this is an excellent place to hash it out as we''ll be out to improve other modules with time. Thanks, -- You received this message because you are subscribed to the Google Groups "Puppet Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-users+unsubscribe@googlegroups.com. To post to this group, send email to puppet-users@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-users. For more options, visit https://groups.google.com/groups/opt_out.
On Tue, 9 Jul 2013 18:21:52 -0400 Ashley Penney <ashley.penney@puppetlabs.com> wrote:> http://forge.puppetlabs.com/puppetlabs/ntp/1.0.0-rc1 or github is > where you can grab the latest if you''re willing to test it. > > If you have any feedback regarding the general design of the module > this is an excellent place to hash it out as we''ll be out to improve > other modules with time.It looks really nice and clean! I would personally only have a few very minor nitpicks : * Shouldn''t the placeholder files/README.markdown be removed? * Space between class name and parenthesis inconsistency : "class foo(..." vs. "class foo (..." * In the templates, this comment should use single quotes : # Managed by puppet class { "ntp": servers => [ ... ] } * In the el template, this variable isn''t in the current scope : <% if @is_virtual == "false" -%> Add a new params variable for it, similar to $panic? * For "real" RHEL, the ntp server hostnames used will be "centos" instead of the original "rhel" ones. I''m not sure this is worth trying to fix, though. Great work on cleaning up the module! Matthias -- Matthias Saou ██ ██ ██ ██ Web: http://matthias.saou.eu/ ██████████████ Mail/XMPP: matthias@saou.eu ████ ██████ ████ ██████████████████████ GPG: 4096R/E755CC63 ██ ██████████████ ██ 8D91 7E2E F048 9C9C 46AF ██ ██ ██ ██ 21A9 7A51 7B82 E755 CC63 ████ ████ -- You received this message because you are subscribed to the Google Groups "Puppet Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-users+unsubscribe@googlegroups.com. To post to this group, send email to puppet-users@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-users. For more options, visit https://groups.google.com/groups/opt_out.
How do you get the service to restart if the config file changes ? ~Francis http://7terminals.com On Wed, Jul 10, 2013 at 2:44 PM, Matthias Saou <matthias@saou.eu> wrote:> On Tue, 9 Jul 2013 18:21:52 -0400 > Ashley Penney <ashley.penney@puppetlabs.com> wrote: > > > http://forge.puppetlabs.com/puppetlabs/ntp/1.0.0-rc1 or github is > > where you can grab the latest if you''re willing to test it. > > > > If you have any feedback regarding the general design of the module > > this is an excellent place to hash it out as we''ll be out to improve > > other modules with time. > > It looks really nice and clean! I would personally only have a few very > minor nitpicks : > > * Shouldn''t the placeholder files/README.markdown be removed? > * Space between class name and parenthesis inconsistency : > "class foo(..." vs. "class foo (..." > * In the templates, this comment should use single quotes : > # Managed by puppet class { "ntp": servers => [ ... ] } > * In the el template, this variable isn''t in the current scope : > <% if @is_virtual == "false" -%> > Add a new params variable for it, similar to $panic? > * For "real" RHEL, the ntp server hostnames used will be "centos" > instead of the original "rhel" ones. I''m not sure this is worth > trying to fix, though. > > Great work on cleaning up the module! > > Matthias > > -- > Matthias Saou ██ ██ > ██ ██ > Web: http://matthias.saou.eu/ ██████████████ > Mail/XMPP: matthias@saou.eu ████ ██████ ████ > ██████████████████████ > GPG: 4096R/E755CC63 ██ ██████████████ ██ > 8D91 7E2E F048 9C9C 46AF ██ ██ ██ ██ > 21A9 7A51 7B82 E755 CC63 ████ ████ > > -- > You received this message because you are subscribed to the Google Groups > "Puppet Users" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to puppet-users+unsubscribe@googlegroups.com. > To post to this group, send email to puppet-users@googlegroups.com. > Visit this group at http://groups.google.com/group/puppet-users. > For more options, visit https://groups.google.com/groups/opt_out. > > >-- You received this message because you are subscribed to the Google Groups "Puppet Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-users+unsubscribe@googlegroups.com. To post to this group, send email to puppet-users@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-users. For more options, visit https://groups.google.com/groups/opt_out.
On Wed, 10 Jul 2013 17:09:25 +0530 Francis Pereira <francispereira@7terminals.com> wrote:> How do you get the service to restart if the config file changes ?Look at the ~> (and not ->) at the bottom of init.pp, where the config class notifies the service class : Anchor[''ntp::begin''] -> Class[''::ntp::install''] -> Class[''::ntp::config''] ~> Class[''::ntp::service''] -> Anchor[''ntp::end''] Matthias -- Matthias Saou ██ ██ ██ ██ Web: http://matthias.saou.eu/ ██████████████ Mail/XMPP: matthias@saou.eu ████ ██████ ████ ██████████████████████ GPG: 4096R/E755CC63 ██ ██████████████ ██ 8D91 7E2E F048 9C9C 46AF ██ ██ ██ ██ 21A9 7A51 7B82 E755 CC63 ████ ████ -- You received this message because you are subscribed to the Google Groups "Puppet Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-users+unsubscribe@googlegroups.com. To post to this group, send email to puppet-users@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-users. For more options, visit https://groups.google.com/groups/opt_out.
Thanks Matthias ~Francis http://7terminals.com On Wed, Jul 10, 2013 at 5:31 PM, Matthias Saou <matthias@saou.eu> wrote:> On Wed, 10 Jul 2013 17:09:25 +0530 > Francis Pereira <francispereira@7terminals.com> wrote: > > > How do you get the service to restart if the config file changes ? > > Look at the ~> (and not ->) at the bottom of init.pp, where the > config class notifies the service class : > > Anchor[''ntp::begin''] -> Class[''::ntp::install''] -> > Class[''::ntp::config''] ~> Class[''::ntp::service''] -> > Anchor[''ntp::end''] > > Matthias > > -- > Matthias Saou ██ ██ > ██ ██ > Web: http://matthias.saou.eu/ ██████████████ > Mail/XMPP: matthias@saou.eu ████ ██████ ████ > ██████████████████████ > GPG: 4096R/E755CC63 ██ ██████████████ ██ > 8D91 7E2E F048 9C9C 46AF ██ ██ ██ ██ > 21A9 7A51 7B82 E755 CC63 ████ ████ > > -- > You received this message because you are subscribed to the Google Groups > "Puppet Users" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to puppet-users+unsubscribe@googlegroups.com. > To post to this group, send email to puppet-users@googlegroups.com. > Visit this group at http://groups.google.com/group/puppet-users. > For more options, visit https://groups.google.com/groups/opt_out. > > >-- You received this message because you are subscribed to the Google Groups "Puppet Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-users+unsubscribe@googlegroups.com. To post to this group, send email to puppet-users@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-users. For more options, visit https://groups.google.com/groups/opt_out.
Just out of curiosity, has anyone done a performance analysis on moving to the Anchor -> Class dependency structure? Since these classes are small, it shouldn''t be *too* bad but I can see issues with using this pattern blindly in terms of memory usage and catalog size/transmission size. Alternatively, if it gets more performant, I''d love to know that as well! Thanks, Trevor On Wed, Jul 10, 2013 at 8:01 AM, Matthias Saou <matthias@saou.eu> wrote:> On Wed, 10 Jul 2013 17:09:25 +0530 > Francis Pereira <francispereira@7terminals.com> wrote: > > > How do you get the service to restart if the config file changes ? > > Look at the ~> (and not ->) at the bottom of init.pp, where the > config class notifies the service class : > > Anchor[''ntp::begin''] -> Class[''::ntp::install''] -> > Class[''::ntp::config''] ~> Class[''::ntp::service''] -> > Anchor[''ntp::end''] > > Matthias > > -- > Matthias Saou ██ ██ > ██ ██ > Web: http://matthias.saou.eu/ ██████████████ > Mail/XMPP: matthias@saou.eu ████ ██████ ████ > ██████████████████████ > GPG: 4096R/E755CC63 ██ ██████████████ ██ > 8D91 7E2E F048 9C9C 46AF ██ ██ ██ ██ > 21A9 7A51 7B82 E755 CC63 ████ ████ > > -- > You received this message because you are subscribed to the Google Groups > "Puppet Users" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to puppet-users+unsubscribe@googlegroups.com. > To post to this group, send email to puppet-users@googlegroups.com. > Visit this group at http://groups.google.com/group/puppet-users. > For more options, visit https://groups.google.com/groups/opt_out. > > >-- Trevor Vaughan Vice President, Onyx Point, Inc (410) 541-6699 tvaughan@onyxpoint.com -- This account not approved for unencrypted proprietary information -- -- You received this message because you are subscribed to the Google Groups "Puppet Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-users+unsubscribe@googlegroups.com. To post to this group, send email to puppet-users@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-users. For more options, visit https://groups.google.com/groups/opt_out.
On Wednesday, July 10, 2013 9:03:02 AM UTC-5, Trevor Vaughan wrote:> > Just out of curiosity, has anyone done a performance analysis on moving to > the Anchor -> Class dependency structure? > > Since these classes are small, it shouldn''t be *too* bad but I can see > issues with using this pattern blindly in terms of memory usage and catalog > size/transmission size. >I don''t know about performance, but there are worse problems than that associated with blindly using anchors. In particular, if two or more different classes anchor the same third class into themselves, then there is a significant risk of creating dependency cycles. All you need beyond that is a direct or transitive relationship between any two of the containing classes. This is not an issue for the NTP module because module users are supposed to declare only the front-end class "ntp", not the internal classes. The whole point, however, is that anchoring classes is not always the right thing to do. In fact, I think that can manifest in a single class, in that it may be appropriate for some classes to anchor some of the other classes it declares into itself, but not others. As usual, it is all about modeling. Anchoring class B into class A effectively says "class B is *part of* class A". If the truth is that class A merely relies on class B, then anchoring is inappropriate. I think Trevor recognizes it, but to be clear: the real question is not whether to anchor or not, but whether to implement modules with fewer, larger classes or more, smaller classes. With a given set of classes, anchoring is a correctness issue, not a performance issue. Breaking up classes into collection of smaller classes tends to create a need for anchoring, however, and with Trevor, my suspicion is that that will tend to reduce performance (and increase resource consumption). How much of an impact that might be, however, I cannot say. John -- You received this message because you are subscribed to the Google Groups "Puppet Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-users+unsubscribe@googlegroups.com. To post to this group, send email to puppet-users@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-users. For more options, visit https://groups.google.com/groups/opt_out.
On Wed, Jul 10, 2013 at 5:14 AM, Matthias Saou <matthias@saou.eu> wrote:> > It looks really nice and clean! I would personally only have a few very > minor nitpicks : > > * Shouldn''t the placeholder files/README.markdown be removed? > * Space between class name and parenthesis inconsistency : > "class foo(..." vs. "class foo (..." > * In the templates, this comment should use single quotes : > # Managed by puppet class { "ntp": servers => [ ... ] } > * In the el template, this variable isn''t in the current scope : > <% if @is_virtual == "false" -%> > Add a new params variable for it, similar to $panic? > * For "real" RHEL, the ntp server hostnames used will be "centos" > instead of the original "rhel" ones. I''m not sure this is worth > trying to fix, though. > > Great work on cleaning up the module!Good eye! I''ve opened https://github.com/puppetlabs/puppetlabs-ntp/pull/68for these fixes. I just switched over to scope.lookupvar(''::is_virtual'') for that single use rather than make it a parameter as it''s coming out of the box via facter. If anyone knows the "official" rhel ntp servers then let me know and I''ll distinguish between rhel/centos if anyone cares. Honestly we''d be better off just defining a pool from pool.ntp.org as the "standard" set used everywhere and let people override them rather than carry this list around. It''s less likely to drift out of date. I started another email about unifying the templates so if anyone wants to discuss pools, lets take it there. -- You received this message because you are subscribed to the Google Groups "Puppet Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-users+unsubscribe@googlegroups.com. To post to this group, send email to puppet-users@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-users. For more options, visit https://groups.google.com/groups/opt_out.