On the wiki page
http://projects.puppetlabs.com/projects/1/wiki/Puppet_Version_Control, the SVN
Pre-Commit Hook script needs to be fixed to not check the syntax on files
getting deleted.
The following line:
$SVNLOOK changed -t "$TXN" "$REPOS" | awk ''{print
$2}'' | grep ''\.pp$'' | while read line
needs to be:
$SVNLOOK changed -t "$TXN" "$REPOS" | grep -v ^D | awk
''{print $2}'' | grep ''\.pp$'' | while read
line
--
You received this message because you are subscribed to the Google Groups
"Puppet Users" group.
To post to this group, send email to puppet-users@googlegroups.com.
To unsubscribe from this group, send email to
puppet-users+unsubscribe@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/puppet-users?hl=en.
On 09/02/2010 02:34 PM, Carl Caum wrote:> On the wiki page http://projects.puppetlabs.com/projects/1/wiki/Puppet_Version_Control, the SVN Pre-Commit Hook script needs to be fixed to not check the syntax on files getting deleted. > > The following line: > $SVNLOOK changed -t "$TXN" "$REPOS" | awk ''{print $2}'' | grep ''\.pp$'' | while read line > > needs to be: > $SVNLOOK changed -t "$TXN" "$REPOS" | grep -v ^D | awk ''{print $2}'' | grep ''\.pp$'' | while read line > >Sort of moot since the pre-commit was operational in the first place, there should be no syntax errors in any committed files... I think there might be a problem or two with that pre-commit in other areas. -- Joe McDonagh AIM: YoosingYoonickz IRC: joe-mac on freenode "When the going gets weird, the weird turn pro." -- You received this message because you are subscribed to the Google Groups "Puppet Users" group. To post to this group, send email to puppet-users@googlegroups.com. To unsubscribe from this group, send email to puppet-users+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/puppet-users?hl=en.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 09/02/2010 08:34 PM, Carl Caum wrote:> On the wiki page http://projects.puppetlabs.com/projects/1/wiki/Puppet_Version_Control, the SVN Pre-Commit Hook script needs to be fixed to not check the syntax on files getting deleted.as it is a wiki you can update it yourself! cheers pete -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAkx/8R8ACgkQbwltcAfKi38SEQCdHEwyIysnuRZRnf+VgoZzW5R2 ZCsAoINHI7zrXn3IBYXzqPbQhWJ7eyf7 =D/kR -----END PGP SIGNATURE----- -- You received this message because you are subscribed to the Google Groups "Puppet Users" group. To post to this group, send email to puppet-users@googlegroups.com. To unsubscribe from this group, send email to puppet-users+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/puppet-users?hl=en.
Huh. I didn''t think I had permission to edit that. Turns out I already had a login and everything :P On Sep 2, 2010, at 1:46 PM, Peter Meier wrote:> -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On 09/02/2010 08:34 PM, Carl Caum wrote: >> On the wiki page http://projects.puppetlabs.com/projects/1/wiki/Puppet_Version_Control, the SVN Pre-Commit Hook script needs to be fixed to not check the syntax on files getting deleted. > > as it is a wiki you can update it yourself! > > cheers pete > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.10 (GNU/Linux) > Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ > > iEYEARECAAYFAkx/8R8ACgkQbwltcAfKi38SEQCdHEwyIysnuRZRnf+VgoZzW5R2 > ZCsAoINHI7zrXn3IBYXzqPbQhWJ7eyf7 > =D/kR > -----END PGP SIGNATURE----- > > -- > You received this message because you are subscribed to the Google Groups "Puppet Users" group. > To post to this group, send email to puppet-users@googlegroups.com. > To unsubscribe from this group, send email to puppet-users+unsubscribe@googlegroups.com. > For more options, visit this group at http://groups.google.com/group/puppet-users?hl=en. >-- You received this message because you are subscribed to the Google Groups "Puppet Users" group. To post to this group, send email to puppet-users@googlegroups.com. To unsubscribe from this group, send email to puppet-users+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/puppet-users?hl=en.