I noticed the require ''class'' function has made 0.25.
I''ve been
having some issues appending to arrays (order of execution I believe)
and wondered if this would now work -
node ''a'' {
include webserver, database, stats
# stats.pp
$mystat1 = []
class stats {
if tagged(''webserver'') {
require webserver::stats # used to be include
}
if tagged(''database'') {
require database::stats # used to be include
}
if mystat1 != [] {
deploystats()
}
define deploystats() # the array mystat1is used in the $myfile.erb
file { "/stats/$myfile" :
ensure => present,
content => template("module/$myfile.erb"),
notify => Service["statservice"],
}
# webserver.pp
class webserver::stats {
$mystat1 += ["processName"]
}
# database.pp
class database::stats {
$mystat1 += ["processName"]
}
After writing the above i''m guessing it still won''t quite work
as the
deploystats() could still get called before the ''if tagged''
statements
get seen?!
If thats the case then I guess my options are either too add a new
type that modifies the files, or use augeas?
Thanks,
Matt
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Puppet Users" group.
To post to this group, send email to puppet-users@googlegroups.com
To unsubscribe from this group, send email to
puppet-users+unsubscribe@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/puppet-users?hl=en
-~----------~----~----~----~------~----~------~--~---
On Sep 7, 2009, at 1:47 AM, Matt wrote:> > I noticed the require ''class'' function has made 0.25. I''ve been > having some issues appending to arrays (order of execution I believe) > and wondered if this would now work - > > node ''a'' { > include webserver, database, stats > > # stats.pp > $mystat1 = [] > > class stats { > if tagged(''webserver'') { > require webserver::stats # used to be include > } > if tagged(''database'') { > require database::stats # used to be include > } > > if mystat1 != [] { > deploystats() > } > > define deploystats() # the array mystat1is used in the $myfile.erb > file { "/stats/$myfile" : > ensure => present, > content => template("module/$myfile.erb"), > notify => Service["statservice"], > } > > # webserver.pp > class webserver::stats { > $mystat1 += ["processName"] > } > > # database.pp > class database::stats { > $mystat1 += ["processName"] > } > > After writing the above i''m guessing it still won''t quite work as the > deploystats() could still get called before the ''if tagged'' statements > get seen?! > > If thats the case then I guess my options are either too add a new > type that modifies the files, or use augeas?It seems like this should work, but the ''stats'' classes don''t actually have any code in them, so all of the ordering is in the language, so there''s no real difference between ''require'' and ''include'' here. -- You can''t build a reputation on what you are going to do. -- Henry Ford --------------------------------------------------------------------- Luke Kanies | http://reductivelabs.com | http://madstop.com --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Users" group. To post to this group, send email to puppet-users@googlegroups.com To unsubscribe from this group, send email to puppet-users+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/puppet-users?hl=en -~----------~----~----~----~------~----~------~--~---
The stats class are appending to an array, which the template uses in the define, so the stats class needs to be required rather than include. I''ve done this and it appears to be working properly. Only gotcha I had was that $mystat1 += ["processName"] didn''t work - I got a "unable to convert array to string error", but using $mystat1 +''processName'' worked. For me this takes away any variables I need to set at the node level for stat collection, instead I can manage it all in a set of puppet classes. Thanks, Matt 2009/9/10 Luke Kanies <luke@madstop.com>:> > On Sep 7, 2009, at 1:47 AM, Matt wrote: > >> >> I noticed the require ''class'' function has made 0.25. I''ve been >> having some issues appending to arrays (order of execution I believe) >> and wondered if this would now work - >> >> node ''a'' { >> include webserver, database, stats >> >> # stats.pp >> $mystat1 = [] >> >> class stats { >> if tagged(''webserver'') { >> require webserver::stats # used to be include >> } >> if tagged(''database'') { >> require database::stats # used to be include >> } >> >> if mystat1 != [] { >> deploystats() >> } >> >> define deploystats() # the array mystat1is used in the $myfile.erb >> file { "/stats/$myfile" : >> ensure => present, >> content => template("module/$myfile.erb"), >> notify => Service["statservice"], >> } >> >> # webserver.pp >> class webserver::stats { >> $mystat1 += ["processName"] >> } >> >> # database.pp >> class database::stats { >> $mystat1 += ["processName"] >> } >> >> After writing the above i''m guessing it still won''t quite work as the >> deploystats() could still get called before the ''if tagged'' statements >> get seen?! >> >> If thats the case then I guess my options are either too add a new >> type that modifies the files, or use augeas? > > > It seems like this should work, but the ''stats'' classes don''t actually > have any code in them, so all of the ordering is in the language, so > there''s no real difference between ''require'' and ''include'' here. > > -- > You can''t build a reputation on what you are going to do. > -- Henry Ford > --------------------------------------------------------------------- > Luke Kanies | http://reductivelabs.com | http://madstop.com > > > > >--~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Users" group. To post to this group, send email to puppet-users@googlegroups.com To unsubscribe from this group, send email to puppet-users+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/puppet-users?hl=en -~----------~----~----~----~------~----~------~--~---