thr3ads.net - Puppet users - Parsechecking in a commit hook [Mar 2007]

If this information is useful, please help other people find it:
Share via:

Luke Kanies

2007-Mar-19 01:21 UTC

Parsechecking in a commit hook

This has been a much-requested feature, and is now a reality (in svn  
trunk):

There is a new option, --ignoreimport, that will (surprisingly)  
ignore import statements.  This is really only useful when using -- 
parseonly in a commit hook, and note that you''ll have to add the  
option to --parseonly, none of the puppet executables will add it for  
you.  You should be able to parse-check a single file with something  
like this:

   puppet --parseonly --ignoreimport <file>

Committed in [2302].

Also, import statements can now specify multiple files at once:

   import ''one'', ''two''

[2302]: https://reductivelabs.com/trac/puppet/changeset/2302

  --
  Never try to tell everything you know. It may take too short a time.
          --Norman Ford
  ---------------------------------------------------------------------
  Luke Kanies | http://reductivelabs.com | http://madstop.com

Kevin Fox

2007-Mar-21 00:04 UTC

head link

Re: Parsechecking in a commit hook

Thanks for this feature.

I''m trying to implement it in the svn pre-commit hook script and am
getting this:

Sending        configs/manifests/sites/test.pp
Transmitting file data .svn: Commit failed (details follow):
svn: ''pre-commit'' hook failed with error output:
/usr/lib/site_ruby/1.8/puppet/configuration.rb:9:in `expand_path'':
couldn''t find HOME environment -- expanding `~/.puppet''
(ArgumentError)
        from /usr/lib/site_ruby/1.8/puppet/configuration.rb:9
        from /usr/lib/site_ruby/1.8/puppet.rb:109:in `require''
        from /usr/lib/site_ruby/1.8/puppet.rb:109
        from /usr/bin/puppet:62:in `require''
        from /usr/bin/puppet:62

I''m using svn+ssh for the svn protocol, so its running as my user
instead of root. Know what may be causing this and how to force it to
ignore it?

Thanks,
Kevin

On Sun, 2007-03-18 at 20:21 -0500, Luke Kanies wrote:> This has been a much-requested feature, and is now a reality (in svn  
> trunk):
> 
> There is a new option, --ignoreimport, that will (surprisingly)  
> ignore import statements.  This is really only useful when using -- 
> parseonly in a commit hook, and note that you''ll have to add the  
> option to --parseonly, none of the puppet executables will add it for  
> you.  You should be able to parse-check a single file with something  
> like this:
> 
>    puppet --parseonly --ignoreimport <file>
> 
> Committed in [2302].
> 
> Also, import statements can now specify multiple files at once:
> 
>    import ''one'', ''two''
> 
> [2302]: https://reductivelabs.com/trac/puppet/changeset/2302
> 
>   --
>   Never try to tell everything you know. It may take too short a time.
>           --Norman Ford
>   ---------------------------------------------------------------------
>   Luke Kanies | http://reductivelabs.com | http://madstop.com
> 
> 
> _______________________________________________
> Puppet-users mailing list
> Puppet-users@madstop.com
> https://mail.madstop.com/mailman/listinfo/puppet-users

Kevin Fox

2007-Mar-21 00:25 UTC

head link

Re: Parsechecking in a commit hook

I commented out the ~/.puppet stuff forcing it to use /etc/puppet to
continue testing, and ran into another problem:

Sending        configs/manifests/sites/test.pp
Transmitting file data .svn: Commit failed (details follow):
svn: ''pre-commit'' hook failed with error output:
Could not autoload
"/usr/lib/site_ruby/1.8/puppet/provider/user/netinfo.rb": private
method
`split'' called for nil:NilClass
Could not autoload
"/usr/lib/site_ruby/1.8/puppet/provider/user/pw.rb":
private method `split'' called for nil:NilClass
Could not autoload
"/usr/lib/site_ruby/1.8/puppet/provider/user/useradd.rb": private
method
`split'' called for nil:NilClass
Could not autoload
"/usr/lib/site_ruby/1.8/puppet/provider/group/groupadd.rb": private
method `split'' called for nil:NilClass
Could not autoload
"/usr/lib/site_ruby/1.8/puppet/provider/group/netinfo.rb": private
method `split'' called for nil:NilClass
err: /puppetconfig/puppet/File[/var/puppet/lib]/ensure: change from
absent to directory failed: Could not set directory on ensure:
Permission denied - /var/puppet/lib
err: /puppetconfig/puppet/File[/etc/puppet/ssl]/mode: change from 755 to
771 failed: failed to chmod /etc/puppet/ssl: Operation not permitted
- /etc/puppet/ssl

It looks like it may be ignoring the --parseonly?

Kevin

On Tue, 2007-03-20 at 17:04 -0700, Kevin Fox wrote:> Thanks for this feature.
> 
> I''m trying to implement it in the svn pre-commit hook script and
am
> getting this:
> 
> Sending        configs/manifests/sites/test.pp
> Transmitting file data .svn: Commit failed (details follow):
> svn: ''pre-commit'' hook failed with error output:
> /usr/lib/site_ruby/1.8/puppet/configuration.rb:9:in `expand_path'':
> couldn''t find HOME environment -- expanding `~/.puppet''
(ArgumentError)
>         from /usr/lib/site_ruby/1.8/puppet/configuration.rb:9
>         from /usr/lib/site_ruby/1.8/puppet.rb:109:in `require''
>         from /usr/lib/site_ruby/1.8/puppet.rb:109
>         from /usr/bin/puppet:62:in `require''
>         from /usr/bin/puppet:62
> 
> I''m using svn+ssh for the svn protocol, so its running as my user
> instead of root. Know what may be causing this and how to force it to
> ignore it?
> 
> Thanks,
> Kevin
> 
> On Sun, 2007-03-18 at 20:21 -0500, Luke Kanies wrote:
> > This has been a much-requested feature, and is now a reality (in svn  
> > trunk):
> > 
> > There is a new option, --ignoreimport, that will (surprisingly)  
> > ignore import statements.  This is really only useful when using -- 
> > parseonly in a commit hook, and note that you''ll have to add
the
> > option to --parseonly, none of the puppet executables will add it for
> > you.  You should be able to parse-check a single file with something  
> > like this:
> > 
> >    puppet --parseonly --ignoreimport <file>
> > 
> > Committed in [2302].
> > 
> > Also, import statements can now specify multiple files at once:
> > 
> >    import ''one'', ''two''
> > 
> > [2302]: https://reductivelabs.com/trac/puppet/changeset/2302
> > 
> >   --
> >   Never try to tell everything you know. It may take too short a time.
> >           --Norman Ford
> >  
---------------------------------------------------------------------
> >   Luke Kanies | http://reductivelabs.com | http://madstop.com
> > 
> > 
> > _______________________________________________
> > Puppet-users mailing list
> > Puppet-users@madstop.com
> > https://mail.madstop.com/mailman/listinfo/puppet-users
> _______________________________________________
> Puppet-users mailing list
> Puppet-users@madstop.com
> https://mail.madstop.com/mailman/listinfo/puppet-users

Luke Kanies

2007-Mar-22 15:51 UTC

head link

Re: Parsechecking in a commit hook

On Mar 20, 2007, at 7:04 PM, Kevin Fox wrote:
> Thanks for this feature.
>
> I''m trying to implement it in the svn pre-commit hook script and
am
> getting this:
>
> Sending        configs/manifests/sites/test.pp
> Transmitting file data .svn: Commit failed (details follow):
> svn: ''pre-commit'' hook failed with error output:
> /usr/lib/site_ruby/1.8/puppet/configuration.rb:9:in `expand_path'':
> couldn''t find HOME environment -- expanding  
> `~/.puppet'' (ArgumentError)
>         from /usr/lib/site_ruby/1.8/puppet/configuration.rb:9
>         from /usr/lib/site_ruby/1.8/puppet.rb:109:in `require''
>         from /usr/lib/site_ruby/1.8/puppet.rb:109
>         from /usr/bin/puppet:62:in `require''
>         from /usr/bin/puppet:62
>
> I''m using svn+ssh for the svn protocol, so its running as my user
> instead of root. Know what may be causing this and how to force it to
> ignore it?
What user is this running as?

It looks like the environment this command is running under has no  
way to expand ''~'', which means Puppet doesn''t know
what its home
directory is.

The other problems you''re getting are because Puppet tries to make  
sure it''s configured correctly, but you''ve told it to use a
directory
it doesn''t have access to.  Until I get a fix for this (which will  
probably just be a stand-alone command that''s only useful for parse- 
checking and doesn''t do anything else), I recommend setting --vardir  
and --confdir to something in /tmp, or some other explicit path that  
this user has write access to.

  --
  Risk! Risk anything! Care no more for the opinions of others, for  
those
  voices.  Do the hardest thing on earth for you. Act for yourself. Face
  the truth.  -- Katherine Mansfield
  ---------------------------------------------------------------------
  Luke Kanies | http://reductivelabs.com | http://madstop.com

Kevin Fox

2007-Mar-22 16:30 UTC

head link

Re: Parsechecking in a commit hook

On Thu, 2007-03-22 at 10:51 -0500, Luke Kanies wrote:> On Mar 20, 2007, at 7:04 PM, Kevin Fox wrote:
> 
> > Thanks for this feature.
> >
> > I''m trying to implement it in the svn pre-commit hook script
and am
> > getting this:
> >
> > Sending        configs/manifests/sites/test.pp
> > Transmitting file data .svn: Commit failed (details follow):
> > svn: ''pre-commit'' hook failed with error output:
> > /usr/lib/site_ruby/1.8/puppet/configuration.rb:9:in
`expand_path'':
> > couldn''t find HOME environment -- expanding  
> > `~/.puppet'' (ArgumentError)
> >         from /usr/lib/site_ruby/1.8/puppet/configuration.rb:9
> >         from /usr/lib/site_ruby/1.8/puppet.rb:109:in
`require''
> >         from /usr/lib/site_ruby/1.8/puppet.rb:109
> >         from /usr/bin/puppet:62:in `require''
> >         from /usr/bin/puppet:62
> >
> > I''m using svn+ssh for the svn protocol, so its running as my
user
> > instead of root. Know what may be causing this and how to force it to
> > ignore it?
> 
> What user is this running as?
What ever user is doing the svn commit. In my case, kfox.
> 
> It looks like the environment this command is running under has no  
> way to expand ''~'', which means Puppet doesn''t
know what its home
> directory is.
Sure. Maybe it should fallback to the system default in that case?

Right now, it panics if it can''t find ~/ even if you manually specify
confdir and vardir.
> 
> The other problems you''re getting are because Puppet tries to make
> sure it''s configured correctly, but you''ve told it to use
a directory
> it doesn''t have access to.  Until I get a fix for this (which will
> probably just be a stand-alone command that''s only useful for
parse-
> checking and doesn''t do anything else), I recommend setting
--vardir
> and --confdir to something in /tmp, or some other explicit path that  
> this user has write access to.
That fixed most of the problem, but I''m still getting the:

Could not autoload
"/usr/lib/site_ruby/1.8/puppet/provider/user/netinfo.rb": private
method
`split'' called for nil:NilClass

stuff.

Any ideas?

Thanks for all the help,
Kevin
> 
>   --
>   Risk! Risk anything! Care no more for the opinions of others, for  
> those
>   voices.  Do the hardest thing on earth for you. Act for yourself. Face
>   the truth.  -- Katherine Mansfield
>   ---------------------------------------------------------------------
>   Luke Kanies | http://reductivelabs.com | http://madstop.com
> 
> 
> _______________________________________________
> Puppet-users mailing list
> Puppet-users@madstop.com
> https://mail.madstop.com/mailman/listinfo/puppet-users

Luke Kanies

2007-Mar-22 18:05 UTC

head link

Re: Parsechecking in a commit hook

On Mar 22, 2007, at 11:30 AM, Kevin Fox wrote:> Sure. Maybe it should fallback to the system default in that case?
Except the system default is not writeable by root.
> Right now, it panics if it can''t find ~/ even if you manually
specify
> confdir and vardir.
I''ll try to find a way to skip all of the configuration and just do a  
parse test, since no configuration is necessary in this simple case.
>> The other problems you''re getting are because Puppet tries to
make
>> sure it''s configured correctly, but you''ve told it to
use a directory
>> it doesn''t have access to.  Until I get a fix for this (which
will
>> probably just be a stand-alone command that''s only useful for
parse-
>> checking and doesn''t do anything else), I recommend setting
--vardir
>> and --confdir to something in /tmp, or some other explicit path that
>> this user has write access to.
>
> That fixed most of the problem, but I''m still getting the:
>
> Could not autoload
> "/usr/lib/site_ruby/1.8/puppet/provider/user/netinfo.rb": private
> method
> `split'' called for nil:NilClass
>
> stuff.
>
> Any ideas?
Do you get any more useful information if you run it with --trace?

  --
  There is only one success - to be able to spend your life in your own
  way.        -- Christopher Morley
  ---------------------------------------------------------------------
  Luke Kanies | http://reductivelabs.com | http://madstop.com

Kevin Fox

2007-Mar-22 21:32 UTC

head link

Re: Parsechecking in a commit hook

On Thu, 2007-03-22 at 13:05 -0500, Luke Kanies wrote:> On Mar 22, 2007, at 11:30 AM, Kevin Fox wrote:
> > Sure. Maybe it should fallback to the system default in that case?
> 
> Except the system default is not writeable by root.
> 
> > Right now, it panics if it can''t find ~/ even if you manually
specify
> > confdir and vardir.
> 
> I''ll try to find a way to skip all of the configuration and just
do a
> parse test, since no configuration is necessary in this simple case.
> 
> >> The other problems you''re getting are because Puppet
tries to make
> >> sure it''s configured correctly, but you''ve told
it to use a directory
> >> it doesn''t have access to.  Until I get a fix for this
(which will
> >> probably just be a stand-alone command that''s only useful
for parse-
> >> checking and doesn''t do anything else), I recommend
setting --vardir
> >> and --confdir to something in /tmp, or some other explicit path
that
> >> this user has write access to.
> >
> > That fixed most of the problem, but I''m still getting the:
> >
> > Could not autoload
> > "/usr/lib/site_ruby/1.8/puppet/provider/user/netinfo.rb":
private
> > method
> > `split'' called for nil:NilClass
> >
> > stuff.
> >
> > Any ideas?
> 
> Do you get any more useful information if you run it with --trace?
Slightly, but I''m not very familiar with Ruby, so I''m not sure
where the
problem is. I''ll keep looking...

/usr/lib/site_ruby/1.8/puppet/util.rb:229:in `binary''
/usr/lib/site_ruby/1.8/puppet/provider.rb:45:in `commands''
/usr/lib/site_ruby/1.8/puppet/provider.rb:40:in `each''
/usr/lib/site_ruby/1.8/puppet/provider.rb:40:in `commands''
/usr/lib/site_ruby/1.8/puppet/provider/user/netinfo.rb:9
/usr/lib/site_ruby/1.8/puppet/util/classgen.rb:118:in `class_eval''
/usr/lib/site_ruby/1.8/puppet/util/classgen.rb:118:in `send''
/usr/lib/site_ruby/1.8/puppet/util/classgen.rb:118:in `genthing''
/usr/lib/site_ruby/1.8/puppet/util/classgen.rb:28:in `genclass''
/usr/lib/site_ruby/1.8/puppet/metatype/providers.rb:160:in `provide''
/usr/lib/site_ruby/1.8/puppet/provider/user/netinfo.rb:5
/usr/lib/site_ruby/1.8/puppet/util/autoload.rb:93:in `require''
/usr/lib/site_ruby/1.8/puppet/util/autoload.rb:93:in `loadall''
/usr/lib/site_ruby/1.8/puppet/util/autoload.rb:83:in `each''
/usr/lib/site_ruby/1.8/puppet/util/autoload.rb:83:in `loadall''
/usr/lib/site_ruby/1.8/puppet/util/autoload.rb:80:in `each''
/usr/lib/site_ruby/1.8/puppet/util/autoload.rb:80:in `loadall''
/usr/lib/site_ruby/1.8/puppet/metatype/manager.rb:117:in `newtype''
/usr/lib/site_ruby/1.8/puppet.rb:376:in `newtype''
/usr/lib/site_ruby/1.8/puppet/type/user.rb:6
/usr/lib/site_ruby/1.8/puppet/util/autoload.rb:56:in `load''
/usr/lib/site_ruby/1.8/puppet/util/autoload.rb:56:in `load''
/usr/lib/site_ruby/1.8/puppet/metatype/manager.rb:143:in `type''
/usr/lib/site_ruby/1.8/puppet.rb:381:in `type''
/usr/lib/site_ruby/1.8/puppet/metatype/relationships.rb:24:in
`autorequire''
/usr/lib/site_ruby/1.8/puppet/metatype/relationships.rb:14:in
`eachautorequire''
/usr/lib/site_ruby/1.8/puppet/metatype/relationships.rb:13:in `each''
/usr/lib/site_ruby/1.8/puppet/metatype/relationships.rb:13:in
`eachautorequire''
/usr/lib/site_ruby/1.8/puppet/metatype/relationships.rb:22:in
`autorequire''
/usr/lib/site_ruby/1.8/puppet/transaction.rb:503:in
`relationship_graph''
/usr/lib/site_ruby/1.8/puppet/transaction.rb:502:in `each''
/usr/lib/site_ruby/1.8/puppet/transaction.rb:502:in
`relationship_graph''
/usr/lib/site_ruby/1.8/puppet/transaction.rb:481:in `prepare''
/usr/lib/site_ruby/1.8/puppet/transaction.rb:304:in `evaluate''
/usr/lib/site_ruby/1.8/puppet/util/config.rb:621:in `use''
/usr/lib/ruby/1.8/sync.rb:229:in `synchronize''
/usr/lib/site_ruby/1.8/puppet/util/config.rb:588:in `use''
/usr/lib/site_ruby/1.8/puppet/network/client/master.rb:241:in
`initialize''
/usr/bin/puppet:183:in `new''
/usr/bin/puppet:183
Could not autoload
"/usr/lib/site_ruby/1.8/puppet/provider/user/netinfo.rb": private
method
`s
plit'' called for nil:NilClass
/usr/lib/site_ruby/1.8/puppet/util.rb:229:in `binary''
/usr/lib/site_ruby/1.8/puppet/provider.rb:45:in `commands''
/usr/lib/site_ruby/1.8/puppet/provider.rb:40:in `each''
/usr/lib/site_ruby/1.8/puppet/provider.rb:40:in `commands''
/usr/lib/site_ruby/1.8/puppet/provider/user/pw.rb:6
/usr/lib/site_ruby/1.8/puppet/util/classgen.rb:118:in `class_eval''
/usr/lib/site_ruby/1.8/puppet/util/classgen.rb:118:in `send''
/usr/lib/site_ruby/1.8/puppet/util/classgen.rb:118:in `genthing''
/usr/lib/site_ruby/1.8/puppet/util/classgen.rb:28:in `genclass''
/usr/lib/site_ruby/1.8/puppet/metatype/providers.rb:160:in `provide''
/usr/lib/site_ruby/1.8/puppet/provider/user/pw.rb:3
/usr/lib/site_ruby/1.8/puppet/util/autoload.rb:93:in `require''
/usr/lib/site_ruby/1.8/puppet/util/autoload.rb:93:in `loadall''
/usr/lib/site_ruby/1.8/puppet/util/autoload.rb:83:in `each''
/usr/lib/site_ruby/1.8/puppet/util/autoload.rb:83:in `loadall''
/usr/lib/site_ruby/1.8/puppet/util/autoload.rb:80:in `each''
/usr/lib/site_ruby/1.8/puppet/util/autoload.rb:80:in `loadall''
/usr/lib/site_ruby/1.8/puppet/metatype/manager.rb:117:in `newtype''
/usr/lib/site_ruby/1.8/puppet.rb:376:in `newtype''
/usr/lib/site_ruby/1.8/puppet/type/user.rb:6
/usr/lib/site_ruby/1.8/puppet/util/autoload.rb:56:in `load''
/usr/lib/site_ruby/1.8/puppet/util/autoload.rb:56:in `load''
/usr/lib/site_ruby/1.8/puppet/metatype/manager.rb:143:in `type''
/usr/lib/site_ruby/1.8/puppet.rb:381:in `type''
/usr/lib/site_ruby/1.8/puppet/metatype/relationships.rb:24:in
`autorequire''
/usr/lib/site_ruby/1.8/puppet/metatype/relationships.rb:14:in
`eachautorequire''
/usr/lib/site_ruby/1.8/puppet/metatype/relationships.rb:13:in `each''
/usr/lib/site_ruby/1.8/puppet/metatype/relationships.rb:13:in
`eachautorequire''
/usr/lib/site_ruby/1.8/puppet/metatype/relationships.rb:22:in
`autorequire''
/usr/lib/site_ruby/1.8/puppet/transaction.rb:503:in
`relationship_graph''
/usr/lib/site_ruby/1.8/puppet/transaction.rb:502:in `each''
/usr/lib/site_ruby/1.8/puppet/transaction.rb:502:in
`relationship_graph''
/usr/lib/site_ruby/1.8/puppet/transaction.rb:481:in `prepare''
/usr/lib/site_ruby/1.8/puppet/transaction.rb:304:in `evaluate''
/usr/lib/site_ruby/1.8/puppet/util/config.rb:621:in `use''
/usr/lib/ruby/1.8/sync.rb:229:in `synchronize''
/usr/lib/site_ruby/1.8/puppet/util/config.rb:588:in `use''
/usr/lib/site_ruby/1.8/puppet/network/client/master.rb:241:in
`initialize''
/usr/bin/puppet:183:in `new''
/usr/bin/puppet:183
Could not autoload
"/usr/lib/site_ruby/1.8/puppet/provider/user/pw.rb":
private method `split''
 called for nil:NilClass
/usr/lib/site_ruby/1.8/puppet/util.rb:229:in `binary''
/usr/lib/site_ruby/1.8/puppet/provider.rb:45:in `commands''
/usr/lib/site_ruby/1.8/puppet/provider.rb:40:in `each''
/usr/lib/site_ruby/1.8/puppet/provider.rb:40:in `commands''
/usr/lib/site_ruby/1.8/puppet/provider/user/useradd.rb:6
/usr/lib/site_ruby/1.8/puppet/util/classgen.rb:118:in `class_eval''
/usr/lib/site_ruby/1.8/puppet/util/classgen.rb:118:in `send''
/usr/lib/site_ruby/1.8/puppet/util/classgen.rb:118:in `genthing''
/usr/lib/site_ruby/1.8/puppet/util/classgen.rb:28:in `genclass''
/usr/lib/site_ruby/1.8/puppet/metatype/providers.rb:160:in `provide''
/usr/lib/site_ruby/1.8/puppet/provider/user/useradd.rb:3
/usr/lib/site_ruby/1.8/puppet/util/autoload.rb:93:in `require''
/usr/lib/site_ruby/1.8/puppet/util/autoload.rb:93:in `loadall''
/usr/lib/site_ruby/1.8/puppet/util/autoload.rb:83:in `each''
/usr/lib/site_ruby/1.8/puppet/util/autoload.rb:83:in `loadall''
/usr/lib/site_ruby/1.8/puppet/util/autoload.rb:80:in `each''
/usr/lib/site_ruby/1.8/puppet/util/autoload.rb:80:in `loadall''
/usr/lib/site_ruby/1.8/puppet/metatype/manager.rb:117:in `newtype''
/usr/lib/site_ruby/1.8/puppet.rb:376:in `newtype''
/usr/lib/site_ruby/1.8/puppet/type/user.rb:6
/usr/lib/site_ruby/1.8/puppet/util/autoload.rb:56:in `load''
/usr/lib/site_ruby/1.8/puppet/util/autoload.rb:56:in `load''


> 
>   --
>   There is only one success - to be able to spend your life in your own
>   way.        -- Christopher Morley
>   ---------------------------------------------------------------------
>   Luke Kanies | http://reductivelabs.com | http://madstop.com
> 
> 
> _______________________________________________
> Puppet-users mailing list
> Puppet-users@madstop.com
> https://mail.madstop.com/mailman/listinfo/puppet-users

Luke Kanies

2007-Mar-22 21:37 UTC

head link

Re: Parsechecking in a commit hook

On Mar 22, 2007, at 4:32 PM, Kevin Fox wrote:> /usr/lib/site_ruby/1.8/puppet/util.rb:229:in `binary''
Um, it looks like this hook is being called with no PATH.

Does SVN somehow not pass an environment at all to the hook?

  --
  If you would be a real seeker after truth, it is necessary that at
  least once in your life you doubt, as far as possible, all things.
          -- Rene Descartes
  ---------------------------------------------------------------------
  Luke Kanies | http://reductivelabs.com | http://madstop.com

Kevin Fox

2007-Mar-22 22:18 UTC

head link

Re: Parsechecking in a commit hook

On Thu, 2007-03-22 at 16:37 -0500, Luke Kanies wrote:> On Mar 22, 2007, at 4:32 PM, Kevin Fox wrote:
> > /usr/lib/site_ruby/1.8/puppet/util.rb:229:in `binary''
> 
> Um, it looks like this hook is being called with no PATH.
> 
> Does SVN somehow not pass an environment at all to the hook?
Apparently not. I manually set a PATH in the script and it seems to work
just fine now.

Thanks for all the help,
Kevin
> 
>   --
>   If you would be a real seeker after truth, it is necessary that at
>   least once in your life you doubt, as far as possible, all things.
>           -- Rene Descartes
>   ---------------------------------------------------------------------
>   Luke Kanies | http://reductivelabs.com | http://madstop.com
> 
> 
> _______________________________________________
> Puppet-users mailing list
> Puppet-users@madstop.com
> https://mail.madstop.com/mailman/listinfo/puppet-users

Luke Kanies

2007-Mar-22 22:23 UTC

head link

Re: Parsechecking in a commit hook

On Mar 22, 2007, at 5:18 PM, Kevin Fox wrote:>> Um, it looks like this hook is being called with no PATH.
>>
>> Does SVN somehow not pass an environment at all to the hook?
>
> Apparently not. I manually set a PATH in the script and it seems to  
> work
> just fine now.
>
> Thanks for all the help,
*whew* I''m glad to hear it works now.

Thanks.

  --
  He is indebted to his memory for his jests and to his imagination for
  his facts.                   --Richard Brinsley Sheridan
  ---------------------------------------------------------------------
  Luke Kanies | http://reductivelabs.com | http://madstop.com

Digant C Kasundra

2007-Mar-22 23:46 UTC

head link

Re: Parsechecking in a commit hook

> Apparently not. I manually set a PATH in the script and it seems to work
> just fine now.

So care to give us a gander at the resulting solution with a little how-to? 
I''d love to get this working for myself.

Kevin Fox

2007-Mar-27 16:28 UTC

head link

Re: Parsechecking in a commit hook

Sorry for the delay. Here''s a rough pre-commit script.

SVNLOOK=/usr/bin/svnlook
$SVNLOOK changed -t "$TXN" "$REPOS" | awk ''{print
$2}'' | grep ''\.pp$'' | while read line
do
	$SVNLOOK cat -t "$TXN" "$REPOS" "$line" >
/tmp/$$.pp
	if [ $? -ne 0 ]
	then
		echo "Failed to checkout $line" >&2
		exit 1
	fi
	puppet --confdir=/tmp --vardir=/tmp --parseonly --ignoreimport /tmp/$$.pp
>&2
	if [ $? -ne 0 ]
	then
		echo "Puppet syntax error in $line." >&2
		exit 2
	fi
done
res=$?
rm -f /tmp/$$.pp
if [ $res -ne 0 ]
then
	exit $res
fi
#do other checks here...
exit 0



On Thu, 2007-03-22 at 16:46 -0700, Digant C Kasundra
wrote:> > Apparently not. I manually set a PATH in the script and it seems to
work
> > just fine now.
> 
> 
> So care to give us a gander at the resulting solution with a little how-to?
> I''d love to get this working for myself.
> _______________________________________________
> Puppet-users mailing list
> Puppet-users@madstop.com
> https://mail.madstop.com/mailman/listinfo/puppet-users

Reasonably Related Threads

Search for more possibly parallel threads

Puppet users - Mar 2007 - Parsechecking in a commit hook

Parsechecking in a commit hook

Re: Parsechecking in a commit hook

Re: Parsechecking in a commit hook

Re: Parsechecking in a commit hook

Re: Parsechecking in a commit hook

Re: Parsechecking in a commit hook

Re: Parsechecking in a commit hook

Re: Parsechecking in a commit hook

Re: Parsechecking in a commit hook

Re: Parsechecking in a commit hook

Re: Parsechecking in a commit hook

Re: Parsechecking in a commit hook

Reasonably Related Threads