Pkg xen devel - Mar 2021 - Bug#983862: PVH -- cannot remove vm with pci passthrough

Package: xen-utils-4.11
Version: 4.11.4+57-g41a822c392-2
Severity: minor

Dear maintainers,

we, by accident, added a pci passthrough device config to a pvh vm and were
able to boot that machine. But shutdown did not work with the following
error message:
  | xl: libxl_pci.c:1427: do_pci_remove: Assertion `type ==
LIBXL_DOMAIN_TYPE_PV' failed.
To remove the virtual machine and free its resources a reboot of Dom0 was
necessary. A corresponding assert when creating the machine seems to be
missing.
We consider this to be a bug, because we should not have been able to 'xl
create' that machine in the first place (or would have needed a way to
dispose the vm).

best regards,
    Adi Kriegisch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL:
<http://alioth-lists.debian.net/pipermail/pkg-xen-devel/attachments/20210302/17d90c15/attachment.sig>

reassign 983862 src:xen 4.11.4+57-g41a822c392-2
tags 983862 + upstream
thanks

Hi Adi!

On 3/2/21 12:46 PM, Adi Kriegisch wrote:
> Package: xen-utils-4.11
> Version: 4.11.4+57-g41a822c392-2
> Severity: minor
> 
> Dear maintainers,
> 
> we, by accident, added a pci passthrough device config to a pvh vm and were
> able to boot that machine. But shutdown did not work with the following
> error message:
>   | xl: libxl_pci.c:1427: do_pci_remove: Assertion `type ==
LIBXL_DOMAIN_TYPE_PV' failed.
> To remove the virtual machine and free its resources a reboot of Dom0 was
> necessary. A corresponding assert when creating the machine seems to be
> missing.
> We consider this to be a bug, because we should not have been able to
'xl
> create' that machine in the first place (or would have needed a way to
> dispose the vm).
Aha. Interesting. I just had a look at libxl_pci.c in the latest
upstream code, and I think the same bug still exists.

PCI passthrough is still not supported for PVH, so it should refuse, a
bit higher up in the call stack. Probably not with an assert, but with a
nice error message. :)

I think I'm going to have a closer look at it somewhere in the next week.

Note that the bug fix will not reach Xen 4.11 (or our package) any more.

Regards,
Hans van Kranenburg