Pkg xen devel - Dec 2020 - [PATCH 8/9] debian/scripts: Optimize runtime scripts

On maandag 21 september 2020 06:28:53 CET Elliott Mitchell
wrote:
> +read type < /sys/hypervisor/type
> +if [ "$type" != xen ]; then
You should quote 'xen' here too
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL:
<http://alioth-lists.debian.net/pipermail/pkg-xen-devel/attachments/20201201/d9dfe8d4/attachment.sig>

On Tue, Dec 01, 2020 at 04:09:58PM +0100, Diederik de Haas
wrote:
> On maandag 21 september 2020 06:28:53 CET Elliott Mitchell wrote:
> > +read type < /sys/hypervisor/type
> > +if [ "$type" != xen ]; then
> 
> You should quote 'xen' here too
That is a style choice and I may find I agree in the future.  Right now
though "xen" is a *constant* string with no spaces or interesting
characters, so quoting is completely unnecessary.


-- 
(\___(\___(\______          --=> 8-) EHM <=--          ______/)___/)___/)
 \BS (    |         ehem+sigmsg at m5p.com  PGP 87145445         |    )   /
  \_CS\   |  _____  -O #include <stddisclaimer.h> O-   _____  |   /  _/
8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445