Pkg xen devel - Sep 2019 - Bug#939560: xen: Various problems in debian/rules

Source: xen
Source-Version: 4.11.1+92-g6c33308a8d-2
Severity: normal

Hi!

During the debhelper recommendation thread there was a mail from Ian
pointing out to the xen debian/rules file, I took a look and noticed
the following. :)

The debian/rules file is setting DEB_BUILD_MAINT_OPTIONS with export
to enable all hardening features. Subsequently it sets various build
flags via a $(shell ) make construct, which is known to be unable to
take export'ed make variables into account.

This means the non-default options will not get enabled. The correct
way to do this is to set the variables explicitly in $(shell ) calls
or alternatively the easier way might be to use dpkg's buildflags.mk
make fragment, which already deals with this.

(While we are at it, the reason the hardening option does not enable
all features by default, is because some might incur silent breakage
which would not be acceptable to enable by default w/o involving the
maintainer. There's also a trailing x on that comment, also there is
s/it other/in other/ in another comment. :)

The dh_installinit calls include update-rc.d arguments for runlevels
which end up producing warnings at configure time. This are unneeded
and can be safely removed, these are already covered by the LSB init
metadata.

Thanks,
Guillem

Hi Guillem,

On 9/6/19 12:55 PM, Guillem Jover wrote:
> [...]
> 
> During the debhelper recommendation thread there was a mail from Ian
> pointing out to the xen debian/rules file, I took a look and noticed
> the following. :)
> 
> The debian/rules file [...]
Thanks for the report! The fixes will be in the new Xen 4.13 packages,
which are going to be in experimental very soon and in unstable in a few
weeks, hopefully (we need users to upgrade to the last 4.11 package for
an upgrade fix regarding #932759).

If you would like to review the changes, it's the three commits by Ian,
named...
- debian/rules: Set DEB_BUILD_MAINT_OPTIONS in shell
- debian/rules: Improve comment about hardening options
- debian/rules: Drop redundant sequence numbers in dh_installinit

...which you can find at:
  https://salsa.debian.org/xen-team/debian-xen/-/commits/knorrie/4.13

I'm still finishing up all of that, so can't give commit ids because of
the force-pushing going on.

Thanks,
Hans

Your message dated Mon, 21 Sep 2020 10:00:33 +0000
with message-id <E1kKIcb-000Iws-9o at fasolo.debian.org>
and subject line Bug#939560: fixed in xen 4.14.0-1~exp1
has caused the Debian Bug report #939560,
regarding xen: Various problems in debian/rules
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner at bugs.debian.org
immediately.)


-- 
939560: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=939560
Debian Bug Tracking System
Contact owner at bugs.debian.org with problems
-------------- next part --------------
An embedded message was scrubbed...
From: Guillem Jover <guillem at debian.org>
Subject: xen: Various problems in debian/rules
Date: Fri, 6 Sep 2019 12:55:15 +0200
Size: 2990
URL:
<http://alioth-lists.debian.net/pipermail/pkg-xen-devel/attachments/20200921/1651fc42/attachment-0002.mht>
-------------- next part --------------
An embedded message was scrubbed...
From: Debian FTP Masters <ftpmaster at ftp-master.debian.org>
Subject: Bug#939560: fixed in xen 4.14.0-1~exp1
Date: Mon, 21 Sep 2020 10:00:33 +0000
Size: 19814
URL:
<http://alioth-lists.debian.net/pipermail/pkg-xen-devel/attachments/20200921/1651fc42/attachment-0003.mht>