Pkg xen devel - Jan 2019 - Bug#911045: xen-hypervisor should declare Breaks

Package: xenstore-utils
Version: 4.11.1~pre.20180911.5acdd26fdc+dfsg-3
Severity: serious
User: debian-qa at lists.debian.org
Usertags: piuparts replaces-without-breaks

Hi,

during a test with piuparts and DOSE tools I noticed your package causes
removal of files that also belong to another package.
This is caused by using Replaces without corresponding Breaks.

The installation sequence to reproduce this problem is

  apt-get install xen-utils-common/stretch
  # (1)
  apt-get install xenstore-utils/sid
  apt-get remove xenstore-utils
  # (2)

The list of installed files at points (1) and (2) should be identical,
but the following files have disappeared:

  /usr/share/man/man1/xenstore-chmod.1.gz
  /usr/share/man/man1/xenstore-ls.1.gz
  /usr/share/man/man1/xenstore.1.gz

This is a serious bug violating policy 7.6, see
https://www.debian.org/doc/debian-policy/ch-relationships.html#overwriting-files-and-replacing-packages-replaces
and also see the footnote that describes this incorrect behavior:
https://www.debian.org/doc/debian-policy/ch-relationships.html#id13

The xenstore-utils package has the following relationships with
xen-utils-common:

  Conflicts: n/a
  Breaks:    n/a
  Replaces:  xen-utils-common (<= 4.11.1~pre+1.733450b39b-1~)
>From the attached log (scroll to the bottom...):
3m53.7s ERROR: FAIL: After purging files have disappeared:
  /usr/share/man/man1/xenstore-chmod.1.gz        owned by: xenstore-utils
  /usr/share/man/man1/xenstore-ls.1.gz   owned by: xenstore-utils
  /usr/share/man/man1/xenstore.1.gz      owned by: xenstore-utils

3m53.7s ERROR: FAIL: After purging files have been modified:
  /var/lib/dpkg/info/xen-utils-common.list       not owned


cheers,

Andreas
-------------- next part --------------
A non-text attachment was scrubbed...
Name:
xen-utils-common=4.8.3+xsa267+shim4.10.1+xsa267-1+deb9u9_xenstore-utils=4.11.1~pre.20180911.5acdd26fdc+dfsg-3.log.gz
Type: application/gzip
Size: 10273 bytes
Desc: not available
URL:
<http://alioth-lists.debian.net/pipermail/pkg-xen-devel/attachments/20181015/9fcd0c04/attachment.gz>

> The installation sequence to reproduce this problem is
> 
>   apt-get install xen-utils-common/stretch
>   # (1)
>   apt-get install xenstore-utils/sid
>   apt-get remove xenstore-utils
>   # (2)
But this is not possible because xen-utils-common Depends on
xenstore-utils (even in stretch).  You could in theory upgrade only
xenstore-utils and then downgrade it again, to make the files
disappear, but I don't think that is supported.  And in practice
no-one would do that.

So I don't think this is a bug we care about.

Ian.

-- 
Ian Jackson <ijackson at chiark.greenend.org.uk>   These opinions are my
own.

If I emailed you from an address @fyvzl.net or @evade.org.uk, that is
a private address which bypasses my fierce spamfilter.

Ian Jackson writes ("Re: xenstore-utils: removal of xenstore-utils makes
files disappear from xen-utils-common"):
> > The installation sequence to reproduce this problem is
> > 
> >   apt-get install xen-utils-common/stretch
> >   # (1)
> >   apt-get install xenstore-utils/sid
> >   apt-get remove xenstore-utils
> >   # (2)
> 
> But this is not possible because xen-utils-common Depends on
> xenstore-utils (even in stretch).  You could in theory upgrade only
> xenstore-utils and then downgrade it again, to make the files
> disappear, but I don't think that is supported.  And in practice
> no-one would do that.
> 
> So I don't think this is a bug we care about.
Indeed I looked at the log and it does show a downgrade, not a
removal, of xenstore-utils.

Ian.

-- 
Ian Jackson <ijackson at chiark.greenend.org.uk>   These opinions are my
own.

If I emailed you from an address @fyvzl.net or @evade.org.uk, that is
a private address which bypasses my fierce spamfilter.

Control: severity -1 normal
Control: retitle -1 xenstore-utils should declare Breaks old xen-utils-common

Ian Jackson writes ("Re: xenstore-utils: removal of xenstore-utils makes
files disappear from xen-utils-common"):
> Indeed I looked at the log and it does show a downgrade, not a
> removal, of xenstore-utils.
As discussed, I don't think this is an RC bug.  We should improve it
though at some point, by adding a Breaks, as that is straightforward.

Ian.

-- 
Ian Jackson <ijackson at chiark.greenend.org.uk>   These opinions are my
own.

If I emailed you from an address @fyvzl.net or @evade.org.uk, that is
a private address which bypasses my fierce spamfilter.

Processing control commands:
> severity -1 normal
Bug #911045 [xenstore-utils] xenstore-utils: removal of xenstore-utils makes
files disappear from xen-utils-common
Severity set to 'normal' from 'serious'
> retitle -1 xenstore-utils should declare Breaks old xen-utils-common
Bug #911045 [xenstore-utils] xenstore-utils: removal of xenstore-utils makes
files disappear from xen-utils-common
Changed Bug title to 'xenstore-utils should declare Breaks old
xen-utils-common' from 'xenstore-utils: removal of xenstore-utils makes
files disappear from xen-utils-common'.

-- 
911045: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=911045
Debian Bug Tracking System
Contact owner at bugs.debian.org with problems

Processing control commands:
> severity -1 normal
Bug #911045 [xenstore-utils] xenstore-utils should declare Breaks old
xen-utils-common
Ignoring request to change severity of Bug 911045 to the same
value.
> retitle -1 xenstore-utils should declare Breaks old xen-utils-common
Bug #911045 [xenstore-utils] xenstore-utils should declare Breaks old
xen-utils-common
Ignoring request to change the title of bug#911045 to the same title

-- 
911045: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=911045
Debian Bug Tracking System
Contact owner at bugs.debian.org with problems

Followup-For: Bug #911045

Similar problems in xen-hypervisor-common:
it takes over /etc/default/grub.d/xen.cfg from xen-hypervisor-4.8-amd64
(stretch) without proper package relationships.
Does this affect other platforms as well?


Andreas

tags 911045 + wontfix
thanks

Hi,

Like Ian said, the upgrade scenario here is to install the new Xen
hypervisor packages, then reboot. If something horrible happens, it's
possible to boot again with the previous Xen and try fix it and retry
the reboot. If successful, remove the 4.8-related packages.

So, the addition of a Breaks that will forcibly remove the 4.8
hypervisor boot option here is not in the interest of the end user at all.

I nonetheless fully agree that there has been a mistake made in the past
by having the grub.d/xen.cfg been addded into the hypervisor
version-specific package, instead of a -common one.

-- 
Hans van Kranenburg

Processing commands for control at bugs.debian.org:
> tags 911045 + wontfix
Bug #911045 [xenstore-utils] xenstore-utils should declare Breaks old
xen-utils-common
Added tag(s) wontfix.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
911045: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=911045
Debian Bug Tracking System
Contact owner at bugs.debian.org with problems

tags 911045 + pending
thanks

Ok, now this is confusing. For a moment I was thinking that this bug was
cloned because of the "Similar problems in..." and then I couldn't
find
the other one.

I just added the Breaks for xenstore-utils jftfoi, so this one is now
both wontfix and pending.

https://salsa.debian.org/xen-team/debian-xen/commit/a8ba67214681b6c5a5d7486550585116f1690ed0

Hans

Processing commands for control at bugs.debian.org:
> tags 911045 + pending
Bug #911045 [xenstore-utils] xenstore-utils should declare Breaks old
xen-utils-common
Added tag(s) pending.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
911045: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=911045
Debian Bug Tracking System
Contact owner at bugs.debian.org with problems

Your message dated Fri, 22 Feb 2019 16:37:31 +0000
with message-id <E1gxDpL-000AIg-LZ at fasolo.debian.org>
and subject line Bug#911045: fixed in xen 4.11.1+26-g87f51bf366-2
has caused the Debian Bug report #911045,
regarding xenstore-utils should declare Breaks old xen-utils-common
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner at bugs.debian.org
immediately.)


-- 
911045: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=911045
Debian Bug Tracking System
Contact owner at bugs.debian.org with problems
-------------- next part --------------
An embedded message was scrubbed...
From: Andreas Beckmann <anbe at debian.org>
Subject: xenstore-utils: removal of xenstore-utils makes files disappear from
xen-utils-common
Date: Mon, 15 Oct 2018 07:03:48 +0200
Size: 17935
URL:
<http://alioth-lists.debian.net/pipermail/pkg-xen-devel/attachments/20190222/d6aa3ea1/attachment-0002.mht>
-------------- next part --------------
An embedded message was scrubbed...
From: Ian Jackson <ijackson at chiark.greenend.org.uk>
Subject: Bug#911045: fixed in xen 4.11.1+26-g87f51bf366-2
Date: Fri, 22 Feb 2019 16:37:31 +0000
Size: 19124
URL:
<http://alioth-lists.debian.net/pipermail/pkg-xen-devel/attachments/20190222/d6aa3ea1/attachment-0003.mht>