Pkg xen devel - Oct 2018 - Bug#865086: Bug#865086: xen-hypervisor-4.8-amd64: Default grub entry broken with locales (how to reproduce)

Package: src:xen
Version: 4.8.1-1+deb9u1
Severity: important

/etc/default/grub.d/xen.cfg contains an override for grub to select Xen
hypervisor as default, but this may not match when grub configuration is
generated with some locale.



-- System Information:
Debian Release: 9.0
  APT prefers testing
  APT policy: (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-3-amd64 (SMP w/4 CPU cores)
Locale: LANG=hu_HU.UTF-8, LC_CTYPE=hu_HU.UTF-8 (charmap=UTF-8),
LANGUAGE=hu_HU.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

xen-hypervisor-4.8-amd64 depends on no packages.

Versions of packages xen-hypervisor-4.8-amd64 recommends:
ii  xen-utils-4.8  4.8.1-1+deb9u1

xen-hypervisor-4.8-amd64 suggests no packages.

-- no debconf information

Package: xen-hypervisor-4.8-amd64
Version: stretch
Followup-For: Bug #865086

Hello,

On stretch this error occurs again.
Patch provided is perfect to solve  this problem with locales

Thanks a lot



-- System Information:
Debian Release: 9.1
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable'), (90,
'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-3-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.utf8, LC_CTYPE=fr_FR.utf8 (charmap=UTF-8),
LANGUAGE=fr_FR.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

xen-hypervisor-4.8-amd64 depends on no packages.

Versions of packages xen-hypervisor-4.8-amd64 recommends:
pn  xen-utils-4.8  <none>

xen-hypervisor-4.8-amd64 suggests no packages.

On 12.09.2017 10:26, km wrote:
> Package: xen-hypervisor-4.8-amd64
> Version: stretch
> Followup-For: Bug #865086
> 
> Hello,
> 
> On stretch this error occurs again.
> Patch provided is perfect to solve  this problem with locales
> 
On Ubuntu I started using a slightly modified variant which should be working on
Debian and Ubuntu (by using an environment variable set by the update-grub
call):

if [ "$XEN_OVERRIDE_GRUB_DEFAULT" = "1" ]; then
        GRUB_DEFAULT=$( \
                printf "$(gettext "%s, with Xen
hypervisor")" \
                "$GRUB_DISTRIBUTOR GNU/Linux")
fi

This is the same as in the generator in /etc/grub.d.
-Stefan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL:
<http://lists.alioth.debian.org/pipermail/pkg-xen-devel/attachments/20170912/0ec3f399/attachment.sig>

Hi,

Can anyone explain me how I can reproduce this failure, and how exactly
I can verify the fix? From a QA POV I'd like to verify this before
applying. I don't have a lot of experience with gettext.

What I did to test is (buster dom0 with latest xen 4.11 from unstable):

-# dpkg-reconfigure locales
   -> also select nl_NL.UTF-8 UTF-8
   -> choose nl_NL.UTF-8 as default instead of en_US.UTF-8

-# apt-get update
[...]
10,9 kB opgehaald in 1s (7523 B/s)
Pakketlijsten worden ingelezen... Klaar

Ok, that looks dutch.

-# update-grub
Generating grub configuration file ...
[...]
done

-# grep Xen /boot/grub/grub.cfg |sed 's/ --class.*//;s/\$menuentry.*//'
   set default="Debian GNU/Linux, with Xen hypervisor"
menuentry 'Debian GNU/Linux, with Xen hypervisor'
	echo	'Loading Xen 4.11-amd64 ...'
submenu 'Advanced options for Debian GNU/Linux (with Xen hypervisor)'
	submenu 'Xen hypervisor, version 4.11-amd64'
		menuentry 'Debian GNU/Linux, with Xen 4.11-amd64 and Linux
4.18.0-2-amd64'
			echo	'Loading Xen 4.11-amd64 ...'
		menuentry 'Debian GNU/Linux, with Xen 4.11-amd64 and Linux
4.18.0-1-amd64'
			echo	'Loading Xen 4.11-amd64 ...'
	submenu 'Xen hypervisor, version 4.11-amd64.efi'
		menuentry 'Debian GNU/Linux, with Xen 4.11-amd64.efi and Linux
4.18.0-2-amd64'
			echo	'Loading Xen 4.11-amd64.efi ...'
		menuentry 'Debian GNU/Linux, with Xen 4.11-amd64.efi and Linux
4.18.0-1-amd64'
			echo	'Loading Xen 4.11-amd64.efi ...'
	submenu 'Xen hypervisor, version 4.11-amd64.config'
		menuentry 'Debian GNU/Linux, with Xen 4.11-amd64.config and Linux
4.18.0-2-amd64'
			echo	'Loading Xen 4.11-amd64.config ...'
		menuentry 'Debian GNU/Linux, with Xen 4.11-amd64.config and Linux
4.18.0-1-amd64'
			echo	'Loading Xen 4.11-amd64.config ...'

So, as a result of applying this patch, I would like to see all of this
translated in Dutch.

At this point, the first thing I want to test is if I can see that the
gettext commands give me dutch output for things:

-# env |grep LANG
LANG=nl_NL.UTF-8

-# printf "$(gettext "%s, with Xen hypervisor")"
"Debian GNU/Linux"
Debian GNU/Linux, with Xen hypervisor

-# dpkg -L grub-common |grep -i nl
/usr/share/locale/nl
/usr/share/locale/nl/LC_MESSAGES
/usr/share/locale/nl/LC_MESSAGES/grub.mo

-# strings /usr/share/locale/nl/LC_MESSAGES/grub.mo |grep Xen
%s, with Xen %s and Linux %s
%s, with Xen hypervisor
Advanced options for %s (with Xen hypervisor)
Check if FILE can be booted as i386 PAE Xen unprivileged guest kernel
Check if FILE can be booted as x86_64 Xen unprivileged guest kernel
Check if FILE can be used as Xen x86 privileged guest kernel
List Xen storage.
Loading Xen %s ...
Xen hypervisor, version %s
you need to load the Xen Hypervisor first
%s, met Xen %s en Linux %s
%s, met Xen-hypervisor
Geavanceerde opties voor %s (met Xen-hypervisor)
Controleren of BESTAND als ongeprivilegieerde i386-PAE-Xen-gast-kernel
gestart kan worden
Controleren of BESTAND als ongeprivilegieerde x86_64-Xen-gast-kernel
gestart kan worden
Controleren of BESTAND als geprivilegieerde x86-Xen-gast-kernel gebruikt
kan worden
Xen-opslag tonen.
Een Xen-hypervisor laden.
Een Xen-module laden.
Laden van Xen %s...
Xen-hypervisor, versie %s
u dient eerst de Xen-hypervisor te laden

Ok, so those are the translations that I can get...

What am I doing wrong, so that the first test already doesn't give me:
"Debian GNU/Linux, met Xen-hypervisor"

Thanks,
Hans

Hans van Kranenburg writes ("[Pkg-xen-devel] Bug#865086:
xen-hypervisor-4.8-amd64: Default grub entry broken with locales (how to
reproduce)"):
> What am I doing wrong, so that the first test already doesn't give me:
> "Debian GNU/Linux, met Xen-hypervisor"
You are missing the -d option to gettext.

root at thule:~# LANGUAGE=nl_NL.UTF-8 LANG=nl_NL.UTF-8 gettext -d grub '%s,
with Xen hypervisor'; echo
%s, met Xen-hypervisor
root at thule:~# LANGUAGE=nl_NL.UTF-8 LANG=nl_NL.UTF-8 TEXTDOMAIN=grub gettext
'%s, with Xen hypervisor'; echo
%s, met Xen-hypervisor

To reproduce the bug you have to not have GRUB_TERMINAL set (or set to
`gfxterm'), because grub-mkconfig thinks that other GRUB_TERMINAL
values including `serial' preclude non-ASCII characters, and that
causes it to set LANG=C.  (Look in /etc/default/grub.)

Ian.

tags 865086 pending
thanks

On 10/26/18 2:26 PM, Ian Jackson wrote:
> Hans van Kranenburg writes ("[Pkg-xen-devel] Bug#865086:
xen-hypervisor-4.8-amd64: Default grub entry broken with locales (how to
reproduce)"):
>> What am I doing wrong, so that the first test already doesn't give
me:
>> "Debian GNU/Linux, met Xen-hypervisor"
> 
> You are missing the -d option to gettext.
> 
> root at thule:~# LANGUAGE=nl_NL.UTF-8 LANG=nl_NL.UTF-8 gettext -d grub
'%s, with Xen hypervisor'; echo
> %s, met Xen-hypervisor
> root at thule:~# LANGUAGE=nl_NL.UTF-8 LANG=nl_NL.UTF-8 TEXTDOMAIN=grub
gettext '%s, with Xen hypervisor'; echo
> %s, met Xen-hypervisor
Ah, thanks. It needs to know in what translation file it has to search,
that makes sense yes.
> To reproduce the bug you have to not have GRUB_TERMINAL set (or set to
> `gfxterm'), because grub-mkconfig thinks that other GRUB_TERMINAL
> values including `serial' preclude non-ASCII characters, and that
> causes it to set LANG=C.  (Look in /etc/default/grub.)
Aha! That explains.

I have ..

GRUB_TERMINAL="serial console"
GRUB_SERIAL_COMMAND="serial --unit=1 --speed=115200 --word=8 --parity=no
--stop=1"

..and that's why update-grub still shows me messages in english etc, and
the end result is not translated.

If I comment this, then:

-# update-grub
Including Xen overrides from /etc/default/grub.d/xen.cfg
WARNING: GRUB_DEFAULT changed to boot into Xen by default!
         Edit /etc/default/grub.d/xen.cfg to avoid this warning.
Aanmaken van GRUB-configuratiebestand...
Linux-image gevonden: /boot/vmlinuz-4.18.0-2-amd64
Initiële RAM-schijf-image gevonden: /boot/initrd.img-4.18.0-2-amd64
Linux-image gevonden: /boot/vmlinuz-4.18.0-1-amd64
Initiële RAM-schijf-image gevonden: /boot/initrd.img-4.18.0-1-amd64
Linux-image gevonden: /boot/vmlinuz-4.18.0-2-amd64
Initiële RAM-schijf-image gevonden: /boot/initrd.img-4.18.0-2-amd64
Linux-image gevonden: /boot/vmlinuz-4.18.0-1-amd64
Initiële RAM-schijf-image gevonden: /boot/initrd.img-4.18.0-1-amd64
Linux-image gevonden: /boot/vmlinuz-4.18.0-2-amd64
Initiële RAM-schijf-image gevonden: /boot/initrd.img-4.18.0-2-amd64
Linux-image gevonden: /boot/vmlinuz-4.18.0-1-amd64
Initiële RAM-schijf-image gevonden: /boot/initrd.img-4.18.0-1-amd64
Linux-image gevonden: /boot/vmlinuz-4.18.0-2-amd64
Initiële RAM-schijf-image gevonden: /boot/initrd.img-4.18.0-2-amd64
Linux-image gevonden: /boot/vmlinuz-4.18.0-1-amd64
Initiële RAM-schijf-image gevonden: /boot/initrd.img-4.18.0-1-amd64
voltooid

...and...

-# grep Xen /boot/grub/grub.cfg |sed 's/ --class.*//;s/\$menuentry.*//'
   set default="Debian GNU/Linux, with Xen hypervisor"
menuentry 'Debian GNU/Linux, met Xen-hypervisor'
	echo	'Laden van Xen 4.11-amd64...'
submenu 'Geavanceerde opties voor Debian GNU/Linux (met Xen-hypervisor)'
	submenu 'Xen-hypervisor, versie 4.11-amd64'
		menuentry 'Debian GNU/Linux, met Xen 4.11-amd64 en Linux
4.18.0-2-amd64'
			echo	'Laden van Xen 4.11-amd64...'
		menuentry 'Debian GNU/Linux, met Xen 4.11-amd64 en Linux
4.18.0-1-amd64'
			echo	'Laden van Xen 4.11-amd64...'
	submenu 'Xen-hypervisor, versie 4.11-amd64.efi'
		menuentry 'Debian GNU/Linux, met Xen 4.11-amd64.efi en Linux
4.18.0-2-amd64'
			echo	'Laden van Xen 4.11-amd64.efi...'
		menuentry 'Debian GNU/Linux, met Xen 4.11-amd64.efi en Linux
4.18.0-1-amd64'
			echo	'Laden van Xen 4.11-amd64.efi...'
	submenu 'Xen-hypervisor, versie 4.11-amd64.config'
		menuentry 'Debian GNU/Linux, met Xen 4.11-amd64.config en Linux
4.18.0-2-amd64'
			echo	'Laden van Xen 4.11-amd64.config...'
		menuentry 'Debian GNU/Linux, met Xen 4.11-amd64.config en Linux
4.18.0-1-amd64'
			echo	'Laden van Xen 4.11-amd64.config...'


So, everything is translated. Well, except the "Including Xen overrides
from" things.

And now I understand the patch, and it totally makes sense to me.

Applied.

Hans

Processing commands for control at bugs.debian.org:
> tags 865086 pending
Bug #865086 [src:xen] xen-hypervisor-4.8-amd64: Default grub entry broken with
locales
Added tag(s) pending.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
865086: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=865086
Debian Bug Tracking System
Contact owner at bugs.debian.org with problems

Your message dated Thu, 10 Jan 2019 16:08:23 +0000
with message-id <E1ghcsZ-0007To-FI at fasolo.debian.org>
and subject line Bug#865086: fixed in xen 4.11.1-1
has caused the Debian Bug report #865086,
regarding xen-hypervisor-4.8-amd64: Default grub entry broken with locales
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner at bugs.debian.org
immediately.)


-- 
865086: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=865086
Debian Bug Tracking System
Contact owner at bugs.debian.org with problems
-------------- next part --------------
An embedded message was scrubbed...
From: Richard Kojedzinszky <kojedzinszky.richard at euronetrt.hu>
Subject: xen-hypervisor-4.8-amd64: Default grub entry broken with locales
Date: Mon, 19 Jun 2017 09:08:25 +0200
Size: 3085
URL:
<http://alioth-lists.debian.net/pipermail/pkg-xen-devel/attachments/20190110/021aeff2/attachment-0002.mht>
-------------- next part --------------
An embedded message was scrubbed...
From: Hans van Kranenburg <hans at knorrie.org>
Subject: Bug#865086: fixed in xen 4.11.1-1
Date: Thu, 10 Jan 2019 16:08:23 +0000
Size: 16007
URL:
<http://alioth-lists.debian.net/pipermail/pkg-xen-devel/attachments/20190110/021aeff2/attachment-0003.mht>