Pkg xen devel - Jan 2012 - Comments regarding xen-api_1.3-14_amd64.changes

Hi,

it seems python files in python-xenapi package aren't byte-compiled
properly.
You may want to refine dh_python2 call to fix that.

Cheers,
Luca

On 01/07/2012 08:44 PM, Luca Falavigna wrote:
> Hi,
> 
> it seems python files in python-xenapi package aren't byte-compiled
properly.
> You may want to refine dh_python2 call to fix that.
> 
> Cheers,
> Luca
Hi Luca,

Good catch, thanks for noticing it and letting me know! I was doing
"dh_python2 /usr/lib/xcp", thinking that dh_python2 would only take
that
folder as a supplementary one, but in fact, it seems that when I do
that, dh_python2 doesn't look anymore in /usr/lib/python*.

Frankly, I think this is an issue in the man page of dh_python2 which
doesn't explain how it works correctly. I've been staring at the man
page trying to guess what would happen, and here, miserably failed
(truth, I should have double checked the result, but still...).

Now, my understanding of the man page is that I should have done:

override_dh_python2:
	dh_python2
	dh_python2 --skip-private /usr/lib/xcp

Best would have been to explicitly write that one example in the man
page, IMHO (see patch attached). Please let me know if I'm wrong here.

I'm Cc:-ing debian-python at lists.debian.org and doko (current maintainer
for python) hoping that the man page can be fixed and such explicit
example added.

Cheers,

Thomas

P.S: There was other issues on this xen-api package that also pushed me
for another upload (like python-xenapi should have Replaces: xcp-xapi).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dh_python2.rst.patch
Type: text/x-diff
Size: 592 bytes
Desc: not available
URL:
<http://lists.alioth.debian.org/pipermail/pkg-xen-devel/attachments/20120108/2e8311d2/attachment.patch>

[Thomas Goirand, 2012-01-08]
> override_dh_python2:
> 	dh_python2
> 	dh_python2 --skip-private /usr/lib/xcp

override_dh_python2:
 	dh_python2
 	dh_python2 /usr/lib/xcp

is the way to go (assuming "xcp" is *not* binary package name,
otherwise
extra call is not needed at all). dh_python2 is checking some private
directories by default (see manpage for details) - if you want to use
different options for these directories (f.e. if public modules support
Python >= 2.4 and private ones Python >= 2.6), use --skip-private like
this:

override_dh_python2:
 	dh_python2 --skip-private
 	dh_python2 /usr/lib/xcp

(assuming "xcp" is binary package name)
-- 
Piotr O?arowski                         Debian GNU/Linux Developer
www.ozarowski.pl          www.griffith.cc           www.debian.org
GPG Fingerprint: 1D2F A898 58DA AF62 1786 2DF7 AEF6 F1A2 A745 7645