Marvin Renich
2010-Jul-15 14:50 UTC
[Pkg-xen-devel] Bug#589176: xen-utils-common: replace gawk with awk in scripts and Depends
Package: xen-utils-common Version: 4.0.0-1 Severity: wishlist Tags: patch I am not a gawk/mawk expert, but I looked carefully at the few uses of gawk that I saw in /etc/xen/scripts/vtpm-common.sh and network-bridge, and I did not see anything that was gawk-specific. It would be nice if they could be changed to awk and the dependency on gawk removed. base-files is Essential: yes and it PreDepends: awk. I am not sure, but I think this means that other packages do not need an explicit Depends: awk. The attached patch does not modify debian/control, but it replaces gawk with awk in the above two named scripts. I have not tested the changes in context, as I have no idea what vtpm is, and can't put network bridge through normal use until bug 588888 is solved, but I did test the change from network-bridge manually by extracting the pipeline where gawk was used and trying it with both gawk and mawk and comparing the results. ...Marvin -- System Information: Debian Release: squeeze/sid APT prefers testing APT policy: (990, 'testing'), (500, 'unstable'), (500, 'stable') Architecture: amd64 (x86_64) Kernel: Linux 2.6.32-5-amd64 (SMP w/2 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages xen-utils-common depends on: ii gawk 1:3.1.7.dfsg-5 GNU awk, a pattern scanning and pr ii lsb-base 3.2-23.1 Linux Standard Base 3.2 init scrip ii udev 158-1 /dev/ and hotplug management daemo ii xenstore-utils 4.0.1~rc3-1 Xenstore utilities for Xen xen-utils-common recommends no packages. xen-utils-common suggests no packages. -- no debconf information -------------- next part -------------- A non-text attachment was scrubbed... Name: xen-common-4.0.0-mrvn.patch Type: text/x-diff Size: 2617 bytes Desc: not available URL: <http://lists.alioth.debian.org/pipermail/pkg-xen-devel/attachments/20100715/3061d461/attachment.patch>
Thomas Goirand
2010-Jul-15 19:07 UTC
[Pkg-xen-devel] Bug#589176: Bug#589176: xen-utils-common: replace gawk with awk in scripts and Depends
Marvin Renich wrote:> Package: xen-utils-common > Version: 4.0.0-1 > Severity: wishlist > Tags: patch > > I am not a gawk/mawk expert, but I looked carefully at the few uses of > gawk that I saw in /etc/xen/scripts/vtpm-common.sh and network-bridge, > and I did not see anything that was gawk-specific. It would be nice if > they could be changed to awk and the dependency on gawk removed. > > base-files is Essential: yes and it PreDepends: awk. I am not sure, but > I think this means that other packages do not need an explicit Depends: > awk. The attached patch does not modify debian/control, but it replaces > gawk with awk in the above two named scripts. > > I have not tested the changes in context, as I have no idea what vtpm > is, and can't put network bridge through normal use until bug 588888 is > solved, but I did test the change from network-bridge manually by > extracting the pipeline where gawk was used and trying it with both gawk > and mawk and comparing the results. > > ...MarvinI did already a gawk removal work few month ago, and they accepted the patch upstream (Ian Jackson did IRRC). You can even see it in the Xen changelog. What I don't understand is from where "xen-common" upstream source code is coming from (the debian/copyright about this is wrong). It seems to be a sub-set of the xen-4.0 source code (all files in the "xen-common" Debian source packages are in the "xen" one). More than that, I don't get why the "xen" Debian source package doesn't generate this "xen-utils-common" directly, and why there's the need of a 2nd source package. If it wasn't the case, then we'd have a xen-utils-common without gawk. Maybe Waldi can explain... Thomas
Thomas Goirand
2010-Jul-16 07:22 UTC
[Pkg-xen-devel] Bug#588888: Bug#589176: xen-utils-common: replace gawk with awk in scripts and Depends
Marvin Renich wrote:> Thanks. > > Any help with bug 588888 would be appreciated, as that one is keeping me > from creating my first xen guest. I think it is just lack of or > incorrect documentation, and I just need a sample config that uses hvm > (that really works with xen 4.0). > > ...MarvinHi, Seems to me that you don't have the Qemu part of xen installed, maybe? Some logs from /var/log/xen would help... If you missed the package, you need to: apt-get install xen-qemu-dm-4.0 which I maintain, and that have been accepted to SID just few days ago. Thomas Goirand (zigo)
Debian Bug Tracking System
2014-Sep-06 21:12 UTC
[Pkg-xen-devel] Bug#589176: marked as done (xen-utils-common: replace gawk with awk in scripts and Depends)
Your message dated Sat, 06 Sep 2014 21:11:47 +0000 with message-id <E1XQNGt-0002et-5G at franck.debian.org> and subject line Bug#589176: fixed in xen 4.4.0-5 has caused the Debian Bug report #589176, regarding xen-utils-common: replace gawk with awk in scripts and Depends to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner at bugs.debian.org immediately.) -- 589176: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=589176 Debian Bug Tracking System Contact owner at bugs.debian.org with problems -------------- next part -------------- An embedded message was scrubbed... From: Marvin Renich <mrvn at renich.org> Subject: xen-utils-common: replace gawk with awk in scripts and Depends Date: Thu, 15 Jul 2010 10:50:38 -0400 Size: 6835 URL: <http://lists.alioth.debian.org/pipermail/pkg-xen-devel/attachments/20140906/8f284b53/attachment-0002.mht> -------------- next part -------------- An embedded message was scrubbed... From: Bastian Blank <waldi at debian.org> Subject: Bug#589176: fixed in xen 4.4.0-5 Date: Sat, 06 Sep 2014 21:11:47 +0000 Size: 7750 URL: <http://lists.alioth.debian.org/pipermail/pkg-xen-devel/attachments/20140906/8f284b53/attachment-0003.mht>