2011/10/2 Praveen A <pravi.a at gmail.com>:> Thanks! I found a solution in ubuntu package. It has a > src/CMakeLists.txt too where we can change library install path. > > /me trying to move docs into a separate package, reading about doc-baseSince this upload adds a new file (libdbusmenu-qt-doc), my upload was rejected. Someone please review the changes and upload. All changes are in git repo. Praveen -- ???????? ??????????????????? You have to keep reminding your government that you don''t get your rights from them; you give them permission to rule, only so long as they follow the rules: laws and constitution.
Alle domenica 2 ottobre 2011, Praveen A ha scritto:> Someone please review the changes and upload. All changes > are in git repo.Some notes (in random order) about the packaging: - why the usage of postinst and prerm to create the symlink for jquery.js? isn''t a .links file for dh_link (hence a static symlink) enough for this job? - in all the packages descriptions and in the doc-base abstract there is "and import their menus over DBus.", where this "DBus" occurrency should be "D-Bus" - copyright misses the current year (2011) for your debian/* changes - in the doc-base file, Files should most probably be something like Files: /usr/share/doc/libdbusmenu-qt-doc/*.html /usr/share/doc/libdbusmenu-qt-doc/search/*.html (given it represents all the HTML files of the documentation) - what''s the point of a symbols file, if you set a strict shlibs manually with dh_makeshlibs? Either drop the strict shlibs, or the symbols file - most probably you can avoid 001-dbusmenu-doc-path.diff at all, and just move the files to the right place using a libdbusmenu-qt-doc.install like: usr/share/doc/dbusmenu-qt/ usr/share/doc/libdbusmenu-qt-doc (this would avoid a (most probably) unnecessary patch) - the libdbusmenu-qt2 description talks about "shared libraries", while there is actually just one - in the libdbusmenu-qt-doc description, "html" should be properly all uppercase - given you need an upload to NEW, why not use the opportunity to add a libdbusmenu-qt-dbg debug package? -- Pino Toscano -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 190 bytes Desc: This is a digitally signed message part. URL: <http://lists.alioth.debian.org/pipermail/pkg-kde-talk/attachments/20111002/5bc15ca5/attachment.pgp>
Praveen Arimbrathodiyil
2012-Mar-31 19:31 UTC
RFS libdbusmenu-qt (Re: Qt Multiarch Transition)
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 10/02/11 14:31, Pino Toscano wrote:> Alle domenica 2 ottobre 2011, Praveen A ha scritto: >> Someone please review the changes and upload. All changes are in >> git repo.Thanks for your review. Sorry for getting back so late on this.> Some notes (in random order) about the packaging: - why the usage > of postinst and prerm to create the symlink for jquery.js? isn''t a > .links file for dh_link (hence a static symlink) enough for this > job?removed postinst and prerm, now using .links file.> - in all the packages descriptions and in the doc-base abstract > there is "and import their menus over DBus.", where this "DBus" > occurrency should be "D-Bus"changed.> - copyright misses the current year (2011) for your debian/* > changeschanged.> - in the doc-base file, Files should most probably be something > like Files: /usr/share/doc/libdbusmenu-qt-doc/*.html > /usr/share/doc/libdbusmenu-qt-doc/search/*.html (given it > represents all the HTML files of the documentation)changed.> - what''s the point of a symbols file, if you set a strict shlibs > manually with dh_makeshlibs? Either drop the strict shlibs, or the > symbols fileI will change it after I fix dbg package.> - most probably you can avoid 001-dbusmenu-doc-path.diff at all, > and just move the files to the right place using a > libdbusmenu-qt-doc.install like: usr/share/doc/dbusmenu-qt/ > usr/share/doc/libdbusmenu-qt-doc (this would avoid a (most > probably) unnecessary patch)changed.> - the libdbusmenu-qt2 description talks about "shared libraries", > while there is actually just onechanged.> - in the libdbusmenu-qt-doc description, "html" should be properly > all uppercasechanged> - given you need an upload to NEW, why not use the opportunity to > add a libdbusmenu-qt-dbg debug package?I followed steps mentioned in http://wiki.debian.org/DebugPackage but the created package does not have any shared library. Is there any other step I need to do? All changes made in the git repo. Thanks Praveen> > > >-----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBCAAGBQJPd1uIAAoJEM4fnGdFEsIqbN0P/0ojGVs2Hy6Xzy2HpsMEmNFY fpColUWtzM3DRIigDwQKjNWwiLMbRS8QWHwM3DuHPUekXR4n5/0/1T36uHrt13yp QWulakNRtjj/yiVRtm2huD1d5PXW3LQOAtRzFLwgsT5ZJ/4/k7uUECusS2Hsq0Ej PTCZEl8Dr5A4nBPrICFXyt3+wqfO4hQrMjbOYrsLNNsrFsKuipHd4Fq5O0/ihwB0 14CAAWSBFNc03EIG8iSnYkTkGv9r7tGysJTxWYWPZt8C8FVVPYDa3YOvJNKzMaTD M/c9YgTcnR4ABbltYsG9ayxeJECc/Hu9LtvKqLE8gx7McbIGE152R6VRsib9s2of 9s2yRg0CW8WfwWS8nsE6CIUNLyxuGYkogwXD1Iu4ft6li4TSPjuOTc9nAjUQiXIa qsR932z2RCKfgyV6ES2LYrLjKDOI+XHmxZoaRT6WAArH7BLsurkzNRjmiZodEhcR QXLHwbJbuCZa/Kf7IupnLG8g5kfCX7Z45fRVH9WrqW81Ws+ucIwowUuuoDp6qCjs Xtz8vYUnkdyL0IKRv4A1BYF6wU9tvMvQ9dT/56GjTr7HJkmvSaboKzE93uyu8O8J lvWCHNCknU8TLhP9GNnx6tb7DmPxbkgUb9xMr2oimbqAsauIpkgs2XNMiXgjNtCs uSU4qK6Vi+So4pT9pXHB =Xk+c -----END PGP SIGNATURE-----
Alle sabato 31 marzo 2012, Praveen Arimbrathodiyil ha scritto:> On 10/02/11 14:31, Pino Toscano wrote: > > Alle domenica 2 ottobre 2011, Praveen A ha scritto: > >> Someone please review the changes and upload. All changes are in > >> git repo. > > Thanks for your review. Sorry for getting back so late on this.No problem.> > - what''s the point of a symbols file, if you set a strict shlibs > > manually with dh_makeshlibs? Either drop the strict shlibs, or the > > symbols file > > I will change it after I fix dbg package.This still holds (why is still "blocked" by the debug package issue?)> > - given you need an upload to NEW, why not use the opportunity to > > add a libdbusmenu-qt-dbg debug package? > > I followed steps mentioned in http://wiki.debian.org/DebugPackage but > the created package does not have any shared library. Is there any > other step I need to do?You''re using compat 9, did you look at the changelog for dh_strip in the debhelper(7) manpage? In particular:> - dh_strip puts separated debug symbols in a location based on their > build-id.so you should have something in /usr/lib/debug/.build-id/ in libdbusmenu-qt-dbg, don''t you? Furthermore: - you are using compat 9 but still build depending on a debhelper 8.x; why not just bump the debhelper build dependency to >= 9, now, so you don''t need the source lintian override? - you might want to see about adopting Standards-Version 3.9.3 - why, months ago, did you push a debian/0.9.0-2 tag, if that version was not even uploaded (to NEW)? with DVCSes like git, please do *not* push tags of versions that are not ACCEPTed in archive, yet. - the watch file says there''s a new version, 0.9.2, available upstream; please consider upgrading to that, if it''s safe enough. -- Pino Toscano -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 190 bytes Desc: This is a digitally signed message part. URL: <http://lists.alioth.debian.org/pipermail/pkg-kde-talk/attachments/20120412/bee4cbcb/attachment.pgp>