Dear mentors, I am looking for a sponsor for my package "k4dirstat". * Package name : k4dirstat Version : 2.7.0~git20101011-1 Upstream Author : Joshua Hodosh <kdirstat at grumpypenguin.org> * URL : http://grumpypenguin.org * License : GPL Section : misc It builds these binary packages: k4dirstat - graphical disk usage display with cleanup facilities kdirstat - Transitional package The package appears to be lintian clean. My motivation for maintaining this package is: I have been using kdirstat for several years and when it was removed from Debian I did not found any replacement, which satisfy me. IMHO, filelight presentation is not as clear as kdirstat one. As kdirstat is now KDE4 compatible I wish to have it again in Debian. Note that Fedora as already packaged it. The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/k/k4dirstat - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/k/k4dirstat/k4dirstat_2.7.0~git20101011-1.dsc I would be glad if someone uploaded this package for me. Kind regards Jerome Robert
Hi, Alle domenica 26 giugno 2011, Jerome Robert ha scritto:> I am looking for a sponsor for my package "k4dirstat".I am not a DD (yet) so I cannot upload your package, but I can give you a (quick?) review of your packaging (so I could be missing something): * debian/changelog - the text for closing a bug does not match the patterns used for that; instead of "close #x" use "closes: #x", which will work (you can verify the result looking at the output of `dpkg-parsechangelog`, and at its Closes: field) * debian/control - the part for the source misses the Priority header - kdirstat: for the short description, I''d put something like "transitional package for k4dirstat" - kdirstat: it is an empty transitional package, so can be Architecture: all * debian/copyright - misses the copyright for the packaging itself - a quick look shows that some sources are licensed are GPL (v2+?) and some are LGPL (v2+?), but you don''t specify the LGPL license - you refer to the "GNU General Public License" to /usr/share/common-licenses/GPL, but it really seems GPL v2+, so you must say that and refer to the "GPL-2" and "GPL-3" common-licenses files (so no generic "GPL") - it misses the copyright indications for the sources, like: Copyright (C) 20xx-20yy by Foo Bar <foo at bar.org> * debian/kdirstat.install - you don''t really need this empty file * debian/k4dirstat.install - the line for "hicolor" icons is repeated three times, but ... - ... in practice you don''t need even this file, see "rules" * debian/rules - make use of pkg-kde-tools and of the ''kde'' addon for `dh`: dh $@ --with kde this will make the packaging adapt automatically to kde-specific steps needed, like avoid compressing .docbook files; see the README.Debian of pkg-kde-tools about the build-dependencies (and their versions) needed - even if the source has two binaries, in practice you need to put everything in one of the two; you can use a small trick with debhelper, i.e. directly install everything to the final location: override_dh_auto_install: dh_auto_install --buildsystem=kde --destdir=debian/k4dirstat (assuming you make use of the kde addon as said above) with this trick, you don''t need any .install file at all> The package appears to be lintian clean.Erm, not really: $ lintian -I -E k4dirstat_2.7.0~git20101011-1_amd64.changes I: k4dirstat source: debian-watch-file-is-missing W: kdirstat: new-package-should-close-itp-bug W: kdirstat: copyright-without-copyright-notice W: kdirstat: no-priority-field W: k4dirstat: new-package-should-close-itp-bug W: k4dirstat: copyright-without-copyright-notice W: k4dirstat: no-priority-field W: k4dirstat: binary-without-manpage usr/bin/k4dirstat however, most of the issues above are covered by notes above; what is not covered are the two lintian items about the watch file and the manpage; note you don''t really need to fix them to enter Debian, even if you are suggested to do so. -- Pino Toscano -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 190 bytes Desc: This is a digitally signed message part. URL: <http://lists.alioth.debian.org/pipermail/pkg-kde-talk/attachments/20110626/0645a444/attachment.pgp>
On 26/06/2011 01:06, Pino Toscano wrote:> I am not a DD (yet) so I cannot upload your package, but I can give you > a (quick?) review of your packaging (so I could be missing something):Very instructive. Thank you. I believe I have fixed all these issues. I''ve uploaded a new version of the package without increasing the package version as I suppose it has only to be done for upload.debian.org uploads (am I right ?). I''ve also added a get-orig-source target to the rules file. Regards, Jerome
Alle marted? 28 giugno 2011, Jerome Robert ha scritto:> On 26/06/2011 01:06, Pino Toscano wrote: > > I am not a DD (yet) so I cannot upload your package, but I can give > > you > > > a (quick?) review of your packaging (so I could be missingsomething):> Very instructive. Thank you. > > I believe I have fixed all these issues.Few more notes: * debian/control - you are using the kde addon for dh, but you missed updating the build dependencies; in particular, you need to - raise the debhelper to >= 7.3.16 - add pkg-kde-tools >= 0.6.2 (see [1]) - better put the Priority in the source section of control, than in any binary package * debian/copyright - I guess you need to add also 2011 to the copyright years of the debian packaging * debian/source/options - the xz compression (which applies to the debian.tar only) is not really worth it, at least here: - your debian.tar.xz is 3764 bytes - a debian.tar.gz created with no "options" is 3807 bytes after all, at the moment you have a buch of mostly small text files, so a better compressions gives simply no gain (of course, if in the future you have bigger files, it will be worth) [1] /usr/share/doc/pkg-kde-tools/README.Debian -- Pino Toscano -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 190 bytes Desc: This is a digitally signed message part. URL: <http://lists.alioth.debian.org/pipermail/pkg-kde-talk/attachments/20110628/b172bee8/attachment.pgp>
On 28/06/2011 13:20, Pino Toscano wrote:> Alle marted? 28 giugno 2011, Jerome Robert ha scritto: >> On 26/06/2011 01:06, Pino Toscano wrote: >>> I am not a DD (yet) so I cannot upload your package, but I can give >>> you >> >>> a (quick?) review of your packaging (so I could be missing > something): >> Very instructive. Thank you. >> >> I believe I have fixed all these issues. > > Few more notes: > > * debian/control > - you are using the kde addon for dh, but you missed updating the build > dependencies; in particular, you need to > - raise the debhelper to >= 7.3.16 > - add pkg-kde-tools >= 0.6.2 > (see [1]) > - better put the Priority in the source section of control, than in any > binary package > > * debian/copyright > - I guess you need to add also 2011 to the copyright years of the > debian packaging > > * debian/source/options > - the xz compression (which applies to the debian.tar only) is not > really worth it, at least here: > - your debian.tar.xz is 3764 bytes > - a debian.tar.gz created with no "options" is 3807 bytes > after all, at the moment you have a buch of mostly small text files, > so a better compressions gives simply no gain (of course, if in the > future you have bigger files, it will be worth) > > [1] /usr/share/doc/pkg-kde-tools/README.Debian >Thanks again. I''ve just uploaded a new package including these fixes.