pkg kde talk - Mar 2005 - Re: [Pkg-kde-commits] rev 705 - in branches/kde-3.4.0: . packages/kdegraphics/debian

* Christopher Martin [Sat, 05 Mar 2005 23:48:17 +0100]:
> +shlibs_ver=4:3.4.0
> -$(foreach p,$(PACKAGES_WITH_LIBS),$(eval DEB_DH_MAKESHLIBS_ARGS_$(p) :=
-V))
> -
> -# Overrides for DEB_DH_MAKESHLIBS_ARGS_foo can go here
> -# shlibs_ver=4:3.3.99
> +$(foreach p,$(PACKAGES_WITH_LIBS),$(eval DEB_DH_MAKESHLIBS_ARGS_$(p) :=
-V''$(p) (>= $(shlibs_ver))''))
  I''m not sure I see the benefits of this. -V already put >= 4:3.4.0
  there (as per DH_COMPAT=4), and now one has to update shlibs_ver by
  hand upon each new upstream release.

  I understand that having the $(foreach) use $(shlibs_ver) can be good,
  so that only changing shlibs_ver is enough should it be necessary. If
  that was your intention, what about having this (4:3.4.0-1 -> 4:3.4.0)?
  
    shlibs_ver=$(shell echo $(DEB_VERSION) | sed -e s/-[^-]*$//)

-- 
Adeodato Simó
    EM: asp16 [ykwim] alu.ua.es | PK: DA6AE621
    Listening to: Elton John - All that I''m allowed
 
I don''t want to achieve immortality through my work. I want to achieve
immortality throguh not dying.
                -- Woody Allen

--nextPart2308076.5O12Jmn6ha
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On March 5, 2005 22:18, Adeodato Sim=F3 wrote:
> * Christopher Martin [Sat, 05 Mar 2005 23:48:17 +0100]:
> > +shlibs_ver=3D4:3.4.0
> > -$(foreach p,$(PACKAGES_WITH_LIBS),$(eval DEB_DH_MAKESHLIBS_ARGS_$(p)
> > :=3D -V)) -
> > -# Overrides for DEB_DH_MAKESHLIBS_ARGS_foo can go here
> > -# shlibs_ver=3D4:3.3.99
> > +$(foreach p,$(PACKAGES_WITH_LIBS),$(eval DEB_DH_MAKESHLIBS_ARGS_$(p)
> > :=3D -V''$(p) (>=3D $(shlibs_ver))''))
>
>   I''m not sure I see the benefits of this. -V already put >=3D
4:3.4.0
>   there (as per DH_COMPAT=3D4), and now one has to update shlibs_ver by
>   hand upon each new upstream release.
>
>   I understand that having the $(foreach) use $(shlibs_ver) can be good,
>   so that only changing shlibs_ver is enough should it be necessary. If
>   that was your intention, what about having this (4:3.4.0-1 ->
4:3.4.0)?
>
>     shlibs_ver=3D$(shell echo $(DEB_VERSION) | sed -e s/-[^-]*$//)
This was to allow shlibs bumps on branch pulls, without always forcing a=20
bump, since not all uploads may need one.

Cheers,
Christopher

--nextPart2308076.5O12Jmn6ha
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)
Comment: Signed by Christopher Martin <chrsmrtn@freeshell.org>

iD8DBQBCKny2U+gWW+vtsysRAr0bAKCKw/cw3El+2ODkvSLaNlqrKmQVzwCeLRt0
phx+sClE7JK2rHyWTJ/gDwo=bdbf
-----END PGP SIGNATURE-----

--nextPart2308076.5O12Jmn6ha--

* Christopher Martin [Sat, 05 Mar 2005 22:44:53 -0500]:
> On March 5, 2005 22:18, Adeodato Simó wrote:
> > * Christopher Martin [Sat, 05 Mar 2005 23:48:17 +0100]:
> > > +shlibs_ver=4:3.4.0
> > > -$(foreach p,$(PACKAGES_WITH_LIBS),$(eval
DEB_DH_MAKESHLIBS_ARGS_$(p)
> > > := -V)) -
> > > -# Overrides for DEB_DH_MAKESHLIBS_ARGS_foo can go here
> > > -# shlibs_ver=4:3.3.99
> > > +$(foreach p,$(PACKAGES_WITH_LIBS),$(eval
DEB_DH_MAKESHLIBS_ARGS_$(p)
> > > := -V''$(p) (>= $(shlibs_ver))''))
> >   I''m not sure I see the benefits of this. -V already put
>= 4:3.4.0
> >   there (as per DH_COMPAT=4), and now one has to update shlibs_ver by
> >   hand upon each new upstream release.
> >   I understand that having the $(foreach) use $(shlibs_ver) can be
good,
> >   so that only changing shlibs_ver is enough should it be necessary.
If
> >   that was your intention, what about having this (4:3.4.0-1 ->
4:3.4.0)?
> >     shlibs_ver=$(shell echo $(DEB_VERSION) | sed -e s/-[^-]*$//)
> This was to allow shlibs bumps on branch pulls, without always forcing a 
> bump, since not all uploads may need one.
  Sure. It seems we''re talking about orthogonal issues: you want to be
  able to bump shlibs in branch pulls, which is what your first commit
  was for (IOW, include shlibs_ver in the foreach); I want a default
  value for shlibs_ver, so that I need not touch anything if it matches
  the upstream version, which is what the line above is for.

  The idea is that if we move this to kde.mk (or kde-kludges.mk), that
  line goes with it too. If I managed to explain myself... opinions?

-- 
Adeodato Simó
    EM: asp16 [ykwim] alu.ua.es | PK: DA6AE621
    Listening to: Elton John - Look ma no hands
 
A black cat crossing your path signifies that the animal is going somewhere.
                -- Groucho Marx

--nextPart9198191.ajlCh995c3
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On March 5, 2005 22:55, Adeodato Sim=F3 wrote:
> > This was to allow shlibs bumps on branch pulls, without always forcing
> > a bump, since not all uploads may need one.
>
>   Sure. It seems we''re talking about orthogonal issues: you want
to be
>   able to bump shlibs in branch pulls, which is what your first commit
>   was for (IOW, include shlibs_ver in the foreach); I want a default
>   value for shlibs_ver, so that I need not touch anything if it matches
>   the upstream version, which is what the line above is for.
>
>   The idea is that if we move this to kde.mk (or kde-kludges.mk), that
>   line goes with it too. If I managed to explain myself... opinions?
Ah, I think I see what you were driving at. So shlibs_ver=3D$(shell echo=20
$(DEB_VERSION) | sed -e s/-[^-]*$//) would be the default, as it is good=20
enough for most situations, and would be located in kde.mk. But if need be,=20
it could be replaced in rules by shlibs_ver=3D4:1.2.3-4 or whatever. If
I''ve=20
understood you correctly, then that sounds like a good plan.

Cheers,
Christopher Martin

--nextPart9198191.ajlCh995c3
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)
Comment: Signed by Christopher Martin <chrsmrtn@freeshell.org>

iD8DBQBCKoHtU+gWW+vtsysRAmVDAJ0SKpEmbY+x3e7TmBUXe+DNzeISPACbB43o
MFTDyU2l1/LOFldDpiNzoSw=DvMN
-----END PGP SIGNATURE-----

--nextPart9198191.ajlCh995c3--

* Christopher Martin [Sat, 05 Mar 2005 23:07:01 -0500]:
> On March 5, 2005 22:55, Adeodato Simó wrote:
> > > This was to allow shlibs bumps on branch pulls, without always
forcing
> > > a bump, since not all uploads may need one.
> >   Sure. It seems we''re talking about orthogonal issues: you
want to be
> >   able to bump shlibs in branch pulls, which is what your first commit
> >   was for (IOW, include shlibs_ver in the foreach); I want a default
> >   value for shlibs_ver, so that I need not touch anything if it
matches
> >   the upstream version, which is what the line above is for.
> >   The idea is that if we move this to kde.mk (or kde-kludges.mk), that
> >   line goes with it too. If I managed to explain myself... opinions?
> Ah, I think I see what you were driving at. So shlibs_ver=$(shell echo 
> $(DEB_VERSION) | sed -e s/-[^-]*$//) would be the default, as it is good 
> enough for most situations, and would be located in kde.mk. But if need be,
> it could be replaced in rules by shlibs_ver=4:1.2.3-4 or whatever. If
I''ve
> understood you correctly, then that sounds like a good plan.
  /me checks that DEB_DH_MAKESHLIBS_ARGS_ALL exists and wonders what''s
  been he smoking... (about introducing that fancy $(foreach) in the
  first place). If dh_makeshlibs behaves properly upon:

    dh_makeshlibs -pfoo -V -Vx.y.z

  then, we should probably have DEB_DH_MAKESHLIBS_ARGS_ALL := -V
  somewhere, and be done with it.

-- 
Adeodato Simó
    EM: asp16 [ykwim] alu.ua.es | PK: DA6AE621
 
You''ve come to the right place.  At debian-devel we are always willing
to argue over the meanings of words.
                -- seen on debian-devel@l.d.o