Ovirt devel - Feb 2010 - Proposals for making configure_from_network function works in f13

Hi

I am running a pxe diskless node in f13 and I have some proposals to make 
ovirt-early working in this version.

nash is no more available (nash/mkinitrd is replaced by dracut), so this 
following command fails :
"echo "network --device $DEVICE --bootproto dhcp" | nash"
it makes the network configuration incomplete. I replace the linuxrc command by 
dhclient and it's working well. There may be another solution to get dhcp
but
I don't know it.

(I did not commit the patch of Ricardo Marin Matinata)

@@ -38,8 +38,8 @@
     if [ -n "$DEVICE" ]; then
         log "Configuring network Using interface $DEVICE"
         # setup temporary interface to retrieve configuration
-        echo "network --device $DEVICE --bootproto dhcp" | bash
-        if [ $? -eq 0 ]; then
+       /sbin/dhclient $1
+       if [ $? -eq 0 ]; then
             # from network-scripts/ifup-post
             IPADDR=$(LC_ALL=C ip -o -4 addr ls dev ${DEVICE} | awk '{ print
$4 ; exit }')
             log "Interface brought up with $IPADDR"



And the cobbler/dracut problem in f12 persits in f13 
(https://bugzilla.redhat.com/show_bug.cgi?id=548283)

--- cobbler-import.ori  2010-01-12 11:54:13.000000000 +0100
+++ cobbler-import      2010-02-08 10:31:44.000000000 +0100
@@ -46,15 +46,9 @@

 cobbler distro add --name="oVirt-Node-$node_arch" --arch=$node_arch \
     --initrd=$node_dir/tftpboot/initrd0.img --
kernel=$node_dir/tftpboot/vmlinuz0 \
-    --kopts="rootflags=loop root=/ovirt-node-image.iso rootfstype=iso9660
ro
console=tty0 console=ttyS0,115200n8"
+    --kopts="rootflags=loop root=live:/ovirt-node-image.iso
rootfstype=iso9660
ro console=tty0 console=ttyS0,115200n8"


I didn't try this patch but I think this is the way to get this kind of
config
in /var/lib/tftpboot/pxelinux.cfg/default :

LABEL oVirt-Node-x86_64
        kernel /images/oVirt-Node-x86_64/vmlinuz0
        MENU LABEL oVirt-Node-x86_64
        append initrd=/images/oVirt-Node-x86_64/initrd0.img ksdevice=bootif ro 
rootflags=loop rootfstype=iso9660 root=live:/ovirt-node-image.iso kssendmac  
ks=http://10.75.196.100/cblr/svc/op/ks/profile/oVirt-Node-x86_64
        ipappend 2



-- 
Arthur CLEMENT
Linagora Paris

On Mon, Feb 08, 2010 at 03:35:23PM +0100, Arthur CLEMENT
wrote:
> I am running a pxe diskless node in f13 and I have some proposals to make 
> ovirt-early working in this version.
> 
> nash is no more available (nash/mkinitrd is replaced by dracut), so this 
> following command fails :
> "echo "network --device $DEVICE --bootproto dhcp" |
nash"
> it makes the network configuration incomplete. I replace the linuxrc
command by
> dhclient and it's working well. There may be another solution to get
dhcp but
> I don't know it.
> 
> (I did not commit the patch of Ricardo Marin Matinata)
> 
> @@ -38,8 +38,8 @@
>      if [ -n "$DEVICE" ]; then
>          log "Configuring network Using interface $DEVICE"
>          # setup temporary interface to retrieve configuration
> -        echo "network --device $DEVICE --bootproto dhcp" | bash
> -        if [ $? -eq 0 ]; then
> +       /sbin/dhclient $1
> +       if [ $? -eq 0 ]; then
>              # from network-scripts/ifup-post
>              IPADDR=$(LC_ALL=C ip -o -4 addr ls dev ${DEVICE} | awk '{
print
> $4 ; exit }')
>              log "Interface brought up with $IPADDR"
> 
> 
> 
> And the cobbler/dracut problem in f12 persits in f13 
> (https://bugzilla.redhat.com/show_bug.cgi?id=548283)
> 
> --- cobbler-import.ori  2010-01-12 11:54:13.000000000 +0100
> +++ cobbler-import      2010-02-08 10:31:44.000000000 +0100
> @@ -46,15 +46,9 @@
> 
>  cobbler distro add --name="oVirt-Node-$node_arch"
--arch=$node_arch \
>      --initrd=$node_dir/tftpboot/initrd0.img --
> kernel=$node_dir/tftpboot/vmlinuz0 \
> -    --kopts="rootflags=loop root=/ovirt-node-image.iso
rootfstype=iso9660 ro
> console=tty0 console=ttyS0,115200n8"
> +    --kopts="rootflags=loop root=live:/ovirt-node-image.iso
rootfstype=iso9660
> ro console=tty0 console=ttyS0,115200n8"
> 
> 
> I didn't try this patch but I think this is the way to get this kind of
config
> in /var/lib/tftpboot/pxelinux.cfg/default :
> 
> LABEL oVirt-Node-x86_64
>         kernel /images/oVirt-Node-x86_64/vmlinuz0
>         MENU LABEL oVirt-Node-x86_64
>         append initrd=/images/oVirt-Node-x86_64/initrd0.img ksdevice=bootif
ro
> rootflags=loop rootfstype=iso9660 root=live:/ovirt-node-image.iso kssendmac
> ks=http://10.75.196.100/cblr/svc/op/ks/profile/oVirt-Node-x86_64
>         ipappend 2
Thank you for the feedback, Arthur. On first glance, this patch looks
like it should work for what has changed in fedora. Can you do a
checkout of our git repo, create a test branch and then test this? If it
works, then I would be happy to consider it for inclusion in the
codebase. :)

-- 
Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc.
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL:
<http://listman.redhat.com/archives/ovirt-devel/attachments/20100208/413a7489/attachment.sig>

> (I did not commit the patch of Ricardo Marin Matinata)
Ricardo's patch has been pushed to 'next' so this needs to be
rebased:

--- a/scripts/ovirt-early
+++ b/scripts/ovirt-early
@@ -40,7 +40,7 @@ configure_from_network() {
         if ! network_up ; then
             log "Using interface $DEVICE"
             # setup temporary interface to retrieve configuration
-            echo "network --device $DEVICE --bootproto dhcp" | nash
+            /sbin/dhclient $DEVICE
         fi
         if [ $? -eq 0 ]; then
             # from network-scripts/ifup-post

ACK from me, after you provide testing results as requested by Darryl