Ovirt devel - Apr 2009 - Two small patches for ovirt-awake

Two very small patches to improve ovirt-awake. The first one makes sure
host-browser on the server doesn't log spurious errors - it expects that
ovirt-awake sends ACK after downloading the keytab.

Error checking/reporting in ovirt-awake is still pretty suspect, e.g. there
is no check that wget actually succeeded.

David

host-browser on the server expects it
---
 scripts/ovirt-awake |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/scripts/ovirt-awake b/scripts/ovirt-awake
index 56fcb57..87994a5 100644
--- a/scripts/ovirt-awake
+++ b/scripts/ovirt-awake
@@ -68,6 +68,7 @@ start () {
             else
                 echo "No keytab to retrieve"
             fi
+            send-text ACK
         else
             echo "Did not get a mode request."
         fi
-- 
1.6.0.6

---
 scripts/ovirt-awake |   10 ++++++++--
 1 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/scripts/ovirt-awake b/scripts/ovirt-awake
index 87994a5..336c2b1 100644
--- a/scripts/ovirt-awake
+++ b/scripts/ovirt-awake
@@ -42,6 +42,12 @@ function receive-text () {
     read 0<&3
 }
 
+function error () {
+  errmsg="ERR: (ovirt-awake) $1"
+  send-text "$errmsg"
+  log "$errmsg"
+}
+
 start () {
     connect-to-server
 
@@ -70,10 +76,10 @@ start () {
             fi
             send-text ACK
         else
-            echo "Did not get a mode request."
+            error "Did not get a mode request."
         fi
     else
-        echo "Did not get a proper startup marker."
+        error "Did not get a proper startup marker."
     fi
 
     echo "Disconnecting."
-- 
1.6.0.6

On Thu, 2009-04-23 at 17:31 -0700, David Lutterkort
wrote:
> Two very small patches to improve ovirt-awake. The first one makes sure
> host-browser on the server doesn't log spurious errors - it expects
that
> ovirt-awake sends ACK after downloading the keytab.
Pushed these.

David