Scott Seago
2008-Dec-11 21:48 UTC
[Ovirt-devel] [PATCH] fix for Bug 467767: double render error for add user
Not yet tested as I don't have a working appliance at the moment, but this
should fix the problem, as there was an obvious issue with the render statement.
I'll test shortly unless someone else gets to it first and ACKs.
Signed-off-by: Scott Seago <sseago at redhat.com>
---
src/app/controllers/permission_controller.rb | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/src/app/controllers/permission_controller.rb
b/src/app/controllers/permission_controller.rb
index 813d9d9..c301e1e 100644
--- a/src/app/controllers/permission_controller.rb
+++ b/src/app/controllers/permission_controller.rb
@@ -47,8 +47,9 @@ class PermissionController < ApplicationController
unless @can_set_perms
flash[:notice] = 'You do not have permission to create this
permission record'
redirect_to_parent
+ else
+ render :layout => 'popup'
end
- render :layout => 'popup'
end
def create
--
1.6.0.4
Jason Guiditta
2008-Dec-19 15:39 UTC
[Ovirt-devel] [PATCH] fix for Bug 467767: double render error for add user
On Thu, 2008-12-11 at 21:48 +0000, Scott Seago wrote:> Not yet tested as I don't have a working appliance at the moment, but this should fix the problem, as there was an obvious issue with the render statement. I'll test shortly unless someone else gets to it first and ACKs. > > Signed-off-by: Scott Seago <sseago at redhat.com> > --- > src/app/controllers/permission_controller.rb | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/src/app/controllers/permission_controller.rb b/src/app/controllers/permission_controller.rb > index 813d9d9..c301e1e 100644 > --- a/src/app/controllers/permission_controller.rb > +++ b/src/app/controllers/permission_controller.rb > @@ -47,8 +47,9 @@ class PermissionController < ApplicationController > unless @can_set_perms > flash[:notice] = 'You do not have permission to create this permission record' > redirect_to_parent > + else > + render :layout => 'popup' > end > - render :layout => 'popup' > end > > def createACK