Perry Myers
2008-Oct-09 03:29 UTC
[Ovirt-devel] [PATCH recipe] Syntax error correction in ovirt.pp (missing comma)
Missing comma in ovirt.pp caused ace service to fail at appliance firstboot, which caused failures in the appliance. Signed-off-by: Perry Myers <pmyers at redhat.com> --- appliances/ovirt/ovirt.pp.in | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/appliances/ovirt/ovirt.pp.in b/appliances/ovirt/ovirt.pp.in index 4e96cca..da98f2d 100644 --- a/appliances/ovirt/ovirt.pp.in +++ b/appliances/ovirt/ovirt.pp.in @@ -84,7 +84,7 @@ file {"/etc/collectd.conf": } file {"/etc/qpidd.conf": - source => "puppet:///ovirt/qpidd.conf" + source => "puppet:///ovirt/qpidd.conf", notify => Service["qpidd"] } -- 1.5.5.1
Perry N. Myers
2008-Oct-09 03:33 UTC
[Ovirt-devel] Re: [PATCH recipe] Syntax error correction in ovirt.pp (missing comma)
Perry Myers wrote:> Missing comma in ovirt.pp caused ace service to fail at appliance firstboot, > which caused failures in the appliance.For those of you who reported issues with the appliance booting and seeming like a postgres connection problem, this was the reason. Here's what happened for future reference: syntax error in ovirt.pp caused /etc/init.d/ace to fail during appliance firstboot configuration This prevented the ovirt-server-install script from running which sets up the database, and then failures cascaded from there It's important when writing patches to test the build process end to end including building an appliance and testing major functionality to make sure no regressions are introduced. To diagnose this problem I simply looked at the log files in: /var/log/ace Perry