On Fri, Sep 19, 2008 at 01:42:00AM -0400, Perry N. Myers
wrote:> The following patches:
> [PATCH server] Restructured makefile and rpmbuilding to simplify it
> [PATCH release] Restructured makefile and rpmbuilding to simplify it
> [PATCH node-image] Restructured makefile and rpmbuilding to simplify it
> [PATCH node] Removed dummy bumpgit target since the rest of the repos have
> been converted
> [PATCH docs] Restructured makefile and rpmbuilding to simplify it
> [PATCH appliance] Restructured makefile and rpmbuilding to simplify it
>
> Convert all of the remaining repos to autoconf and simplify the makefiles
> significantly. They all need to be applied at the same time if you're
> using ovirt.mk to build things since there were some interdependencies.
>
> Aside from general autoconf'ing the other significant changes are in
the
> way the versioning is handled. It's now similar to what the libvirt
> project does, which I assume is a standard way of doing things... :)
>
> I also removed setting overrides for rpmmacros (except for oVirt specific
> rpmmacros).
>
> Please give these patches a whirl for building and let me know how they
> work out.
>
> The last bit that I want to get done after these patches go in is removing
> the stuff from %build in both ovirt-appliance and ovirt-node-image and
> putting it in the Makefile and then calling make from %build. This is
> cleaner and allows the images to be built without needing the RPM
packaging.
This stuff all looks very good so gets my vote.
Regards,
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|