Daniel P. Berrange
2008-Sep-17 13:08 UTC
[Ovirt-devel] PATCH: Fix node-image autobuild.sh with local repos
The ovirt_local_repo macro needs to be a proper URI, not a file path...
diff --git a/autobuild.sh b/autobuild.sh
index ba5c3cb..08500c3 100755
--- a/autobuild.sh
+++ b/autobuild.sh
@@ -42,6 +42,6 @@ if [ -f /usr/bin/rpmbuild ]; then
cp rpm-build/ovirt-node-image-$version.tar.gz
$AUTOBUILD_PACKAGE_ROOT/rpm/SOURCES/
rpmbuild --nodeps --define "extra_release $EXTRA_RELEASE" \
- --define "ovirt_local_repo
$AUTOBUILD_PACKAGE_ROOT/rpm/RPMS" \
+ --define "ovirt_local_repo
file://$AUTOBUILD_PACKAGE_ROOT/rpm/RPMS" \
-ba --clean ovirt-node-image.spec
fi
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
Mohammed Morsi
2008-Sep-18 00:16 UTC
[Ovirt-devel] PATCH: Fix node-image autobuild.sh with local repos
Daniel P. Berrange wrote:> The ovirt_local_repo macro needs to be a proper URI, not a file path... > > > diff --git a/autobuild.sh b/autobuild.sh > index ba5c3cb..08500c3 100755 > --- a/autobuild.sh > +++ b/autobuild.sh > @@ -42,6 +42,6 @@ if [ -f /usr/bin/rpmbuild ]; then > cp rpm-build/ovirt-node-image-$version.tar.gz $AUTOBUILD_PACKAGE_ROOT/rpm/SOURCES/ > > rpmbuild --nodeps --define "extra_release $EXTRA_RELEASE" \ > - --define "ovirt_local_repo $AUTOBUILD_PACKAGE_ROOT/rpm/RPMS" \ > + --define "ovirt_local_repo file://$AUTOBUILD_PACKAGE_ROOT/rpm/RPMS" \ > -ba --clean ovirt-node-image.spec > fi > > > Daniel >ACK. Recall running into the same issue / doing the same fix, why it never got committed escapes me... -Mo