Ovirt devel - Sep 2008 - [PATCH-node]: Re-arrange the node spec file to use scripts

-- 
Chris Lalancette
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ovirt-rearrange-node-spec.patch
Type: text/x-patch
Size: 14158 bytes
Desc: not available
URL:
<http://listman.redhat.com/archives/ovirt-devel/attachments/20080911/f2e6a2ff/attachment.bin>

Chris Lalancette <clalance at redhat.com> wrote:
> commit 56f847792a30f26891940d21fe7bb10df8c2abd9
> Author: Chris Lalancette <clalance at redhat.com>
> Date:   Thu Sep 11 13:43:25 2008 +0200
>
>     A rewrite of the ovirt-node.spec script, which cascaded into a bunch of
>     other files.  The impetus for doing this is that we want to have an
...
> diff --git a/ovirt-listen-awake/ovirt-install-host
b/ovirt-listen-awake/ovirt-install-host
...
> \ No newline at end of file
> diff --git a/ovirt-listen-awake/ovirt-uninstall-host
b/ovirt-listen-awake/ovirt-uninstall-host
...
> \ No newline at end of file
All looks fine, though you'll want to add a newline
at the end of each of those files.

Just some general comments...

Comment on naming of the script (ovirt-install-node) from your other patch 
applies here as well.

Otherwise this looks fine as a first pass.  A few things to keep in mind 
(stuff to work on later)

This patch is specific to solving the problem of letting the oVirt Server 
Suite running as an appliance manage VMs running on its own host.  This is 
a good idea, but we should be able to further generalize this patch to 
support installing the ovirt-node RPM on any random F9 box to turn that 
box into a node that can be managed by oVirt.

Some of the hardcoded values in the stateful section (like the IP address 
and DNS information) would prevent this from working properly, so we might 
need to tweak things there.  Also, it seems to me that the 
ovirt-listen-awake might not be applicable to the general case...  Not 
sure how that would fit in.

But overall, this is a good first cut in the right direction, so ACK 
(assuming it's been reasonably tested :)

Perry

Pushed, after addressing the name change from ovirt-install-host to
ovirt-install-node and ovirt-uninstall-host to ovirt-uninstall-node.


-- 
Chris Lalancette