Jim Meyering
2008-Sep-05 07:31 UTC
[Ovirt-devel] avoid warnings from "make clean" with parallel make
Without the patches below, a top level "make -f release/ovirt.mk clean" gets warnings with parallel make (i.e. either with -j2 or with MAKEFLAGS=-j$n in the environment). for dir in release server node node-image appliance docs; do if test -d $dir ; then make -C $dir clean || exit 1 ; fi ; done make[1]: Entering directory `/f/mirror/ov2/release' make[1]: warning: jobserver unavailable: using -j1. Add `+' to parent make rule. make[1]: Nothing to be done for `clean'. make[1]: Leaving directory `/f/mirror/ov2/release' make[1]: Entering directory `/f/mirror/ov2/server' make[1]: warning: jobserver unavailable: using -j1. Add `+' to parent make rule. rm -f ovirt*.gz ovirt*.rpm rm -rf ovirt-server-* dist build make[1]: Leaving directory `/f/mirror/ov2/server' make[1]: Entering directory `/f/mirror/ov2/node' make[1]: warning: jobserver unavailable: using -j1. Add `+' to parent make rule. make -C ovirt-identify-node clean make[2]: Entering directory `/f/mirror/ov2/node/ovirt-identify-node' rm -rf comm.o gather.o hal_support.o main.o protocol.o ovirt-identify-node make[2]: Leaving directory `/f/mirror/ov2/node/ovirt-identify-node' rm -rf ovirt-node-0.92 make[1]: Leaving directory `/f/mirror/ov2/node' make[1]: Entering directory `/f/mirror/ov2/node-image' make[1]: warning: jobserver unavailable: using -j1. Add `+' to parent make rule. rm -rf ovirt-node-image-* make[1]: Leaving directory `/f/mirror/ov2/node-image' make[1]: Entering directory `/f/mirror/ov2/appliance' make[1]: warning: jobserver unavailable: using -j1. Add `+' to parent make rule. rm -f ovirt-appliance-* make[1]: Leaving directory `/f/mirror/ov2/appliance' make[1]: Entering directory `/f/mirror/ov2/docs' make[1]: warning: jobserver unavailable: using -j1. Add `+' to parent make rule. make[1]: Nothing to be done for `clean'. make[1]: Leaving directory `/f/mirror/ov2/docs' These are for node/ and release/ respectively:>From f44150eae5beef4f4a801f904db91b6fa8af7ae5 Mon Sep 17 00:00:00 2001From: Jim Meyering <meyering at redhat.com> Date: Fri, 5 Sep 2008 09:28:36 +0200 Subject: [PATCH] * Makefile (clean): Prefix with '+' to avoid warning w/-j. --- Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index be136c2..0f182dd 100644 --- a/Makefile +++ b/Makefile @@ -22,7 +22,7 @@ all: rpms include release.mk clean: - make -C ovirt-identify-node clean + +$(MAKE) -C ovirt-identify-node clean rm -rf $(NV) distclean: clean -- 1.6.0.1.216.g1b23a>From 91f77ef54e060828e3f7c04e76c385d038913031 Mon Sep 17 00:00:00 2001From: Jim Meyering <meyering at redhat.com> Date: Fri, 5 Sep 2008 09:27:39 +0200 Subject: [PATCH] * ovirt.mk (for_each_subdir): Prefix with '+' to avoid warning w/-j. --- ovirt.mk | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/ovirt.mk b/ovirt.mk index e61f83b..78ee0f5 100644 --- a/ovirt.mk +++ b/ovirt.mk @@ -11,7 +11,7 @@ SUBDIRS ?= release server node node-image appliance docs export OVIRT_CACHE_DIR ?= $(HOME)/ovirt-cache define for_each_subdir - for dir in $(SUBDIRS); do \ + +for dir in $(SUBDIRS); do \ if test -d $$dir ; then \ $(MAKE) -C $$dir $@ || exit 1 ; \ fi ; \ -- 1.6.0.1.216.g1b23a
Perry N. Myers
2008-Sep-05 14:33 UTC
[Ovirt-devel] avoid warnings from "make clean" with parallel make
Jim Meyering wrote:> Without the patches below, a top level "make -f release/ovirt.mk clean" > gets warnings with parallel make (i.e. either with -j2 or with MAKEFLAGS=-j$n > in the environment).ACK Perry