Jim Meyering
2008-Sep-05 07:08 UTC
[Ovirt-devel] [PATCH] docs/Makefile (publish): Remove no-op "TBD" rules.
Hmm... beginning to see a small problem here. I would have much preferred to see "docs/Makefile" in the patch itself. With sub-directories and the occasional file (like Makefile) that appears in each of the newly-split 6 repositories, there's ample room for misapplication of patches and general confusion. This fixes the warnings from "make -f ovirt.mk clean": make[1]: Entering directory `/f/mirror/ov2/docs' Makefile:16: warning: overriding commands for target `publish' release.mk:51: warning: ignoring old commands for target `publish' Makefile:19: warning: overriding commands for target `rpms' release.mk:46: warning: ignoring old commands for target `rpms'>From 35e94ddaf9e15439670ffbef14b0a752353b8348 Mon Sep 17 00:00:00 2001From: Jim Meyering <meyering at redhat.com> Date: Fri, 5 Sep 2008 08:59:35 +0200 Subject: [PATCH] Makefile (publish, rpms): Remove no-op "TBD" rules. They conflicted with the ones in release.mk. --- Makefile | 6 ------ 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/Makefile b/Makefile index 74352d5..4555e4a 100644 --- a/Makefile +++ b/Makefile @@ -12,10 +12,4 @@ distclean: clean tar: clean echo "TBD" -publish: - echo "TBD" - -rpms: - echo "TBD" - .PHONY: all clean distclean tar -- 1.6.0.1.216.g1b23a
Perry N. Myers
2008-Sep-05 13:47 UTC
[Ovirt-devel] [PATCH] docs/Makefile (publish): Remove no-op "TBD" rules.
Jim Meyering wrote:> Hmm... beginning to see a small problem here. > I would have much preferred to see "docs/Makefile" in the patch itself. > With sub-directories and the occasional file (like Makefile) > that appears in each of the newly-split 6 repositories, > there's ample room for misapplication of patches and general confusion.Thanks for cleaning this up.... What I did was just a hack to get things working :) As for the docs/Makefile problem. I suggest that we include in the patch comments what repo the patch is for. i.e. [ovirt-server], [ovirt-docs] that should help clear up any confusion. Perry