Ovirt devel - Jun 2008 - [Patch] History Graphs Improvements

-------------- next part --------------
A non-text attachment was scrubbed...
Name: history-graphs1.patch
Type: text/x-patch
Size: 7405 bytes
Desc: not available
URL:
<http://listman.redhat.com/archives/ovirt-devel/attachments/20080609/0be91a95/attachment.bin>

I don't want to hold the patch up per se, but if anything tweaks need to be
made I'd like to see a
change.

For the history graph, Can you define a variable for the RRDResolution :
   requestList.push ( StatsRequest.new (host.hostname, devclass, 0, avgcounter,
0, 604800,R
RDResolution::Medium)

and use that in the request and here:
   valueindex = ((data.get_timestamp?.to_i - dat[0].get_timestamp?.to_i) /
2230).to_i

That way we won't have issues down the road if we decide to change the
resolutions and miss the
hardcoded one

thanks

-mark

Mohammed Morsi wrote:
>

Mohammed Morsi wrote:
>
More improvements.

   -Mo

-------------- next part --------------
A non-text attachment was scrubbed...
Name: history-graphs2.patch
Type: text/x-patch
Size: 4128 bytes
Desc: not available
URL:
<http://listman.redhat.com/archives/ovirt-devel/attachments/20080609/4d929952/attachment.bin>