Attached is a patch to fix up taskomatic storage for iSCSI, at least. It seems that ".target" has become a reserved method somewhere in the ruby libraries, so trying to create XML with it was getting a "malformed XML" error from libvirt. The solution is to switch to storage[:target], which still works. There are a bunch of whitespace and other minor changes in this patch as well. Signed-off-by: Chris Lalancette <clalance at redhat.com> -------------- next part -------------- A non-text attachment was scrubbed... Name: ovirt-fix-taskomatic-storage.patch Type: text/x-patch Size: 4262 bytes Desc: not available URL: <http://listman.redhat.com/archives/ovirt-devel/attachments/20080602/46cabc07/attachment.bin>
On Mon, 02 Jun 2008 16:42:51 +0200 Chris Lalancette <clalance at redhat.com> wrote:> Attached is a patch to fix up taskomatic storage for iSCSI, at least. It seems > that ".target" has become a reserved method somewhere in the ruby libraries, so > trying to create XML with it was getting a "malformed XML" error from libvirt. > The solution is to switch to storage[:target], which still works. There are a > bunch of whitespace and other minor changes in this patch as well. > > Signed-off-by: Chris Lalancette <clalance at redhat.com>Looks good, ACK. Ian
Chris Lalancette wrote:> Attached is a patch to fix up taskomatic storage for iSCSI, at least. It seems > that ".target" has become a reserved method somewhere in the ruby libraries, so > trying to create XML with it was getting a "malformed XML" error from libvirt. > The solution is to switch to storage[:target], which still works. There are a > bunch of whitespace and other minor changes in this patch as well.Committed Chris Lalancette