Ovirt devel - May 2008 - [PATCH] fix ovirt service startup in ovirt-wui-install script

Subject: [PATCH] Split the services that need to be turned on into chkconfig
into base
 services and ovirt specific services.  This is so at the end of the
 install script these services can be started in a loop.

Also, remove the disable services loop since it only contains
libvirtd and we don't want to always disable libvirtd when we
install ovirt

Signed-off-by: Perry Myers <pmyers at redhat.com>
---
 wui/scripts/ovirt-wui-install |   17 ++++++++---------
 1 files changed, 8 insertions(+), 9 deletions(-)

diff --git a/wui/scripts/ovirt-wui-install b/wui/scripts/ovirt-wui-install
index 6285b3c..3eb1c4d 100755
--- a/wui/scripts/ovirt-wui-install
+++ b/wui/scripts/ovirt-wui-install
@@ -13,9 +13,9 @@ STEP_FILE=/etc/ntp/step-tickers
 SASL_FILE=/etc/sasl2/libvirt.conf
 LDAP_CFG=${OVIRT_DIR}/config/ldap.yml
 
-DISABLE_SVCS="libvirtd" 
-ENABLE_SVCS="ntpd httpd postgresql ovirt-host-browser ovirt-host-status \
-             ovirt-taskomatic ovirt-host-keyadd ovirt-mongrel-rails"
+OVIRT_SVCS="ovirt-host-browser ovirt-host-status \
+            ovirt-taskomatic ovirt-host-keyadd ovirt-mongrel-rails"
+ENABLE_SVCS="ntpd httpd postgresql"
 
 usage() {
     echo "usage: $0 [-p password]"
@@ -83,12 +83,7 @@ for i ; do
 done
 
 {
-for svc in $DISABLE_SVCS ; do
-    chkconfig $svc off
-    service $svc off
-done
-
-for svc in $ENABLE_SVCS ; do
+for svc in $ENABLE_SVCS $OVIRT_SVCS; do
     chkconfig $svc on
 done
 } > /dev/null 2>&1
@@ -182,5 +177,9 @@ if [ -f /etc/httpd/conf.d/ipa.conf ]; then
     service ipa_webgui restart
 fi
 
+for svc in $OVIRT_SVCS ; do
+    service $svc start
+done
+
 exit 0

Perry N. Myers wrote:
> 
> Subject: [PATCH] Split the services that need to be turned on into 
> chkconfig into base
> services and ovirt specific services.  This is so at the end of the
> install script these services can be started in a loop.
> 
> Also, remove the disable services loop since it only contains
> libvirtd and we don't want to always disable libvirtd when we
> install ovirt
Btw, with this patch and with the patch to fix ldap.yml via the 
ovirt-wui-install script, ([PATCH] set ldap.yml from dns srv during 
ovirt-wui-install) I'm now able to install the wui appliance in developer 
mode and on first boot everything comes up and is working well.

Perry

Perry N. Myers wrote:
> Subject: [PATCH] Split the services that need to be turned on into
chkconfig into base
>  services and ovirt specific services.  This is so at the end of the
>  install script these services can be started in a loop.
> 
> Also, remove the disable services loop since it only contains
> libvirtd and we don't want to always disable libvirtd when we
> install ovirt
> 
> Signed-off-by: Perry Myers <pmyers at redhat.com>
We actually probably do want libvirtd running on the WUI anyway, because we may
be able to use it as a fallback (if we can't find a suitable, running host
at
the moment) to do some of our "scanning" type stuff in taskomatic.  In
that
vein, the patch is fine, but I would add libvirtd to the list of ENABLE_SVCS.

ACK otherwise

Chris Lalancette