Ovirt devel - Apr 2008 - [Patch] hardware pool/vm resource pool model redesign

On Mon, Apr 14, 2008 at 11:47:58AM -0400, Scott Seago
wrote:
> This patch refactors the Hardware Pool and VM Resource Pool models. The 
> OrgPool/NetworkMap/HostCollection subclasses of HardwarePool are removed 
> entirely -- the HardwarePool hierarchy is once again completely flexible. 
> You can have a single host pool or a deep hierarchy. VM Library has  been 
> renamed to VM Resource Pool. At a model level, Hardware Pools and VM 
> Resource Pools now inherit from a common (abstract) Pool class -- but this 
> is not exposed in the UI.
>
> In addition to the simpler (and more flexible) Hardware Pool hierarchy, the
> other main focus for this change is to allow a hierarchy of VM Resource 
> Pools. The model now supports this, although the views do not (yet) allow 
> the creation of nested VM Resource Pools. In addition, the quota/resource 
> usage calculations do not yet deal with nested VM Pools.
>
> Anyway, here's the (somewhat large) patch...
Yikes, that's huge!

ACK based on your assurance that it works and the knowledge that we'll
need more cleanup as we go along.

One question: What is the indentation standard for ruby/rails code? I
notice you're using 2 spaces, is that normal?

Thanks,
--Hugh

Hugh O. Brock wrote:
>
>
> Yikes, that's huge!
>
> ACK based on your assurance that it works and the knowledge that we'll
> need more cleanup as we go along.
>
>   
Yeah, it's pretty huge -- I couldn't think of any obvious way to check 
in parts of this and have a semi-working system. Yes, we'll probably 
need some additional cleanup and fixes -- in particular I haven't run 
anyof this w/ taskomatic or the other back-end daemons.
> One question: What is the indentation standard for ruby/rails code? I
> notice you're using 2 spaces, is that normal?
>
>   
Does seem to be. I stuck w/ 2 spaces because that's what emacs ruby-mode 
does :-) -- but some poking around the other ruby code in rails seems to 
indicate that this is the norm.

Scott